All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Vlastimil Babka <vbabka@suse.cz>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Rientjes <rientjes@google.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	linux-mm@kvack.org, linux-arch@vger.kernel.org,
	linux-s390@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting
Date: Wed, 27 Jan 2016 14:09:09 +0100	[thread overview]
Message-ID: <56A8C175.9030702@de.ibm.com> (raw)
In-Reply-To: <56A8C028.7050305@suse.cz>

On 01/27/2016 02:03 PM, Vlastimil Babka wrote:
> On 01/27/2016 01:47 PM, Christian Borntraeger wrote:
>> On 01/27/2016 01:41 PM, Vlastimil Babka wrote:
>>> On 01/27/2016 01:59 AM, Joonsoo Kim wrote:
>>>
>>> I think it might be worth also to convert debug_pagealloc_enabled() to be based
>>> on static key, like I did for page_owner [1]. That should help make it possible
>>> to have virtually no overhead when compiling kernel with CONFIG_DEBUG_PAGEALLOC
>>> without enabling it boot-time. I assume it's one of the goals here?
>>
>> We could do something like that but dump_stack and setup of the initial identity
>> mapping of the kernel as well as the initial page protection are not hot path
>> as far as I can tell. Any other places?
> 
> Well, mostly kernel_map_pages() which is used in page allocation hotpaths.

Right. So indeed, static_key would be a good thing, but certainly an addon patch.

WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Vlastimil Babka <vbabka@suse.cz>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Rientjes <rientjes@google.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	linux-mm@kvack.org, linux-arch@vger.kernel.org,
	linux-s390@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting
Date: Wed, 27 Jan 2016 14:09:09 +0100	[thread overview]
Message-ID: <56A8C175.9030702@de.ibm.com> (raw)
In-Reply-To: <56A8C028.7050305@suse.cz>

On 01/27/2016 02:03 PM, Vlastimil Babka wrote:
> On 01/27/2016 01:47 PM, Christian Borntraeger wrote:
>> On 01/27/2016 01:41 PM, Vlastimil Babka wrote:
>>> On 01/27/2016 01:59 AM, Joonsoo Kim wrote:
>>>
>>> I think it might be worth also to convert debug_pagealloc_enabled() to be based
>>> on static key, like I did for page_owner [1]. That should help make it possible
>>> to have virtually no overhead when compiling kernel with CONFIG_DEBUG_PAGEALLOC
>>> without enabling it boot-time. I assume it's one of the goals here?
>>
>> We could do something like that but dump_stack and setup of the initial identity
>> mapping of the kernel as well as the initial page protection are not hot path
>> as far as I can tell. Any other places?
> 
> Well, mostly kernel_map_pages() which is used in page allocation hotpaths.

Right. So indeed, static_key would be a good thing, but certainly an addon patch.



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-01-27 13:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26  9:18 [PATCH/RFC 0/3] Optimize CONFIG_DEBUG_PAGEALLOC Christian Borntraeger
2016-01-26  9:18 ` Christian Borntraeger
2016-01-26  9:18 ` [PATCH/RFC 1/3] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC Christian Borntraeger
2016-01-26  9:18   ` Christian Borntraeger
2016-01-26 23:23   ` David Rientjes
2016-01-26 23:23     ` David Rientjes
2016-01-26  9:18 ` [PATCH/RFC 2/3] x86: query dynamic DEBUG_PAGEALLOC setting Christian Borntraeger
2016-01-26  9:18   ` Christian Borntraeger
2016-01-26  9:18 ` [PATCH/RFC 3/3] s390: " Christian Borntraeger
2016-01-26  9:18   ` Christian Borntraeger
2016-01-26 18:19   ` Heiko Carstens
2016-01-26 18:19     ` Heiko Carstens
2016-01-26 20:38     ` Thomas Gleixner
2016-01-26 20:38       ` Thomas Gleixner
2016-01-26 23:29     ` David Rientjes
2016-01-26 23:29       ` David Rientjes
2016-01-27  0:19       ` Joonsoo Kim
2016-01-27  0:19         ` Joonsoo Kim
2016-01-27  0:36         ` David Rientjes
2016-01-27  0:36           ` David Rientjes
2016-01-27  0:59           ` Joonsoo Kim
2016-01-27  0:59             ` Joonsoo Kim
2016-01-27  7:59             ` Christian Borntraeger
2016-01-27  7:59               ` Christian Borntraeger
2016-01-27 12:41             ` Vlastimil Babka
2016-01-27 12:41               ` Vlastimil Babka
2016-01-27 12:47               ` Christian Borntraeger
2016-01-27 12:47                 ` Christian Borntraeger
2016-01-27 13:03                 ` Vlastimil Babka
2016-01-27 13:03                   ` Vlastimil Babka
2016-01-27 13:09                   ` Christian Borntraeger [this message]
2016-01-27 13:09                     ` Christian Borntraeger
2016-01-28  4:25                   ` Joonsoo Kim
2016-01-28  4:25                     ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A8C175.9030702@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.