From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ipv4: ipconfig: avoid unused ic_proto_used symbol
Date: Thu, 28 Jan 2016 16:11:44 +0300 [thread overview]
Message-ID: <56AA1390.6000503@cogentembedded.com> (raw)
In-Reply-To: <1453902853-3424272-1-git-send-email-arnd@arndb.de>
Hello.
On 1/27/2016 4:53 PM, Arnd Bergmann wrote:
> When CONFIG_PROC_FS, CONFIG_IP_PNP_BOOTP, CONFIG_IP_PNP_DHCP and
> CONFIG_IP_PNP_RARP are all disabled, we get a warning about the
> ic_proto_used variable being unused:
>
> net/ipv4/ipconfig.c:146:12: error: 'ic_proto_used' defined but not used [-Werror=unused-variable]
>
> This avoids the warning, but making the definition conditional on
s/but/by/?
> whether a dynamic IP configuration protocol is configured. If not,
> we know that the value is always zero, so we can optimize away the
> variable and all code that depends on it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>
Cc: linux-arm-kernel@lists.infradead.org,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv4: ipconfig: avoid unused ic_proto_used symbol
Date: Thu, 28 Jan 2016 16:11:44 +0300 [thread overview]
Message-ID: <56AA1390.6000503@cogentembedded.com> (raw)
In-Reply-To: <1453902853-3424272-1-git-send-email-arnd@arndb.de>
Hello.
On 1/27/2016 4:53 PM, Arnd Bergmann wrote:
> When CONFIG_PROC_FS, CONFIG_IP_PNP_BOOTP, CONFIG_IP_PNP_DHCP and
> CONFIG_IP_PNP_RARP are all disabled, we get a warning about the
> ic_proto_used variable being unused:
>
> net/ipv4/ipconfig.c:146:12: error: 'ic_proto_used' defined but not used [-Werror=unused-variable]
>
> This avoids the warning, but making the definition conditional on
s/but/by/?
> whether a dynamic IP configuration protocol is configured. If not,
> we know that the value is always zero, so we can optimize away the
> variable and all code that depends on it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-01-28 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 13:53 [PATCH] ipv4: ipconfig: avoid unused ic_proto_used symbol Arnd Bergmann
2016-01-27 13:53 ` Arnd Bergmann
2016-01-28 13:11 ` Sergei Shtylyov [this message]
2016-01-28 13:11 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA1390.6000503@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.