From: Eric Blake <eblake@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Alexander Graf <agraf@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>,
"open list:PowerPC" <qemu-ppc@nongnu.org>,
"open list:Overall" <kvm@vger.kernel.org>
Subject: Re: [PATCH v4 4/5] util: [ppc] Use new error_report_abort() instead of abort()
Date: Thu, 28 Jan 2016 14:45:58 -0700 [thread overview]
Message-ID: <56AA8C16.3090602@redhat.com> (raw)
In-Reply-To: <145401729734.31479.15887562149880928240.stgit@localhost>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
On 01/28/2016 02:41 PM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> target-ppc/kvm.c | 4 ++--
> target-ppc/kvm_ppc.h | 15 +++++++++------
> target-ppc/mmu-hash32.c | 5 +++--
> target-ppc/mmu_helper.c | 3 +--
> 4 files changed, 15 insertions(+), 12 deletions(-)
>
> +++ b/target-ppc/kvm_ppc.h
> @@ -9,6 +9,9 @@
> #ifndef __KVM_PPC_H__
> #define __KVM_PPC_H__
>
> +#include "qemu/error-report.h"
> +
> +
> #define TYPE_HOST_POWERPC_CPU "host-" TYPE_POWERPC_CPU
>
> #ifdef CONFIG_KVM
> @@ -220,36 +223,36 @@ static inline int kvmppc_get_htab_fd(bool write)
> static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize,
> int64_t max_ns)
> {
> - abort();
> + error_report_abort(" ");
Aborting with an empty string with trailing spaces feels awkward.
Either this should be a real message, or abort() was just fine.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
"open list:Overall" <kvm@vger.kernel.org>,
Stefan Hajnoczi <stefanha@gmail.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Alexander Graf <agraf@suse.de>,
"open list:PowerPC" <qemu-ppc@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 4/5] util: [ppc] Use new error_report_abort() instead of abort()
Date: Thu, 28 Jan 2016 14:45:58 -0700 [thread overview]
Message-ID: <56AA8C16.3090602@redhat.com> (raw)
In-Reply-To: <145401729734.31479.15887562149880928240.stgit@localhost>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
On 01/28/2016 02:41 PM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> target-ppc/kvm.c | 4 ++--
> target-ppc/kvm_ppc.h | 15 +++++++++------
> target-ppc/mmu-hash32.c | 5 +++--
> target-ppc/mmu_helper.c | 3 +--
> 4 files changed, 15 insertions(+), 12 deletions(-)
>
> +++ b/target-ppc/kvm_ppc.h
> @@ -9,6 +9,9 @@
> #ifndef __KVM_PPC_H__
> #define __KVM_PPC_H__
>
> +#include "qemu/error-report.h"
> +
> +
> #define TYPE_HOST_POWERPC_CPU "host-" TYPE_POWERPC_CPU
>
> #ifdef CONFIG_KVM
> @@ -220,36 +223,36 @@ static inline int kvmppc_get_htab_fd(bool write)
> static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize,
> int64_t max_ns)
> {
> - abort();
> + error_report_abort(" ");
Aborting with an empty string with trailing spaces feels awkward.
Either this should be a real message, or abort() was just fine.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-28 21:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 21:41 [Qemu-devel] [RFC][PATCH v4 0/5] utils: Improve and document error reporting Lluís Vilanova
2016-01-28 21:41 ` [Qemu-devel] [PATCH v4 1/5] util: Introduce error reporting functions with fatal/abort Lluís Vilanova
2016-01-28 21:41 ` [Qemu-devel] [PATCH v4 2/5] util: Use new error_report_fatal/abort instead of error_setg(&error_fatal/abort) Lluís Vilanova
2016-01-28 21:41 ` [PATCH v4 3/5] util: [ppc] Use new error_report_fatal() instead of exit() Lluís Vilanova
2016-01-28 21:41 ` [Qemu-devel] " Lluís Vilanova
2016-01-28 21:41 ` [PATCH v4 4/5] util: [ppc] Use new error_report_abort() instead of abort() Lluís Vilanova
2016-01-28 21:41 ` [Qemu-devel] " Lluís Vilanova
2016-01-28 21:45 ` Eric Blake [this message]
2016-01-28 21:45 ` Eric Blake
2016-01-28 22:16 ` Lluís Vilanova
2016-01-28 22:16 ` [Qemu-devel] " Lluís Vilanova
2016-01-28 21:41 ` [Qemu-devel] [PATCH v4 5/5] doc: Introduce coding style for errors Lluís Vilanova
2016-01-28 21:50 ` Eric Blake
2016-01-28 22:14 ` Lluís Vilanova
2016-01-28 21:55 ` [Qemu-devel] [RFC][PATCH v4 0/5] utils: Improve and document error reporting Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA8C16.3090602@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=stefanha@gmail.com \
--cc=thuth@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.