From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [RFC PATCH 6/8] dbus: Handle legacy GetProperties and SetProperty automatically.
Date: Thu, 28 Jan 2016 18:16:07 -0600 [thread overview]
Message-ID: <56AAAF47.6040405@gmail.com> (raw)
In-Reply-To: <1453517972-22833-6-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 954 bytes --]
Hi Andrew,
On 01/22/2016 08:59 PM, Andrew Zaborowski wrote:
> ---
> ell/dbus-service.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++--
> examples/dbus-service.c | 86 +------------------
> 2 files changed, 212 insertions(+), 90 deletions(-)
>
<snip>
> +static struct l_dbus_message *old_set_property(struct l_dbus *dbus,
> + struct l_dbus_message *message,
> + void *user_data)
> +{
<snip>
> +
> + signature = property->metainfo + strlen(property->metainfo) + 1;
> +
> + if (l_dbus_message_iter_get_type(&variant) != signature[0])
> + return l_dbus_message_new_error(message,
> + "org.freedesktop.DBus.Error."
> + "InvalidArgs",
> + "Expected type '%s'",
> + signature);
> +
Is this check strictly needed? The setter would be running a
l_dbus_message_iter_get_variant call anyway which does a more thorough
signature check.
Rest looks fine.
Regards,
-Denis
next prev parent reply other threads:[~2016-01-29 0:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 2:59 [RFC PATCH 1/8] dbus: setters and getters API for properties Andrew Zaborowski
2016-01-23 2:59 ` [RFC PATCH 2/8] dbus: Separate interface registration from instantiation Andrew Zaborowski
2016-01-26 21:13 ` Denis Kenzior
2016-01-26 23:40 ` Andrzej Zaborowski
2016-01-27 0:16 ` Denis Kenzior
2016-01-23 2:59 ` [RFC PATCH 3/8] dbus: Don't show Introspectable on intermediate nodes Andrew Zaborowski
2016-01-25 15:48 ` Denis Kenzior
2016-01-23 2:59 ` [RFC PATCH 4/8] dbus: Message builder function to copy from an iter Andrew Zaborowski
2016-01-23 2:59 ` [RFC PATCH 5/8] dbus: Private function to retrieve the tree for a connection Andrew Zaborowski
2016-01-23 2:59 ` [RFC PATCH 6/8] dbus: Handle legacy GetProperties and SetProperty automatically Andrew Zaborowski
2016-01-29 0:16 ` Denis Kenzior [this message]
2016-01-23 2:59 ` [RFC PATCH 7/8] dbus: Implement org.freedesktop.DBus.Properties Andrew Zaborowski
2016-01-23 2:59 ` [RFC PATCH 8/8] dbus: Implement org.freedesktop.DBus.ObjectManager Andrew Zaborowski
2016-01-29 3:35 ` Denis Kenzior
2016-01-29 16:47 ` Andrzej Zaborowski
2016-01-29 17:44 ` Denis Kenzior
2016-01-29 18:53 ` Andrzej Zaborowski
2016-01-29 19:19 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AAAF47.6040405@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.