From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] fbdev: mmp: print IRQ resource using %pR format string
Date: Fri, 29 Jan 2016 11:43:35 +0000 [thread overview]
Message-ID: <56AB5067.4010405@ti.com> (raw)
In-Reply-To: <1453734191-1958245-1-git-send-email-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
On 25/01/16 17:03, Arnd Bergmann wrote:
> resource_size_t cannot be printed using the %x format string
> when we it is defined as u64:
>
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c: In function 'mmphw_probe':
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c:506:22: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
> dev_err(ctrl->dev, "%s: res %x - %x map failed\n", __func__,
> ^
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c:506:22: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
>
> This changes the format string to %pR, which is interpreted
> by the printk implementation to pretty-print a resource
> structure.
Thanks, queued for 4.5 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fbdev: mmp: print IRQ resource using %pR format string
Date: Fri, 29 Jan 2016 13:43:35 +0200 [thread overview]
Message-ID: <56AB5067.4010405@ti.com> (raw)
In-Reply-To: <1453734191-1958245-1-git-send-email-arnd@arndb.de>
On 25/01/16 17:03, Arnd Bergmann wrote:
> resource_size_t cannot be printed using the %x format string
> when we it is defined as u64:
>
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c: In function 'mmphw_probe':
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c:506:22: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
> dev_err(ctrl->dev, "%s: res %x - %x map failed\n", __func__,
> ^
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c:506:22: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
>
> This changes the format string to %pR, which is interpreted
> by the printk implementation to pretty-print a resource
> structure.
Thanks, queued for 4.5 fixes.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160129/d322aeb2/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fbdev: mmp: print IRQ resource using %pR format string
Date: Fri, 29 Jan 2016 13:43:35 +0200 [thread overview]
Message-ID: <56AB5067.4010405@ti.com> (raw)
In-Reply-To: <1453734191-1958245-1-git-send-email-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
On 25/01/16 17:03, Arnd Bergmann wrote:
> resource_size_t cannot be printed using the %x format string
> when we it is defined as u64:
>
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c: In function 'mmphw_probe':
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c:506:22: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
> dev_err(ctrl->dev, "%s: res %x - %x map failed\n", __func__,
> ^
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c:506:22: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
>
> This changes the format string to %pR, which is interpreted
> by the printk implementation to pretty-print a resource
> structure.
Thanks, queued for 4.5 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-29 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:03 [PATCH] fbdev: mmp: print IRQ resource using %pR format string Arnd Bergmann
2016-01-25 15:03 ` Arnd Bergmann
2016-01-25 15:03 ` Arnd Bergmann
2016-01-29 11:43 ` Tomi Valkeinen [this message]
2016-01-29 11:43 ` Tomi Valkeinen
2016-01-29 11:43 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AB5067.4010405@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.