From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsa@cumulusnetworks.com>,
Hajime Tazaki <thehajime@gmail.com>,
lucien.xin@gmail.com,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH net v2 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()
Date: Fri, 29 Jan 2016 13:33:47 +0100 [thread overview]
Message-ID: <56AB5C2B.9030307@stressinduktion.org> (raw)
In-Reply-To: <f7809ccbe430587d183d9679b8fbea4b61a9af7e.1454066754.git.pabeni@redhat.com>
On 29.01.2016 12:30, Paolo Abeni wrote:
> The current implementation of ip6_dst_lookup_tail basically
> ignore the egress ifindex match: if the saddr is set,
> ip6_route_output() purposefully ignores flowi6_oif, due
> to the commit d46a9d678e4c ("net: ipv6: Dont add RT6_LOOKUP_F_IFACE
> flag if saddr set"), if the saddr is 'any' the first route lookup
> in ip6_dst_lookup_tail fails, but upon failure a second lookup will
> be performed with saddr set, thus ignoring the ifindex constraint.
>
> This commit adds an output route lookup function variant, which
> allows the caller to specify lookup flags, and modify
> ip6_dst_lookup_tail() to enforce the ifindex match on the second
> lookup via said helper.
>
> ip6_route_output() becames now a static inline function build on
> top of ip6_route_output_flags(); as a side effect, out-of-tree
> modules need now a GPL license to access the output route lookup
> functionality.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> --
> v1 -> v2 move the ip6_route_output() implementation into the header
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
next prev parent reply other threads:[~2016-01-29 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 11:30 [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour Paolo Abeni
2016-01-29 11:30 ` [PATCH net v2 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail() Paolo Abeni
2016-01-29 12:33 ` Hannes Frederic Sowa [this message]
2016-02-01 2:24 ` YOSHIFUJI Hideaki
2016-01-29 16:00 ` David Ahern
2016-01-29 11:30 ` [PATCH net v2 2/2] ipv6/udp: use sticky pktinfo egress ifindex on connect() Paolo Abeni
2016-01-29 12:33 ` Hannes Frederic Sowa
2016-02-01 2:23 ` YOSHIFUJI Hideaki
2016-02-02 2:06 ` David Ahern
2016-02-02 2:18 ` David Miller
2016-01-29 12:36 ` [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour Hannes Frederic Sowa
2016-01-30 4:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AB5C2B.9030307@stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thehajime@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.