All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	David Ahern <dsa@cumulusnetworks.com>,
	Hajime Tazaki <thehajime@gmail.com>,
	lucien.xin@gmail.com,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour
Date: Fri, 29 Jan 2016 13:36:09 +0100	[thread overview]
Message-ID: <56AB5CB9.8040103@stressinduktion.org> (raw)
In-Reply-To: <cover.1454066754.git.pabeni@redhat.com>

On 29.01.2016 12:30, Paolo Abeni wrote:
> The kernel has never enforced the egress interface specified
> via the sticky pktinfo, except briefly between the commits
> 741a11d9e410 ("net: ipv6: Add RT6_LOOKUP_F_IFACE flag if oif is set")
> and
> d46a9d678e4c ("net: ipv6: Dont add RT6_LOOKUP_F_IFACE flag if saddr set"),
> but the ping6 tools was unaffected up to iputils-20100214,
> since before it used SO_BINDTODEVICE to enforce the egress
> interface.

I think because of the bad situation in terms of uapi and that recently 
behavior switched multiple times in kernel and iputils, enforcing the 
outgoing interface seems to be the right thing to do for me.

Also it matches expected behavior by ping6. Treating the interface as 
enforced is from a standards PoV the correct thing to do.

Thanks,
Hannes

  parent reply	other threads:[~2016-01-29 12:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 11:30 [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour Paolo Abeni
2016-01-29 11:30 ` [PATCH net v2 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail() Paolo Abeni
2016-01-29 12:33   ` Hannes Frederic Sowa
2016-02-01  2:24     ` YOSHIFUJI Hideaki
2016-01-29 16:00   ` David Ahern
2016-01-29 11:30 ` [PATCH net v2 2/2] ipv6/udp: use sticky pktinfo egress ifindex on connect() Paolo Abeni
2016-01-29 12:33   ` Hannes Frederic Sowa
2016-02-01  2:23     ` YOSHIFUJI Hideaki
2016-02-02  2:06       ` David Ahern
2016-02-02  2:18         ` David Miller
2016-01-29 12:36 ` Hannes Frederic Sowa [this message]
2016-01-30  4:31 ` [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AB5CB9.8040103@stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=thehajime@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.