* [PATCH 1/3] drm: add helper to check for wc memory support
@ 2016-01-30 5:59 Oded Gabbay
2016-01-30 5:59 ` [PATCH 2/3] drm/radeon: mask out WC from BO on unsupported arches Oded Gabbay
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Oded Gabbay @ 2016-01-30 5:59 UTC (permalink / raw)
To: dri-devel, alexdeucher; +Cc: Dave Airlie, michel.daenzer
From: Dave Airlie <airlied@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
---
include/drm/drm_cache.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h
index 7bfb063..461a055 100644
--- a/include/drm/drm_cache.h
+++ b/include/drm/drm_cache.h
@@ -35,4 +35,13 @@
void drm_clflush_pages(struct page *pages[], unsigned long num_pages);
+static inline bool drm_arch_can_wc_memory(void)
+{
+#if defined(CONFIG_PPC) && !defined(CONFIG_NOT_COHERENT_CACHE)
+ return false;
+#else
+ return true;
+#endif
+}
+
#endif
--
2.5.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/3] drm/radeon: mask out WC from BO on unsupported arches 2016-01-30 5:59 [PATCH 1/3] drm: add helper to check for wc memory support Oded Gabbay @ 2016-01-30 5:59 ` Oded Gabbay 2016-01-30 8:11 ` Michel Dänzer 2016-01-30 5:59 ` [PATCH 3/3] drm/amdgpu: " Oded Gabbay 2016-01-30 9:57 ` [PATCH 1/3] drm: add helper to check for wc memory support Christian König 2 siblings, 1 reply; 12+ messages in thread From: Oded Gabbay @ 2016-01-30 5:59 UTC (permalink / raw) To: dri-devel, alexdeucher; +Cc: michel.daenzer Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> --- drivers/gpu/drm/radeon/radeon_object.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index 84d4563..255faf6 100644 --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -33,6 +33,7 @@ #include <linux/slab.h> #include <drm/drmP.h> #include <drm/radeon_drm.h> +#include <drm/drm_cache.h> #include "radeon.h" #include "radeon_trace.h" @@ -245,6 +246,13 @@ int radeon_bo_create(struct radeon_device *rdev, DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for " "better performance thanks to write-combining\n"); bo->flags &= ~(RADEON_GEM_GTT_WC | RADEON_GEM_GTT_UC); +#else + /* + * For architectures that don't support WC memory, + * mask out the WC flag from the BO + */ + if (!drm_arch_can_wc_memory()) + bo->flags &= ~RADEON_GEM_GTT_WC; #endif radeon_ttm_placement_from_domain(bo, domain); -- 2.5.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] drm/radeon: mask out WC from BO on unsupported arches 2016-01-30 5:59 ` [PATCH 2/3] drm/radeon: mask out WC from BO on unsupported arches Oded Gabbay @ 2016-01-30 8:11 ` Michel Dänzer 2016-01-30 10:58 ` Oded Gabbay 0 siblings, 1 reply; 12+ messages in thread From: Michel Dänzer @ 2016-01-30 8:11 UTC (permalink / raw) To: Oded Gabbay, alexdeucher; +Cc: dri-devel On 30.01.2016 14:59, Oded Gabbay wrote: > Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> > --- > drivers/gpu/drm/radeon/radeon_object.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c > index 84d4563..255faf6 100644 > --- a/drivers/gpu/drm/radeon/radeon_object.c > +++ b/drivers/gpu/drm/radeon/radeon_object.c > @@ -33,6 +33,7 @@ > #include <linux/slab.h> > #include <drm/drmP.h> > #include <drm/radeon_drm.h> > +#include <drm/drm_cache.h> > #include "radeon.h" > #include "radeon_trace.h" > > @@ -245,6 +246,13 @@ int radeon_bo_create(struct radeon_device *rdev, > DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for " > "better performance thanks to write-combining\n"); > bo->flags &= ~(RADEON_GEM_GTT_WC | RADEON_GEM_GTT_UC); > +#else > + /* > + * For architectures that don't support WC memory, > + * mask out the WC flag from the BO > + */ > + if (!drm_arch_can_wc_memory()) > + bo->flags &= ~RADEON_GEM_GTT_WC; > #endif For consistency with existing multi-line comments, please start the comment on the opening line: /* For architectures that don't support WC memory, * mask out the WC flag from the BO */ With that fixed (in patch 3 as well), the series is Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] drm/radeon: mask out WC from BO on unsupported arches 2016-01-30 8:11 ` Michel Dänzer @ 2016-01-30 10:58 ` Oded Gabbay 0 siblings, 0 replies; 12+ messages in thread From: Oded Gabbay @ 2016-01-30 10:58 UTC (permalink / raw) To: Michel Dänzer; +Cc: Maling list - DRI developers On Sat, Jan 30, 2016 at 10:11 AM, Michel Dänzer <michel@daenzer.net> wrote: > On 30.01.2016 14:59, Oded Gabbay wrote: >> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> >> --- >> drivers/gpu/drm/radeon/radeon_object.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c >> index 84d4563..255faf6 100644 >> --- a/drivers/gpu/drm/radeon/radeon_object.c >> +++ b/drivers/gpu/drm/radeon/radeon_object.c >> @@ -33,6 +33,7 @@ >> #include <linux/slab.h> >> #include <drm/drmP.h> >> #include <drm/radeon_drm.h> >> +#include <drm/drm_cache.h> >> #include "radeon.h" >> #include "radeon_trace.h" >> >> @@ -245,6 +246,13 @@ int radeon_bo_create(struct radeon_device *rdev, >> DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for " >> "better performance thanks to write-combining\n"); >> bo->flags &= ~(RADEON_GEM_GTT_WC | RADEON_GEM_GTT_UC); >> +#else >> + /* >> + * For architectures that don't support WC memory, >> + * mask out the WC flag from the BO >> + */ >> + if (!drm_arch_can_wc_memory()) >> + bo->flags &= ~RADEON_GEM_GTT_WC; >> #endif > > For consistency with existing multi-line comments, please start the > comment on the opening line: > > /* For architectures that don't support WC memory, > * mask out the WC flag from the BO > */ > > With that fixed (in patch 3 as well), the series is > > Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Mesa and X developer Kernel coding style says differently... _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/3] drm/amdgpu: mask out WC from BO on unsupported arches 2016-01-30 5:59 [PATCH 1/3] drm: add helper to check for wc memory support Oded Gabbay 2016-01-30 5:59 ` [PATCH 2/3] drm/radeon: mask out WC from BO on unsupported arches Oded Gabbay @ 2016-01-30 5:59 ` Oded Gabbay 2016-01-30 9:57 ` [PATCH 1/3] drm: add helper to check for wc memory support Christian König 2 siblings, 0 replies; 12+ messages in thread From: Oded Gabbay @ 2016-01-30 5:59 UTC (permalink / raw) To: dri-devel, alexdeucher; +Cc: michel.daenzer Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index c3ce103..7b963e6 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c @@ -33,6 +33,7 @@ #include <linux/slab.h> #include <drm/drmP.h> #include <drm/amdgpu_drm.h> +#include <drm/drm_cache.h> #include "amdgpu.h" #include "amdgpu_trace.h" @@ -261,6 +262,14 @@ int amdgpu_bo_create_restricted(struct amdgpu_device *adev, AMDGPU_GEM_DOMAIN_OA); bo->flags = flags; + + /* + * For architectures that don't support WC memory, + * mask out the WC flag from the BO + */ + if (!drm_arch_can_wc_memory()) + bo->flags &= ~AMDGPU_GEM_CREATE_CPU_GTT_USWC; + amdgpu_fill_placement_to_bo(bo, placement); /* Kernel allocation are uninterruptible */ r = ttm_bo_init(&adev->mman.bdev, &bo->tbo, size, type, -- 2.5.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm: add helper to check for wc memory support 2016-01-30 5:59 [PATCH 1/3] drm: add helper to check for wc memory support Oded Gabbay 2016-01-30 5:59 ` [PATCH 2/3] drm/radeon: mask out WC from BO on unsupported arches Oded Gabbay 2016-01-30 5:59 ` [PATCH 3/3] drm/amdgpu: " Oded Gabbay @ 2016-01-30 9:57 ` Christian König 2016-02-01 17:01 ` Alex Deucher 2 siblings, 1 reply; 12+ messages in thread From: Christian König @ 2016-01-30 9:57 UTC (permalink / raw) To: Oded Gabbay, dri-devel, alexdeucher; +Cc: Dave Airlie, michel.daenzer Am 30.01.2016 um 06:59 schrieb Oded Gabbay: > From: Dave Airlie <airlied@redhat.com> > > Signed-off-by: Dave Airlie <airlied@redhat.com> > Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> With the minor issues Michel noted fixed this series is Reviewed-by: Christian König <christian.koenig@amd.com> as well. > --- > include/drm/drm_cache.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h > index 7bfb063..461a055 100644 > --- a/include/drm/drm_cache.h > +++ b/include/drm/drm_cache.h > @@ -35,4 +35,13 @@ > > void drm_clflush_pages(struct page *pages[], unsigned long num_pages); > > +static inline bool drm_arch_can_wc_memory(void) > +{ > +#if defined(CONFIG_PPC) && !defined(CONFIG_NOT_COHERENT_CACHE) > + return false; > +#else > + return true; > +#endif > +} > + > #endif _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm: add helper to check for wc memory support 2016-01-30 9:57 ` [PATCH 1/3] drm: add helper to check for wc memory support Christian König @ 2016-02-01 17:01 ` Alex Deucher 2016-02-02 12:01 ` Oded Gabbay 0 siblings, 1 reply; 12+ messages in thread From: Alex Deucher @ 2016-02-01 17:01 UTC (permalink / raw) To: Christian König Cc: Dave Airlie, Daenzer, Michel, Maling list - DRI developers On Sat, Jan 30, 2016 at 4:57 AM, Christian König <deathsimple@vodafone.de> wrote: > Am 30.01.2016 um 06:59 schrieb Oded Gabbay: >> >> From: Dave Airlie <airlied@redhat.com> >> >> Signed-off-by: Dave Airlie <airlied@redhat.com> >> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> > > > With the minor issues Michel noted fixed this series is Reviewed-by: > Christian König <christian.koenig@amd.com> as well. Applied with the comments fixed up. Thanks! Alex > > >> --- >> include/drm/drm_cache.h | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h >> index 7bfb063..461a055 100644 >> --- a/include/drm/drm_cache.h >> +++ b/include/drm/drm_cache.h >> @@ -35,4 +35,13 @@ >> void drm_clflush_pages(struct page *pages[], unsigned long num_pages); >> +static inline bool drm_arch_can_wc_memory(void) >> +{ >> +#if defined(CONFIG_PPC) && !defined(CONFIG_NOT_COHERENT_CACHE) >> + return false; >> +#else >> + return true; >> +#endif >> +} >> + >> #endif > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm: add helper to check for wc memory support 2016-02-01 17:01 ` Alex Deucher @ 2016-02-02 12:01 ` Oded Gabbay 2016-02-02 15:07 ` Alex Deucher 0 siblings, 1 reply; 12+ messages in thread From: Oded Gabbay @ 2016-02-02 12:01 UTC (permalink / raw) To: Alex Deucher; +Cc: Dave Airlie, Daenzer, Michel, Maling list - DRI developers On Mon, Feb 1, 2016 at 7:01 PM, Alex Deucher <alexdeucher@gmail.com> wrote: > > On Sat, Jan 30, 2016 at 4:57 AM, Christian König > <deathsimple@vodafone.de> wrote: > > Am 30.01.2016 um 06:59 schrieb Oded Gabbay: > >> > >> From: Dave Airlie <airlied@redhat.com> > >> > >> Signed-off-by: Dave Airlie <airlied@redhat.com> > >> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> > > > > > > With the minor issues Michel noted fixed this series is Reviewed-by: > > Christian König <christian.koenig@amd.com> as well. > > Applied with the comments fixed up. Thanks! > > Alex > Hi Alex, Could you please add stable tag ? I forgot to add them. Thanks, Oded > > > > > > >> --- > >> include/drm/drm_cache.h | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h > >> index 7bfb063..461a055 100644 > >> --- a/include/drm/drm_cache.h > >> +++ b/include/drm/drm_cache.h > >> @@ -35,4 +35,13 @@ > >> void drm_clflush_pages(struct page *pages[], unsigned long num_pages); > >> +static inline bool drm_arch_can_wc_memory(void) > >> +{ > >> +#if defined(CONFIG_PPC) && !defined(CONFIG_NOT_COHERENT_CACHE) > >> + return false; > >> +#else > >> + return true; > >> +#endif > >> +} > >> + > >> #endif > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm: add helper to check for wc memory support 2016-02-02 12:01 ` Oded Gabbay @ 2016-02-02 15:07 ` Alex Deucher 2016-02-03 8:17 ` Oded Gabbay 0 siblings, 1 reply; 12+ messages in thread From: Alex Deucher @ 2016-02-02 15:07 UTC (permalink / raw) To: Oded Gabbay; +Cc: Dave Airlie, Daenzer, Michel, Maling list - DRI developers On Tue, Feb 2, 2016 at 7:01 AM, Oded Gabbay <oded.gabbay@gmail.com> wrote: > On Mon, Feb 1, 2016 at 7:01 PM, Alex Deucher <alexdeucher@gmail.com> wrote: >> >> On Sat, Jan 30, 2016 at 4:57 AM, Christian König >> <deathsimple@vodafone.de> wrote: >> > Am 30.01.2016 um 06:59 schrieb Oded Gabbay: >> >> >> >> From: Dave Airlie <airlied@redhat.com> >> >> >> >> Signed-off-by: Dave Airlie <airlied@redhat.com> >> >> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> >> > >> > >> > With the minor issues Michel noted fixed this series is Reviewed-by: >> > Christian König <christian.koenig@amd.com> as well. >> >> Applied with the comments fixed up. Thanks! >> >> Alex >> > > Hi Alex, > Could you please add stable tag ? I forgot to add them. Will do. Alex > Thanks, > > Oded > > >> >> > >> > >> >> --- >> >> include/drm/drm_cache.h | 9 +++++++++ >> >> 1 file changed, 9 insertions(+) >> >> >> >> diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h >> >> index 7bfb063..461a055 100644 >> >> --- a/include/drm/drm_cache.h >> >> +++ b/include/drm/drm_cache.h >> >> @@ -35,4 +35,13 @@ >> >> void drm_clflush_pages(struct page *pages[], unsigned long num_pages); >> >> +static inline bool drm_arch_can_wc_memory(void) >> >> +{ >> >> +#if defined(CONFIG_PPC) && !defined(CONFIG_NOT_COHERENT_CACHE) >> >> + return false; >> >> +#else >> >> + return true; >> >> +#endif >> >> +} >> >> + >> >> #endif >> > >> > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm: add helper to check for wc memory support 2016-02-02 15:07 ` Alex Deucher @ 2016-02-03 8:17 ` Oded Gabbay 2016-02-03 13:53 ` Alex Deucher 0 siblings, 1 reply; 12+ messages in thread From: Oded Gabbay @ 2016-02-03 8:17 UTC (permalink / raw) To: Alex Deucher; +Cc: Dave Airlie, Daenzer, Michel, Maling list - DRI developers On Tue, Feb 2, 2016 at 5:07 PM, Alex Deucher <alexdeucher@gmail.com> wrote: > On Tue, Feb 2, 2016 at 7:01 AM, Oded Gabbay <oded.gabbay@gmail.com> wrote: >> On Mon, Feb 1, 2016 at 7:01 PM, Alex Deucher <alexdeucher@gmail.com> wrote: >>> >>> On Sat, Jan 30, 2016 at 4:57 AM, Christian König >>> <deathsimple@vodafone.de> wrote: >>> > Am 30.01.2016 um 06:59 schrieb Oded Gabbay: >>> >> >>> >> From: Dave Airlie <airlied@redhat.com> >>> >> >>> >> Signed-off-by: Dave Airlie <airlied@redhat.com> >>> >> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> >>> > >>> > >>> > With the minor issues Michel noted fixed this series is Reviewed-by: >>> > Christian König <christian.koenig@amd.com> as well. >>> >>> Applied with the comments fixed up. Thanks! >>> >>> Alex >>> >> >> Hi Alex, >> Could you please add stable tag ? I forgot to add them. > > Will do. > > Alex Thanks. Alex, I saw you put the patches into your drm-next-4.6. As these are fixes, any chance you could instead put them to drm-fixes-4.5 ? for -rc3/4 ? Oded > >> Thanks, >> >> Oded >> >> >>> >>> > >>> > >>> >> --- >>> >> include/drm/drm_cache.h | 9 +++++++++ >>> >> 1 file changed, 9 insertions(+) >>> >> >>> >> diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h >>> >> index 7bfb063..461a055 100644 >>> >> --- a/include/drm/drm_cache.h >>> >> +++ b/include/drm/drm_cache.h >>> >> @@ -35,4 +35,13 @@ >>> >> void drm_clflush_pages(struct page *pages[], unsigned long num_pages); >>> >> +static inline bool drm_arch_can_wc_memory(void) >>> >> +{ >>> >> +#if defined(CONFIG_PPC) && !defined(CONFIG_NOT_COHERENT_CACHE) >>> >> + return false; >>> >> +#else >>> >> + return true; >>> >> +#endif >>> >> +} >>> >> + >>> >> #endif >>> > >>> > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm: add helper to check for wc memory support 2016-02-03 8:17 ` Oded Gabbay @ 2016-02-03 13:53 ` Alex Deucher 2016-02-03 14:00 ` Oded Gabbay 0 siblings, 1 reply; 12+ messages in thread From: Alex Deucher @ 2016-02-03 13:53 UTC (permalink / raw) To: Oded Gabbay; +Cc: Dave Airlie, Daenzer, Michel, Maling list - DRI developers On Wed, Feb 3, 2016 at 3:17 AM, Oded Gabbay <oded.gabbay@gmail.com> wrote: > On Tue, Feb 2, 2016 at 5:07 PM, Alex Deucher <alexdeucher@gmail.com> wrote: >> On Tue, Feb 2, 2016 at 7:01 AM, Oded Gabbay <oded.gabbay@gmail.com> wrote: >>> On Mon, Feb 1, 2016 at 7:01 PM, Alex Deucher <alexdeucher@gmail.com> wrote: >>>> >>>> On Sat, Jan 30, 2016 at 4:57 AM, Christian König >>>> <deathsimple@vodafone.de> wrote: >>>> > Am 30.01.2016 um 06:59 schrieb Oded Gabbay: >>>> >> >>>> >> From: Dave Airlie <airlied@redhat.com> >>>> >> >>>> >> Signed-off-by: Dave Airlie <airlied@redhat.com> >>>> >> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> >>>> > >>>> > >>>> > With the minor issues Michel noted fixed this series is Reviewed-by: >>>> > Christian König <christian.koenig@amd.com> as well. >>>> >>>> Applied with the comments fixed up. Thanks! >>>> >>>> Alex >>>> >>> >>> Hi Alex, >>> Could you please add stable tag ? I forgot to add them. >> >> Will do. >> >> Alex > > Thanks. > > Alex, > I saw you put the patches into your drm-next-4.6. > As these are fixes, any chance you could instead put them to > drm-fixes-4.5 ? for -rc3/4 ? They'll be in my -fixes pull this week. I put them in my 4.6-wip tree for additional testing. Alex > > Oded > >> >>> Thanks, >>> >>> Oded >>> >>> >>>> >>>> > >>>> > >>>> >> --- >>>> >> include/drm/drm_cache.h | 9 +++++++++ >>>> >> 1 file changed, 9 insertions(+) >>>> >> >>>> >> diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h >>>> >> index 7bfb063..461a055 100644 >>>> >> --- a/include/drm/drm_cache.h >>>> >> +++ b/include/drm/drm_cache.h >>>> >> @@ -35,4 +35,13 @@ >>>> >> void drm_clflush_pages(struct page *pages[], unsigned long num_pages); >>>> >> +static inline bool drm_arch_can_wc_memory(void) >>>> >> +{ >>>> >> +#if defined(CONFIG_PPC) && !defined(CONFIG_NOT_COHERENT_CACHE) >>>> >> + return false; >>>> >> +#else >>>> >> + return true; >>>> >> +#endif >>>> >> +} >>>> >> + >>>> >> #endif >>>> > >>>> > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] drm: add helper to check for wc memory support 2016-02-03 13:53 ` Alex Deucher @ 2016-02-03 14:00 ` Oded Gabbay 0 siblings, 0 replies; 12+ messages in thread From: Oded Gabbay @ 2016-02-03 14:00 UTC (permalink / raw) To: Alex Deucher; +Cc: Dave Airlie, Daenzer, Michel, Maling list - DRI developers On Wed, Feb 3, 2016 at 3:53 PM, Alex Deucher <alexdeucher@gmail.com> wrote: > On Wed, Feb 3, 2016 at 3:17 AM, Oded Gabbay <oded.gabbay@gmail.com> wrote: >> On Tue, Feb 2, 2016 at 5:07 PM, Alex Deucher <alexdeucher@gmail.com> wrote: >>> On Tue, Feb 2, 2016 at 7:01 AM, Oded Gabbay <oded.gabbay@gmail.com> wrote: >>>> On Mon, Feb 1, 2016 at 7:01 PM, Alex Deucher <alexdeucher@gmail.com> wrote: >>>>> >>>>> On Sat, Jan 30, 2016 at 4:57 AM, Christian König >>>>> <deathsimple@vodafone.de> wrote: >>>>> > Am 30.01.2016 um 06:59 schrieb Oded Gabbay: >>>>> >> >>>>> >> From: Dave Airlie <airlied@redhat.com> >>>>> >> >>>>> >> Signed-off-by: Dave Airlie <airlied@redhat.com> >>>>> >> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> >>>>> > >>>>> > >>>>> > With the minor issues Michel noted fixed this series is Reviewed-by: >>>>> > Christian König <christian.koenig@amd.com> as well. >>>>> >>>>> Applied with the comments fixed up. Thanks! >>>>> >>>>> Alex >>>>> >>>> >>>> Hi Alex, >>>> Could you please add stable tag ? I forgot to add them. >>> >>> Will do. >>> >>> Alex >> >> Thanks. >> >> Alex, >> I saw you put the patches into your drm-next-4.6. >> As these are fixes, any chance you could instead put them to >> drm-fixes-4.5 ? for -rc3/4 ? > > They'll be in my -fixes pull this week. I put them in my 4.6-wip tree > for additional testing. > > Alex > ah, great. Thanks again Oded >> >> Oded >> >>> >>>> Thanks, >>>> >>>> Oded >>>> >>>> >>>>> >>>>> > >>>>> > >>>>> >> --- >>>>> >> include/drm/drm_cache.h | 9 +++++++++ >>>>> >> 1 file changed, 9 insertions(+) >>>>> >> >>>>> >> diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h >>>>> >> index 7bfb063..461a055 100644 >>>>> >> --- a/include/drm/drm_cache.h >>>>> >> +++ b/include/drm/drm_cache.h >>>>> >> @@ -35,4 +35,13 @@ >>>>> >> void drm_clflush_pages(struct page *pages[], unsigned long num_pages); >>>>> >> +static inline bool drm_arch_can_wc_memory(void) >>>>> >> +{ >>>>> >> +#if defined(CONFIG_PPC) && !defined(CONFIG_NOT_COHERENT_CACHE) >>>>> >> + return false; >>>>> >> +#else >>>>> >> + return true; >>>>> >> +#endif >>>>> >> +} >>>>> >> + >>>>> >> #endif >>>>> > >>>>> > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-02-03 14:00 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-01-30 5:59 [PATCH 1/3] drm: add helper to check for wc memory support Oded Gabbay 2016-01-30 5:59 ` [PATCH 2/3] drm/radeon: mask out WC from BO on unsupported arches Oded Gabbay 2016-01-30 8:11 ` Michel Dänzer 2016-01-30 10:58 ` Oded Gabbay 2016-01-30 5:59 ` [PATCH 3/3] drm/amdgpu: " Oded Gabbay 2016-01-30 9:57 ` [PATCH 1/3] drm: add helper to check for wc memory support Christian König 2016-02-01 17:01 ` Alex Deucher 2016-02-02 12:01 ` Oded Gabbay 2016-02-02 15:07 ` Alex Deucher 2016-02-03 8:17 ` Oded Gabbay 2016-02-03 13:53 ` Alex Deucher 2016-02-03 14:00 ` Oded Gabbay
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.