All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andreas Dannenberg <dannenberg@ti.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Cc: Alexander Koch <mail@alexanderkoch.net>,
	knaack.h@gmx.de, lars@metafoo.de,
	"pmeerw@pmeerw.net >> Peter Meerwald" <pmeerw@pmeerw.net>,
	mhornung.linux@gmail.com, fengguang.wu@intel.com
Subject: Re: [PATCH] iio: light: opt3001: Add device tree binding documentation
Date: Sat, 30 Jan 2016 16:30:23 +0000	[thread overview]
Message-ID: <56ACE51F.6000906@kernel.org> (raw)
In-Reply-To: <1454094180-2688-1-git-send-email-dannenberg@ti.com>

On 29/01/16 19:03, Andreas Dannenberg wrote:
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
Looks straight forward enough I'm happy to take this in a few
weeks with out a devicetree ack.  (though one is as ever welcome!)

In case anyone was wondering, this is retro-documentation - all that has
changed recently is the addition of support for running without an interrupt
line.

Jonathan
> ---
>  .../devicetree/bindings/iio/light/opt3001.txt      | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/opt3001.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/opt3001.txt b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> new file mode 100644
> index 0000000..55b9cb3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> @@ -0,0 +1,26 @@
> +* Texas Instruments OPT3001 Ambient Light Sensor
> +
> +The driver supports interrupt-driven and interrupt-less operation, depending
> +on whether an interrupt property has been populated into the DT. Note that
> +the optional generation of IIO events on rising/falling light threshold changes
> +requires the use of interrupts. Without interrupts, only the simple reading
> +of the current light value is supported through the IIO API.
> +
> +http://www.ti.com/product/opt3001
> +
> +Required properties:
> +  - compatible: should be "ti,opt3001"
> +  - reg: the I2C address of the sensor
> +  
> +Optional properties:
> +  - interrupt-parent: should be the phandle for the interrupt controller
> +  - interrupts: interrupt mapping for GPIO IRQ (configure for falling edge)
> +
> +Example:
> +
> +opt3001@44 {
> +	compatible = "ti,opt3001";
> +	reg = <0x44>;
> +	interrupt-parent = <&gpio1>;
> +	interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
> +};
> 


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Andreas Dannenberg <dannenberg-l0cyMroinI0@public.gmane.org>,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Alexander Koch
	<mail-y2PnNNZjvYd4VEKF+Mn3m16hYfS7NtTn@public.gmane.org>,
	knaack.h-Mmb7MZpHnFY@public.gmane.org,
	lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
	"pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org >> Peter
	Meerwald" <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
	mhornung.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] iio: light: opt3001: Add device tree binding documentation
Date: Sat, 30 Jan 2016 16:30:23 +0000	[thread overview]
Message-ID: <56ACE51F.6000906@kernel.org> (raw)
In-Reply-To: <1454094180-2688-1-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>

On 29/01/16 19:03, Andreas Dannenberg wrote:
> Signed-off-by: Andreas Dannenberg <dannenberg-l0cyMroinI0@public.gmane.org>
Looks straight forward enough I'm happy to take this in a few
weeks with out a devicetree ack.  (though one is as ever welcome!)

In case anyone was wondering, this is retro-documentation - all that has
changed recently is the addition of support for running without an interrupt
line.

Jonathan
> ---
>  .../devicetree/bindings/iio/light/opt3001.txt      | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/opt3001.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/opt3001.txt b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> new file mode 100644
> index 0000000..55b9cb3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/opt3001.txt
> @@ -0,0 +1,26 @@
> +* Texas Instruments OPT3001 Ambient Light Sensor
> +
> +The driver supports interrupt-driven and interrupt-less operation, depending
> +on whether an interrupt property has been populated into the DT. Note that
> +the optional generation of IIO events on rising/falling light threshold changes
> +requires the use of interrupts. Without interrupts, only the simple reading
> +of the current light value is supported through the IIO API.
> +
> +http://www.ti.com/product/opt3001
> +
> +Required properties:
> +  - compatible: should be "ti,opt3001"
> +  - reg: the I2C address of the sensor
> +  
> +Optional properties:
> +  - interrupt-parent: should be the phandle for the interrupt controller
> +  - interrupts: interrupt mapping for GPIO IRQ (configure for falling edge)
> +
> +Example:
> +
> +opt3001@44 {
> +	compatible = "ti,opt3001";
> +	reg = <0x44>;
> +	interrupt-parent = <&gpio1>;
> +	interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
> +};
> 

  reply	other threads:[~2016-01-30 16:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 19:03 [PATCH] iio: light: opt3001: Add device tree binding documentation Andreas Dannenberg
2016-01-29 19:03 ` Andreas Dannenberg
2016-01-30 16:30 ` Jonathan Cameron [this message]
2016-01-30 16:30   ` Jonathan Cameron
2016-02-01 15:18 ` Rob Herring
2016-02-01 15:18   ` Rob Herring
2016-02-01 19:56   ` Jonathan Cameron
2016-02-01 19:56     ` Jonathan Cameron
2016-02-01 20:01   ` Andreas Dannenberg
2016-02-01 20:01     ` Andreas Dannenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56ACE51F.6000906@kernel.org \
    --to=jic23@kernel.org \
    --cc=dannenberg@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=mail@alexanderkoch.net \
    --cc=mhornung.linux@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.