All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: "Serguei Bezverkhi (sbezverk)" <sbezverk@cisco.com>,
	"bugzilla-daemon@bugzilla.kernel.org"
	<bugzilla-daemon@bugzilla.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [Bug 111441] New: iscsi fails to attach to targets
Date: Mon, 01 Feb 2016 10:55:08 -0600	[thread overview]
Message-ID: <56AF8DEC.5000002@cs.wisc.edu> (raw)
In-Reply-To: <1454139533.12686.3.camel@haakon3.risingtidesystems.com>

On 01/30/2016 01:38 AM, Nicholas A. Bellinger wrote:
> On Fri, 2016-01-29 at 17:32 -0600, Mike Christie wrote:
>> On 01/29/2016 04:21 PM, Serguei Bezverkhi (sbezverk) wrote:
>>> HI Mike,
>>>
>>> I tried your patch and it is has eliminated first traceback but I still do not see my remote targets.
>>>
>>
>> That is sort of expected. Your target is not setup for ALUA properly. It
>> says it supports ALUA, but when scsi_dh_alua asks about the ports it is
>> reporting there are none. Ccing the people that made the patch that
>> added the issue and own the code.
>>
>> Hey Christoph and Hannes,
>>
>> The dh/alua changes that added this:
>>
>>         error = scsi_dh_add_device(sdev);
>>         if (error) {
>>                 sdev_printk(KERN_INFO, sdev,
>>                                 "failed to add device handler: %d\n",
>> error);
>>                 return error;
>>         }
>>
>> to scsi_sysfs_add_sdev are adding a regression.
>>
>> 1. If that fails, then we forget to do device_del before doing the
>> return. My patch in this thread added that back, so we do not see the
>> sysfs oopses anymore. But.....
>>
>> 2. It looks like in older kernels, we would allow misconfigured targets
>> like this one to still setup devices. Do we want that old behavior back?
>> Should we just ignore the return value from scsi_dh_add_device above?
>> Note that in this case, it is LIO so it can be easily fixed on the
>> target side by just setting it up properly. I do not think other targets
>> would hit this type of issue.
>>
> 
> Btw, what does misconfigured mean here wrt target ALUA..?

[   25.833195] sd 6:0:0:4: alua: supports implicit and explicit TPGS
[   25.833360] sd 6:0:0:4: alua: No target port descriptors found
[   25.833363] sd 6:0:0:4: alua: Attach failed (-22)
[   25.833365] sd 6:0:0:4: failed to add device handler: -22

He has LIO configured to report it supports implicit/explicit ALUA, but
the ports do not seem to be configured.

For the LIO config side, are his LUNs just not in a the default_lu_gp or
any other group?

  reply	other threads:[~2016-02-01 16:55 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 22:51 [Bug 111441] New: iscsi fails to attach to targets bugzilla-daemon
2016-01-29  1:53 ` Mike Christie
2016-01-29  2:13   ` Mike Christie
2016-01-29  2:55   ` Serguei Bezverkhi (sbezverk)
2016-01-29  8:01     ` Michael Christie
2016-01-29  8:25       ` Mike Christie
2016-01-29 12:04       ` Serguei Bezverkhi (sbezverk)
2016-01-29 19:08         ` Michael Christie
2016-01-29 19:11           ` Serguei Bezverkhi (sbezverk)
2016-01-29 19:26             ` Mike Christie
2016-01-29 22:21               ` Serguei Bezverkhi (sbezverk)
2016-01-29 23:32                 ` Mike Christie
2016-01-30  7:38                   ` Nicholas A. Bellinger
2016-02-01 16:55                     ` Mike Christie [this message]
2016-02-02 16:41                       ` Serguei Bezverkhi (sbezverk)
2016-02-02 22:56                       ` Nicholas A. Bellinger
2016-02-02 23:21                         ` Serguei Bezverkhi (sbezverk)
2016-02-08  8:01                         ` Nicholas A. Bellinger
2016-02-16 19:08                           ` Hannes Reinecke
2016-02-27 22:15                             ` Nicholas A. Bellinger
2016-02-02 18:09                   ` Christoph Hellwig
2016-02-02 20:12                     ` Mike Christie
2016-02-02 20:25                       ` Serguei Bezverkhi (sbezverk)
2016-02-02 21:54                       ` Serguei Bezverkhi (sbezverk)
2016-02-22  0:45                   ` Serguei Bezverkhi (sbezverk)
2016-02-22  7:08                     ` Hannes Reinecke
2016-02-22 11:36                       ` Serguei Bezverkhi (sbezverk)
2016-01-29  3:00 ` [Bug 111441] " bugzilla-daemon
2016-01-29  3:05 ` bugzilla-daemon
2016-01-29  3:32 ` bugzilla-daemon
2016-01-29  3:40 ` bugzilla-daemon
2016-01-29 12:04 ` bugzilla-daemon
2016-01-29 19:11 ` bugzilla-daemon
2016-01-29 22:21 ` bugzilla-daemon
2016-01-30  7:46 ` bugzilla-daemon
2016-02-01  2:13 ` bugzilla-daemon
2016-02-02 16:41 ` bugzilla-daemon
2016-02-02 20:25 ` bugzilla-daemon
2016-02-02 22:03 ` bugzilla-daemon
2016-02-02 22:56 ` bugzilla-daemon
2016-02-02 23:21 ` bugzilla-daemon
2016-02-08  8:01 ` bugzilla-daemon
2016-02-22  0:45 ` bugzilla-daemon
2016-02-22  7:08 ` bugzilla-daemon
2016-02-22 11:36 ` bugzilla-daemon
2016-02-27 22:15 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AF8DEC.5000002@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=sbezverk@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.