From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, "open list:sPAPR" <qemu-ppc@nongnu.org>,
marcandre.lureau@redhat.com,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct
Date: Mon, 1 Feb 2016 10:22:37 -0700 [thread overview]
Message-ID: <56AF945D.8070805@redhat.com> (raw)
In-Reply-To: <87oac060k9.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On 02/01/2016 06:07 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
>> No backend was setting an error when ending an implicit struct,
>> or when iterating a list.
>
> Perhaps "when ending the visit of a list or implicit struct, or when
> moving to the next list node" would be more precise. If you like it, I
> can do that on commit.
Yes, that sounds better.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-01 17:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 13:48 [Qemu-devel] [PATCH v10 00/25] qapi visitor cleanups part 1 (post-introspection cleanups subset E) Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 01/25] qobject: Document more shortcomings in our number handling Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 02/25] qapi: Avoid use of misnamed DO_UPCAST() Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 03/25] qapi: Drop dead dealloc visitor variable Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 04/25] qapi: Dealloc visitor does not need a type_size() Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 05/25] qapi: Drop dead parameter in gen_params() Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 06/25] hmp: Drop pointless allocation during qapi visit Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 07/25] hmp: Cache use of qapi visitor Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 08/25] vl: Ensure qapi visitor properly ends struct visit Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 09/25] balloon: Improve use of qapi visitor Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event " Eric Blake
2016-02-01 12:31 ` Markus Armbruster
2016-02-01 22:50 ` Eric Blake
2016-02-02 7:52 ` Markus Armbruster
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 11/25] qapi: Track all failures between visit_start/stop Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 12/25] qapi-visit: Kill unused visit_end_union() Eric Blake
2016-02-01 12:38 ` Markus Armbruster
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 13/25] qapi: Prefer type_int64 over type_int in visitors Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 14/25] qapi: Make all visitors supply uint64 callbacks Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 15/25] qapi: Consolidate visitor small integer callbacks Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 16/25] qapi: Don't cast Enum* to int* Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 17/25] qom: Use typedef for Visitor Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 18/25] qapi: Swap visit_* arguments for consistent 'name' placement Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 19/25] qom: Swap 'name' next to visitor in ObjectPropertyAccessor Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 20/25] qapi: Swap 'name' in visit_* callbacks to match public API Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 21/25] qapi: Drop unused 'kind' for struct/enum visit Eric Blake
2016-02-01 12:56 ` Markus Armbruster
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 22/25] qapi: Tighten qmp_input_end_list() Eric Blake
2016-01-29 13:48 ` [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct Eric Blake
2016-02-01 13:07 ` Markus Armbruster
2016-02-01 17:22 ` Eric Blake [this message]
2016-02-01 23:14 ` Eric Blake
2016-02-02 9:00 ` Markus Armbruster
2016-01-29 13:49 ` [Qemu-devel] [PATCH v10 24/25] qmp: Fix reference-counting of qnull on empty output visit Eric Blake
2016-01-29 13:49 ` [Qemu-devel] [PATCH v10 25/25] qmp: Don't abuse stack to track qmp-output root Eric Blake
2016-02-01 13:25 ` [Qemu-devel] [PATCH v10 00/25] qapi visitor cleanups part 1 (post-introspection cleanups subset E) Markus Armbruster
2016-02-02 9:55 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF945D.8070805@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.