Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On 02/01/2016 05:31 AM, Markus Armbruster wrote:

>> |+    visit_start_struct(v, NULL, NULL, "ACPI_DEVICE_OST", 0, &err);
>> |     if (err) {
>> |         goto out;
>> |     }
>> |     visit_type_ACPIOSTInfo(v, &info, "info", &err);
>> |     if (err) {
>> |-        goto out;
>> |+        goto out_obj;
>> |     }
>> |-    visit_end_struct(v, &err);
>> |+out_obj:
>> |+    visit_end_struct(v, err ? NULL : &err);
> 
> Slightly awkward example, because out_obj is pointless in this
> degenerated case.  You could pick one with multiple members (thus
> multiple goto out_obj), or do pseudo-code hinting at multiple members.

DEVICE_DELETED, DEVICE_TRAY_MOVED, MEM_UNPLUG_ERROR,
NET_RX_FILTER_CHANGED, and SPICE_CONNECTED are nice candidates (two
members instead of one).  Do you want to take care of redoing any
portion of the commit message?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]