From: Brijesh Singh <brijesh.singh@amd.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: brijesh.singh@amd.com, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, hdegoede@redhat.com,
linux-ide@vger.kernel.org, Graeme Gregory <graeme@xora.org.uk>
Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver
Date: Mon, 1 Feb 2016 16:15:59 -0600 [thread overview]
Message-ID: <56AFD91F.4030008@amd.com> (raw)
In-Reply-To: <5709817.yQT8N3CaLj@wuerfel>
Hi,
>
> This is where we really need the ACPI maintainers to explain the
> general policy for dealing with firmware updates.
>
> I would assume that adding the feature in a later firmware version
> is a compatible change, and the feature is non-essential (the
> device will work fine with the generic SATA driver, except
> the LEDs don't blink), so it's not a big deal, it's just what
> you get for having the firmware shipped before the driver is
> reviewed (don't do that).
>
Agreed, the driver should have been reviewed earlier. And now changes in firmware will also require
them changing other OSes drivers.
Just speaking my mind, maybe server folks will be fine without activity LED but I think "locate" and "fault" LEDs is needed.
-Brijesh
> Arnd
>
WARNING: multiple messages have this Message-ID (diff)
From: Brijesh Singh <brijesh.singh@amd.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <brijesh.singh@amd.com>, Tejun Heo <tj@kernel.org>,
<linux-kernel@vger.kernel.org>, <hdegoede@redhat.com>,
<linux-ide@vger.kernel.org>, Graeme Gregory <graeme@xora.org.uk>
Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver
Date: Mon, 1 Feb 2016 16:15:59 -0600 [thread overview]
Message-ID: <56AFD91F.4030008@amd.com> (raw)
In-Reply-To: <5709817.yQT8N3CaLj@wuerfel>
Hi,
>
> This is where we really need the ACPI maintainers to explain the
> general policy for dealing with firmware updates.
>
> I would assume that adding the feature in a later firmware version
> is a compatible change, and the feature is non-essential (the
> device will work fine with the generic SATA driver, except
> the LEDs don't blink), so it's not a big deal, it's just what
> you get for having the firmware shipped before the driver is
> reviewed (don't do that).
>
Agreed, the driver should have been reviewed earlier. And now changes in firmware will also require
them changing other OSes drivers.
Just speaking my mind, maybe server folks will be fine without activity LED but I think "locate" and "fault" LEDs is needed.
-Brijesh
> Arnd
>
next prev parent reply other threads:[~2016-02-01 22:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 16:31 [PATCH v2] ata: add AMD Seattle platform driver Brijesh Singh
2016-01-14 16:31 ` Brijesh Singh
2016-01-20 21:24 ` Brijesh Singh
2016-01-20 21:24 ` Brijesh Singh
2016-01-25 20:43 ` Tejun Heo
2016-01-26 9:36 ` Hans de Goede
2016-03-16 20:12 ` Brijesh Singh
2016-03-16 20:12 ` Brijesh Singh
2016-01-26 12:17 ` Arnd Bergmann
2016-01-26 16:56 ` Brijesh Singh
2016-01-26 16:56 ` Brijesh Singh
2016-01-29 21:22 ` Arnd Bergmann
2016-01-29 21:31 ` One Thousand Gnomes
2016-02-01 18:56 ` Brijesh Singh
2016-02-01 18:56 ` Brijesh Singh
2016-02-01 20:14 ` Arnd Bergmann
2016-02-01 22:15 ` Brijesh Singh [this message]
2016-02-01 22:15 ` Brijesh Singh
2016-02-02 14:08 ` Arnd Bergmann
2016-02-02 18:37 ` Brijesh Singh
2016-02-02 18:37 ` Brijesh Singh
2016-02-05 14:50 ` Arnd Bergmann
2016-02-05 17:23 ` Brijesh Singh
2016-02-05 17:23 ` Brijesh Singh
2016-02-08 18:12 ` Brijesh Singh
2016-02-08 18:12 ` Brijesh Singh
2016-03-16 21:07 ` Tejun Heo
2016-03-17 17:36 ` Arnd Bergmann
2016-03-18 18:36 ` Brijesh Singh
2016-03-18 18:36 ` Brijesh Singh
2016-03-18 20:19 ` Tejun Heo
2016-04-14 9:08 ` Matthias Brugger
2016-04-14 22:14 ` Brijesh Singh
2016-04-14 22:14 ` Brijesh Singh
2016-04-13 19:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AFD91F.4030008@amd.com \
--to=brijesh.singh@amd.com \
--cc=arnd@arndb.de \
--cc=graeme@xora.org.uk \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.