All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Ding <ryan.ding@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: fix build warning
Date: Tue, 02 Feb 2016 16:01:22 +0800	[thread overview]
Message-ID: <56B06252.5080504@oracle.com> (raw)
In-Reply-To: <1454395613-3428-1-git-send-email-sudipm.mukherjee@gmail.com>


On 02/02/2016 02:46 PM, Sudip Mukherjee wrote:
> We were getting build warning about:
> /fs/ocfs2/file.c: In function ?ocfs2_file_write_iter?:
> fs/ocfs2/file.c:2198:1: warning: label ?relock? defined but not used
>
> The previous commit has cleaned up the code for direct io and removed
> the jump instruction to relock, but missed removing the label which is
> unused now.
>
> Fixes: 1a46f12e5071 ("ocfs2: code clean up for direct io")
> Cc: Ryan Ding <ryan.ding@oracle.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Reviewed-by: Ryan Ding<ryan.ding@oracle.com>

> ---
>   fs/ocfs2/file.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 41c506e..c18ab45 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -2195,7 +2195,6 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb,
>   
>   	inode_lock(inode);
>   
> -relock:
>   	/*
>   	 * Concurrent O_DIRECT writes are allowed with
>   	 * mount_option "coherency=buffered".

WARNING: multiple messages have this Message-ID (diff)
From: Ryan Ding <ryan.ding@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH] ocfs2: fix build warning
Date: Tue, 02 Feb 2016 16:01:22 +0800	[thread overview]
Message-ID: <56B06252.5080504@oracle.com> (raw)
In-Reply-To: <1454395613-3428-1-git-send-email-sudipm.mukherjee@gmail.com>


On 02/02/2016 02:46 PM, Sudip Mukherjee wrote:
> We were getting build warning about:
> /fs/ocfs2/file.c: In function ‘ocfs2_file_write_iter’:
> fs/ocfs2/file.c:2198:1: warning: label ‘relock’ defined but not used
>
> The previous commit has cleaned up the code for direct io and removed
> the jump instruction to relock, but missed removing the label which is
> unused now.
>
> Fixes: 1a46f12e5071 ("ocfs2: code clean up for direct io")
> Cc: Ryan Ding <ryan.ding@oracle.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Reviewed-by: Ryan Ding<ryan.ding@oracle.com>

> ---
>   fs/ocfs2/file.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 41c506e..c18ab45 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -2195,7 +2195,6 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb,
>   
>   	inode_lock(inode);
>   
> -relock:
>   	/*
>   	 * Concurrent O_DIRECT writes are allowed with
>   	 * mount_option "coherency=buffered".

  reply	other threads:[~2016-02-02  8:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02  6:46 [Ocfs2-devel] [PATCH] ocfs2: fix build warning Sudip Mukherjee
2016-02-02  6:46 ` Sudip Mukherjee
2016-02-02  8:01 ` Ryan Ding [this message]
2016-02-02  8:01   ` Ryan Ding
2016-02-13 22:45 ` [Ocfs2-devel] " kbuild test robot
2016-02-13 22:45   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B06252.5080504@oracle.com \
    --to=ryan.ding@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.