All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Wei Tang <tangwei@cmss.chinamobile.com>,
	akpm@linux-foundation.org, oleg@redhat.com
Cc: amanieu@gmail.com, dave@stgolabs.net, vdavydov@parallels.com,
	palmer@dabbelt.com, linux-kernel@vger.kernel.org
Subject: Re: 答复: [PATCH] signal: use sizeof() instead of sizeof
Date: Tue, 2 Feb 2016 09:14:43 +0100	[thread overview]
Message-ID: <56B06573.8090107@nod.at> (raw)
In-Reply-To: <000001d15d90$f3c40a40$db4c1ec0$@cmss.chinamobile.com>

Am 02.02.2016 um 09:08 schrieb Wei Tang:
> This is a simple patch, just to clear up the output from checkpatch.pl
> script, otherwise, we will get WARNING always.

This does not answer my question.
What problem does it fix? How does your patch make the kernel better?

Doing patches just because of checkpatch warnings (not errors)
is IMHO not good.
It is a script and not human, it does not understand all the corner cases.
All it can do is giving us hints. But this does not mean that you have to
blindly follow them.

Thanks,
//richard

      parent reply	other threads:[~2016-02-02  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02  7:35 [PATCH] signal: use sizeof() instead of sizeof Wei Tang
2016-02-02  7:55 ` Richard Weinberger
     [not found]   ` <000001d15d90$f3c40a40$db4c1ec0$@cmss.chinamobile.com>
2016-02-02  8:14     ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B06573.8090107@nod.at \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=amanieu@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=tangwei@cmss.chinamobile.com \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.