From: Daniel Mack <daniel@zonque.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sylvain Rochet <sylvain.rochet@finsecur.com>,
Johan Hovold <johan@kernel.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
devicetree@vger.kernel.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Input: rotary-encoder - make use of devm_* to simplify .probe and .remove
Date: Tue, 2 Feb 2016 14:15:28 +0100 [thread overview]
Message-ID: <56B0ABF0.8010904@zonque.org> (raw)
In-Reply-To: <20160202130022.GX13664@pengutronix.de>
On 02/02/2016 02:00 PM, Uwe Kleine-König wrote:
> On Tue, Feb 02, 2016 at 12:56:24PM +0100, Daniel Mack wrote:
>> On 02/02/2016 11:24 AM, Uwe Kleine-König wrote:
>>> For all operations called in .probe there are devm_* variants.
>>> (input_register_device is clever enough to be devm aware on its own.)
>>> This allows to get rid of the error unwind code paths in .probe and the
>>> complete .remove function.
>>
>> While at it, could you also convert this over to the gpiod_* API?
>
> This is done in patch 3.
Ah, right. Missed that detail, sorry.
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: daniel@zonque.org (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] Input: rotary-encoder - make use of devm_* to simplify .probe and .remove
Date: Tue, 2 Feb 2016 14:15:28 +0100 [thread overview]
Message-ID: <56B0ABF0.8010904@zonque.org> (raw)
In-Reply-To: <20160202130022.GX13664@pengutronix.de>
On 02/02/2016 02:00 PM, Uwe Kleine-K?nig wrote:
> On Tue, Feb 02, 2016 at 12:56:24PM +0100, Daniel Mack wrote:
>> On 02/02/2016 11:24 AM, Uwe Kleine-K?nig wrote:
>>> For all operations called in .probe there are devm_* variants.
>>> (input_register_device is clever enough to be devm aware on its own.)
>>> This allows to get rid of the error unwind code paths in .probe and the
>>> complete .remove function.
>>
>> While at it, could you also convert this over to the gpiod_* API?
>
> This is done in patch 3.
Ah, right. Missed that detail, sorry.
Daniel
next prev parent reply other threads:[~2016-02-02 13:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 10:24 [PATCH v2 0/3] Input: rotary-encoder - use more than two gpios Uwe Kleine-König
2016-02-02 10:24 ` Uwe Kleine-König
2016-02-02 10:24 ` [PATCH v2 1/3] Input: rotary-encoder - make use of devm_* to simplify .probe and .remove Uwe Kleine-König
2016-02-02 10:24 ` Uwe Kleine-König
2016-02-02 11:56 ` Daniel Mack
2016-02-02 11:56 ` Daniel Mack
2016-02-02 13:00 ` Uwe Kleine-König
2016-02-02 13:00 ` Uwe Kleine-König
2016-02-02 13:15 ` Daniel Mack [this message]
2016-02-02 13:15 ` Daniel Mack
[not found] ` <1454408678-6011-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-02-02 10:24 ` [PATCH v2 2/3] Input: rotary-encoder - move configuration data to driver data Uwe Kleine-König
2016-02-02 10:24 ` Uwe Kleine-König
2016-02-02 12:10 ` Daniel Mack
2016-02-02 12:10 ` Daniel Mack
[not found] ` <56B09CAB.5020600-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>
2016-02-03 9:35 ` Uwe Kleine-König
2016-02-03 9:35 ` Uwe Kleine-König
2016-02-04 21:18 ` Dmitry Torokhov
2016-02-04 21:18 ` Dmitry Torokhov
2016-02-05 9:05 ` Uwe Kleine-König
2016-02-05 9:05 ` Uwe Kleine-König
2016-02-02 10:24 ` [PATCH v2 3/3] Input: rotary-encoder - support more than 2 gpios as input Uwe Kleine-König
2016-02-02 10:24 ` Uwe Kleine-König
2016-02-02 12:08 ` [PATCH v2 0/3] Input: rotary-encoder - use more than two gpios Daniel Mack
2016-02-02 12:08 ` Daniel Mack
2016-02-02 12:56 ` Uwe Kleine-König
2016-02-02 12:56 ` Uwe Kleine-König
2016-02-02 13:14 ` Daniel Mack
2016-02-02 13:14 ` Daniel Mack
[not found] ` <56B0ABC9.10107-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>
2016-02-02 13:27 ` Uwe Kleine-König
2016-02-02 13:27 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B0ABF0.8010904@zonque.org \
--to=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=haojian.zhuang@gmail.com \
--cc=johan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=sylvain.rochet@finsecur.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.