All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Safonov <dsafonov@virtuozzo.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, akpm@linux-foundation.org, cl@linux.com,
	penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Vladimir Davydov <vdavydov@virtuozzo.com>
Subject: Re: [PATCH] mm/slab: fix race with dereferencing NULL ptr in alloc_calls_show
Date: Tue, 2 Feb 2016 18:55:39 +0300	[thread overview]
Message-ID: <56B0D17B.4050703@virtuozzo.com> (raw)
In-Reply-To: <201602022324.wVKj7DGl%fengguang.wu@intel.com>

On 02/02/2016 06:19 PM, kbuild test robot wrote:
> Hi Dmitry,
>
> [auto build test ERROR on v4.5-rc2]
> [also build test ERROR on next-20160201]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url:    https://github.com/0day-ci/linux/commits/Dmitry-Safonov/mm-slab-fix-race-with-dereferencing-NULL-ptr-in-alloc_calls_show/20160202-230449
> config: i386-randconfig-x005-02010231 (attached as .config)
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=i386
Thanks little robot, will resend fixed v2 right soon.
>
> All errors (new ones prefixed by >>):
>
>     mm/slab_common.c: In function 'memcg_destroy_kmem_caches':
>>> mm/slab_common.c:613:3: error: implicit declaration of function 'sysfs_slab_remove' [-Werror=implicit-function-declaration]
>        sysfs_slab_remove(s);
>        ^
>     cc1: some warnings being treated as errors
>
> vim +/sysfs_slab_remove +613 mm/slab_common.c
>
>     607	
>     608		mutex_lock(&slab_mutex);
>     609		list_for_each_entry_safe(s, s2, &slab_caches, list) {
>     610			if (is_root_cache(s) || s->memcg_params.memcg != memcg)
>     611				continue;
>     612	
>   > 613			sysfs_slab_remove(s);
>     614	
>     615			/*
>     616			 * The cgroup is about to be freed and therefore has no charges
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


-- 
Regards,
Dmitry Safonov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Safonov <dsafonov@virtuozzo.com>
To: kbuild test robot <lkp@intel.com>
Cc: <kbuild-all@01.org>, <akpm@linux-foundation.org>, <cl@linux.com>,
	<penberg@kernel.org>, <rientjes@google.com>,
	<iamjoonsoo.kim@lge.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>,
	Vladimir Davydov <vdavydov@virtuozzo.com>
Subject: Re: [PATCH] mm/slab: fix race with dereferencing NULL ptr in alloc_calls_show
Date: Tue, 2 Feb 2016 18:55:39 +0300	[thread overview]
Message-ID: <56B0D17B.4050703@virtuozzo.com> (raw)
In-Reply-To: <201602022324.wVKj7DGl%fengguang.wu@intel.com>

On 02/02/2016 06:19 PM, kbuild test robot wrote:
> Hi Dmitry,
>
> [auto build test ERROR on v4.5-rc2]
> [also build test ERROR on next-20160201]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url:    https://github.com/0day-ci/linux/commits/Dmitry-Safonov/mm-slab-fix-race-with-dereferencing-NULL-ptr-in-alloc_calls_show/20160202-230449
> config: i386-randconfig-x005-02010231 (attached as .config)
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=i386
Thanks little robot, will resend fixed v2 right soon.
>
> All errors (new ones prefixed by >>):
>
>     mm/slab_common.c: In function 'memcg_destroy_kmem_caches':
>>> mm/slab_common.c:613:3: error: implicit declaration of function 'sysfs_slab_remove' [-Werror=implicit-function-declaration]
>        sysfs_slab_remove(s);
>        ^
>     cc1: some warnings being treated as errors
>
> vim +/sysfs_slab_remove +613 mm/slab_common.c
>
>     607	
>     608		mutex_lock(&slab_mutex);
>     609		list_for_each_entry_safe(s, s2, &slab_caches, list) {
>     610			if (is_root_cache(s) || s->memcg_params.memcg != memcg)
>     611				continue;
>     612	
>   > 613			sysfs_slab_remove(s);
>     614	
>     615			/*
>     616			 * The cgroup is about to be freed and therefore has no charges
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


-- 
Regards,
Dmitry Safonov

  reply	other threads:[~2016-02-02 15:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 15:01 [PATCH] mm/slab: fix race with dereferencing NULL ptr in alloc_calls_show Dmitry Safonov
2016-02-02 15:01 ` Dmitry Safonov
2016-02-02 15:19 ` kbuild test robot
2016-02-02 15:19   ` kbuild test robot
2016-02-02 15:55   ` Dmitry Safonov [this message]
2016-02-02 15:55     ` Dmitry Safonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B0D17B.4050703@virtuozzo.com \
    --to=dsafonov@virtuozzo.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vdavydov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.