From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joshua Henderson <joshua.henderson@microchip.com>,
linux-kernel@vger.kernel.org
Cc: Cristian Birsan <cristian.birsan@microchip.com>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine
Date: Tue, 2 Feb 2016 19:51:32 +0300 [thread overview]
Message-ID: <56B0DE94.9020804@cogentembedded.com> (raw)
In-Reply-To: <56B0DAFD.50103@microchip.com>
On 02/02/2016 07:36 PM, Joshua Henderson wrote:
>>> From: Cristian Birsan <cristian.birsan@microchip.com>
>>>
>>> Commit 6b6e97107f12f3a9f7 (USB: musb: fix isochronous TXDMA (take 2)) introduces
>>
>> Again, wrong commit style.
Commit citing style, I meant.
>> And I really doubt that blaming my commit was correct. :-)
>
> I apologize. I noticed you added the line in question, but did not notice the variable type of "mode" changed *afterward*.
So I thought. :-)
> Completely my fault. I shall also fix the commit message style.
TIA.
[...]
> Thanks,
> Josh
MBR, Sergei
next prev parent reply other threads:[~2016-02-02 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 0:37 [PATCH 1/2] usb: musb: Fix DMA for host mode Joshua Henderson
2016-02-02 0:37 ` [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Joshua Henderson
2016-02-02 13:32 ` Sergei Shtylyov
2016-02-02 16:36 ` Joshua Henderson
2016-02-02 16:51 ` Sergei Shtylyov [this message]
2016-02-02 13:24 ` [PATCH 1/2] usb: musb: Fix DMA for host mode Sergei Shtylyov
2016-02-04 16:44 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B0DE94.9020804@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=cristian.birsan@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=joshua.henderson@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.