Re: [Qemu-devel] [PATCH v2 0/2] Active commit regression fix

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

On 02.02.2016 02:33, Jeff Cody wrote:
> Changes from v1:
> 
> * Rather than allow insertion when bs->device_listtqe_prev points to
>   a NULL entry, make sure than we follow the block scheme of enforcing
>   bs->device_list->tqe_prev is NULL upon deletion. (Thanks Max!)
> 
> Bug #1300209 is a regression in 2.5, introduced during the 
> change away from bdrv_swap().
> 
> When we change the parent backing link (change_parent_backing_link),
> we must also accomodate non-NULL tqe_prev pointers that point to a
> NULL entry.  Please see patch #1 for more details.
> 
> Jeff Cody (2):
>   block: set device_list.tqe_prev to NULL on BDS removal
>   block: qemu-iotests - add test for snapshot, commit, snapshot bug
> 
>  block.c                    |  24 ++++++----
>  blockdev.c                 |   3 +-
>  include/block/block.h      |   1 +
>  tests/qemu-iotests/143     | 114 +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/143.out |  24 ++++++++++
>  tests/qemu-iotests/group   |   1 +
>  6 files changed, 155 insertions(+), 12 deletions(-)
>  create mode 100755 tests/qemu-iotests/143
>  create mode 100644 tests/qemu-iotests/143.out

Thanks, applied to my block tree:

https://github.com/XanClic/qemu/commits/block

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]