Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]

On 02/02/2016 10:26 AM, Peter Maydell wrote:
> On 2 February 2016 at 14:51, Eric Blake <eblake@redhat.com> wrote:
>> Commit 86f4b687 broke compilation on MIPS, which has a preprocessor
>> pollution of '#define mips 1'.  Treat it the same way as we do for
>> the pollution with 'unix', so that QMP remains backwards compatible
>> and only the C code needs to use the alternative 'q_mips' spelling.
>>
>> CC: James Hogan <james.hogan@imgtec.com>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---

>>      # namespace pollution:
>> -    polluted_words = set(['unix', 'errno'])
>> +    polluted_words = set(['unix', 'errno', 'mips'])
>>      name = name.translate(c_name_trans)
>>      if protect and (name in c89_words | c99_words | c11_words | gcc_words
>>                      | cpp_words | polluted_words):
> 
> Looking at commit 86f4b687 I think we also need to add 'sparc' to the
> polluted_words list (Solaris defines that). I would also be unsurprised
> to find that some PPC platforms define 'ppc'. (Tricore is probably
> new enough to have escaped this namespace pollution and we don't
> support it as a host CPU anyway.)

Do we have anyone that can confirm on these platforms?  Obviously, I
proved that it's fairly easy to work around, and I don't mind doing the
followup patch(es), but only if we have concrete cases where we know it
is needed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]