From: Eric Blake <eblake@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>,
"open list:PowerPC" <qemu-ppc@nongnu.org>,
"open list:Overall" <kvm@vger.kernel.org>
Subject: Re: [PATCH v6 4/5] util: [ppc] Use new error_report_abort() instead of abort()
Date: Tue, 2 Feb 2016 12:34:12 -0700 [thread overview]
Message-ID: <56B104B4.7020307@redhat.com> (raw)
In-Reply-To: <145442965530.1539.10919507514033766738.stgit@localhost>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On 02/02/2016 09:14 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> target-ppc/kvm.c | 4 ++--
> target-ppc/kvm_ppc.h | 15 +++++++++------
> target-ppc/mmu-hash32.c | 5 +++--
> target-ppc/mmu_helper.c | 3 +--
> 4 files changed, 15 insertions(+), 12 deletions(-)
>
> @@ -215,36 +218,36 @@ static inline int kvmppc_get_htab_fd(bool write)
> static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize,
> int64_t max_ns)
> {
> - abort();
> + error_report_abort(" ");
> }
I still strongly dislike this. Reporting an error message with nothing
but a trailing whitespace is NOT helpful. Straight 'abort()' is better
than this; if we can't come up with a useful message, then it is not
worth using the message-handling interface.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
"open list:Overall" <kvm@vger.kernel.org>,
Stefan Hajnoczi <stefanha@gmail.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Alexander Graf <agraf@suse.de>,
"open list:PowerPC" <qemu-ppc@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v6 4/5] util: [ppc] Use new error_report_abort() instead of abort()
Date: Tue, 2 Feb 2016 12:34:12 -0700 [thread overview]
Message-ID: <56B104B4.7020307@redhat.com> (raw)
In-Reply-To: <145442965530.1539.10919507514033766738.stgit@localhost>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On 02/02/2016 09:14 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> target-ppc/kvm.c | 4 ++--
> target-ppc/kvm_ppc.h | 15 +++++++++------
> target-ppc/mmu-hash32.c | 5 +++--
> target-ppc/mmu_helper.c | 3 +--
> 4 files changed, 15 insertions(+), 12 deletions(-)
>
> @@ -215,36 +218,36 @@ static inline int kvmppc_get_htab_fd(bool write)
> static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize,
> int64_t max_ns)
> {
> - abort();
> + error_report_abort(" ");
> }
I still strongly dislike this. Reporting an error message with nothing
but a trailing whitespace is NOT helpful. Straight 'abort()' is better
than this; if we can't come up with a useful message, then it is not
worth using the message-handling interface.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-02 19:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 16:13 [Qemu-devel] [RFC][PATCH v6 0/5] utils: Improve and document error reporting Lluís Vilanova
2016-02-02 16:13 ` [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort Lluís Vilanova
2016-02-02 18:53 ` Markus Armbruster
2016-02-02 21:47 ` Thomas Huth
2016-02-03 5:04 ` David Gibson
2016-02-03 9:48 ` Markus Armbruster
2016-02-03 9:58 ` Thomas Huth
2016-02-03 10:38 ` Markus Armbruster
2016-02-03 13:42 ` Lluís Vilanova
2016-02-03 14:34 ` Markus Armbruster
2016-02-03 15:11 ` Lluís Vilanova
2016-02-03 18:06 ` Markus Armbruster
2016-02-03 22:23 ` David Gibson
2016-02-03 7:26 ` Markus Armbruster
2016-02-03 17:59 ` Lluís Vilanova
2016-02-02 16:14 ` [Qemu-devel] [PATCH v6 2/5] util: Use new error_report_fatal/abort instead of error_setg(&error_fatal/abort) Lluís Vilanova
2016-02-02 20:16 ` John Snow
2016-02-02 16:14 ` [PATCH v6 3/5] util: [ppc] Use new error_report_fatal() instead of exit() Lluís Vilanova
2016-02-02 16:14 ` [Qemu-devel] " Lluís Vilanova
2016-02-02 16:14 ` [PATCH v6 4/5] util: [ppc] Use new error_report_abort() instead of abort() Lluís Vilanova
2016-02-02 16:14 ` [Qemu-devel] " Lluís Vilanova
2016-02-02 19:34 ` Eric Blake [this message]
2016-02-02 19:34 ` Eric Blake
2016-02-03 5:06 ` David Gibson
2016-02-03 5:06 ` [Qemu-devel] " David Gibson
2016-02-02 16:14 ` [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors Lluís Vilanova
2016-02-02 19:10 ` Markus Armbruster
2016-02-03 13:47 ` Lluís Vilanova
2016-02-03 14:41 ` Markus Armbruster
2016-02-03 15:17 ` Lluís Vilanova
2016-02-03 15:53 ` Markus Armbruster
2016-02-03 16:58 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B104B4.7020307@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=stefanha@gmail.com \
--cc=thuth@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.