From: Mike Kravetz <mike.kravetz@oracle.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Jerome Marchand <jmarchan@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation
Date: Tue, 2 Feb 2016 15:17:10 -0800 [thread overview]
Message-ID: <56B138F6.70704@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1602021457500.9118@chino.kir.corp.google.com>
On 02/02/2016 02:59 PM, David Rientjes wrote:
> On Tue, 2 Feb 2016, Mike Kravetz wrote:
>
>> Attempting to preallocate 1G gigantic huge pages at boot time with
>> "hugepagesz=1G hugepages=1" on the kernel command line will prevent
>> booting with the following:
>>
>> kernel BUG at mm/hugetlb.c:1218!
>>
>> When mapcount accounting was reworked, the setting of compound_mapcount_ptr
>> in prep_compound_gigantic_page was overlooked. As a result, the validation
>> of mapcount in free_huge_page fails.
>>
>> The "BUG_ON" checks in free_huge_page were also changed to "VM_BUG_ON_PAGE"
>> to assist with debugging.
>>
>> Fixes: af5642a8af ("mm: rework mapcount accounting to enable 4k mapping of THPs")
>> Suggested-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>
> I'm not sure whether this should have a "From: Naoya Horiguchi" line with
> an accompanying sign-off or not, since Naoya debugged and wrote the actual
> fix to prep_compound_gigantic_page().
I agree. Naoya did debug and provide fix via e-mail exchange. He did not
sign-off and I could not tell if he was going to pursue. My only intention
was to fix ASAP.
More than happy to give Naoya credit.
--
Mike Kravetz
>
> Acked-by: David Rientjes <rientjes@google.com>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Jerome Marchand <jmarchan@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH] mm/hugetlb: fix gigantic page initialization/allocation
Date: Tue, 2 Feb 2016 15:17:10 -0800 [thread overview]
Message-ID: <56B138F6.70704@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1602021457500.9118@chino.kir.corp.google.com>
On 02/02/2016 02:59 PM, David Rientjes wrote:
> On Tue, 2 Feb 2016, Mike Kravetz wrote:
>
>> Attempting to preallocate 1G gigantic huge pages at boot time with
>> "hugepagesz=1G hugepages=1" on the kernel command line will prevent
>> booting with the following:
>>
>> kernel BUG at mm/hugetlb.c:1218!
>>
>> When mapcount accounting was reworked, the setting of compound_mapcount_ptr
>> in prep_compound_gigantic_page was overlooked. As a result, the validation
>> of mapcount in free_huge_page fails.
>>
>> The "BUG_ON" checks in free_huge_page were also changed to "VM_BUG_ON_PAGE"
>> to assist with debugging.
>>
>> Fixes: af5642a8af ("mm: rework mapcount accounting to enable 4k mapping of THPs")
>> Suggested-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>
> I'm not sure whether this should have a "From: Naoya Horiguchi" line with
> an accompanying sign-off or not, since Naoya debugged and wrote the actual
> fix to prep_compound_gigantic_page().
I agree. Naoya did debug and provide fix via e-mail exchange. He did not
sign-off and I could not tell if he was going to pursue. My only intention
was to fix ASAP.
More than happy to give Naoya credit.
--
Mike Kravetz
>
> Acked-by: David Rientjes <rientjes@google.com>
>
next prev parent reply other threads:[~2016-02-02 23:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 22:33 [PATCH] mm/hugetlb: fix gigantic page initialization/allocation Mike Kravetz
2016-02-02 22:33 ` Mike Kravetz
2016-02-02 22:50 ` Kirill A. Shutemov
2016-02-02 22:50 ` Kirill A. Shutemov
2016-02-02 22:59 ` David Rientjes
2016-02-02 22:59 ` David Rientjes
2016-02-02 23:17 ` Mike Kravetz [this message]
2016-02-02 23:17 ` Mike Kravetz
2016-02-03 3:01 ` Naoya Horiguchi
2016-02-03 3:01 ` Naoya Horiguchi
2016-02-03 4:15 ` Mike Kravetz
2016-02-03 4:15 ` Mike Kravetz
2016-02-05 11:52 ` Vlastimil Babka
2016-02-05 11:52 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B138F6.70704@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=jmarchan@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.