From: Shawn Lin <shawn.lin@rock-chips.com>
To: Andy Yan <andy.yan@rock-chips.com>, john.stultz@linaro.org
Cc: robh+dt@kernel.org, arnd@arndb.de, shawn.lin@rock-chips.com,
mark.rutland@arm.com, heiko@sntech.de, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com, lorenzo.pieralisi@arm.com,
linux@arm.linux.org.uk, dbaryshkov@gmail.com, richard@nod.at,
linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org,
wxt@rock-chips.com, devicetree@vger.kernel.org,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org,
moritz.fischer@ettus.com, mbrugger@suse.com, sre@kernel.org,
galak@codeaurora.org, jun.nie@linaro.org, dwmw2@infradead.org
Subject: Re: [PATCH v3 4/4] ARM64: dts: rockchip: add syscon-reboot-mode DT node
Date: Wed, 3 Feb 2016 10:07:50 +0800 [thread overview]
Message-ID: <56B160F6.20308@rock-chips.com> (raw)
In-Reply-To: <1454407999-5476-1-git-send-email-andy.yan@rock-chips.com>
On 2016/2/2 18:13, Andy Yan wrote:
> Add syscon-reboot-mode driver DT node for rk3368 platform
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
Work fine with my rk3368-sheep board :)
Tested-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> Changes in v3:
> - descirbe all reboot mode as property instead of subnode
>
> Changes in v2:
> - make this node as a subnode of pmugrf
>
> Changes in v1: None
>
> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index 122777b..5213713 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -45,6 +45,7 @@
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/pinctrl/rockchip.h>
> +#include <dt-bindings/soc/rockchip_boot-mode.h>
> #include <dt-bindings/thermal/thermal.h>
>
> / {
> @@ -554,8 +555,19 @@
> };
>
> pmugrf: syscon@ff738000 {
> - compatible = "rockchip,rk3368-pmugrf", "syscon";
> + compatible = "rockchip,rk3368-pmugrf", "syscon", "simple-mfd";
> reg = <0x0 0xff738000 0x0 0x1000>;
> +
> + reboot-mode {
> + compatible = "syscon-reboot-mode";
> + offset = <0x200>;
> + mode-normal = <BOOT_NORMAL>;
> + mode-recovery = <BOOT_RECOVERY>;
> + mode-fastboot = <BOOT_FASTBOOT>;
> + mode-loader = <BOOT_LOADER>;
> + mode-maskrom = <BOOT_MASKROM>;
> +
> + };
> };
>
> cru: clock-controller@ff760000 {
>
--
Best Regards
Shawn Lin
WARNING: multiple messages have this Message-ID (diff)
From: shawn.lin@rock-chips.com (Shawn Lin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] ARM64: dts: rockchip: add syscon-reboot-mode DT node
Date: Wed, 3 Feb 2016 10:07:50 +0800 [thread overview]
Message-ID: <56B160F6.20308@rock-chips.com> (raw)
In-Reply-To: <1454407999-5476-1-git-send-email-andy.yan@rock-chips.com>
On 2016/2/2 18:13, Andy Yan wrote:
> Add syscon-reboot-mode driver DT node for rk3368 platform
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
Work fine with my rk3368-sheep board :)
Tested-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> Changes in v3:
> - descirbe all reboot mode as property instead of subnode
>
> Changes in v2:
> - make this node as a subnode of pmugrf
>
> Changes in v1: None
>
> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index 122777b..5213713 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -45,6 +45,7 @@
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/pinctrl/rockchip.h>
> +#include <dt-bindings/soc/rockchip_boot-mode.h>
> #include <dt-bindings/thermal/thermal.h>
>
> / {
> @@ -554,8 +555,19 @@
> };
>
> pmugrf: syscon at ff738000 {
> - compatible = "rockchip,rk3368-pmugrf", "syscon";
> + compatible = "rockchip,rk3368-pmugrf", "syscon", "simple-mfd";
> reg = <0x0 0xff738000 0x0 0x1000>;
> +
> + reboot-mode {
> + compatible = "syscon-reboot-mode";
> + offset = <0x200>;
> + mode-normal = <BOOT_NORMAL>;
> + mode-recovery = <BOOT_RECOVERY>;
> + mode-fastboot = <BOOT_FASTBOOT>;
> + mode-loader = <BOOT_LOADER>;
> + mode-maskrom = <BOOT_MASKROM>;
> +
> + };
> };
>
> cru: clock-controller at ff760000 {
>
--
Best Regards
Shawn Lin
next prev parent reply other threads:[~2016-02-03 2:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 9:56 [PATCH v3 0/4] add reboot mode driver Andy Yan
2016-02-02 9:56 ` Andy Yan
2016-02-02 9:59 ` [PATCH v3 1/4] dt-bindings: power: reset: add document for reboot-mode driver Andy Yan
2016-02-02 9:59 ` Andy Yan
2016-02-02 18:29 ` John Stultz
2016-02-02 18:29 ` John Stultz
2016-02-02 18:29 ` John Stultz
[not found] ` <1454407151-4751-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-04 23:08 ` Rob Herring
2016-02-04 23:08 ` Rob Herring
2016-02-04 23:08 ` Rob Herring
2016-02-04 23:46 ` John Stultz
2016-02-04 23:46 ` John Stultz
2016-02-04 23:46 ` John Stultz
2016-02-05 4:35 ` Rob Herring
2016-02-05 4:35 ` Rob Herring
2016-02-05 4:35 ` Rob Herring
2016-02-05 5:03 ` John Stultz
2016-02-05 5:03 ` John Stultz
2016-02-05 5:03 ` John Stultz
2016-02-11 17:04 ` Rob Herring
2016-02-11 17:04 ` Rob Herring
2016-02-11 17:04 ` Rob Herring
2016-02-15 9:43 ` Andy Yan
2016-02-15 9:43 ` Andy Yan
2016-02-15 9:43 ` Andy Yan
2016-02-02 10:02 ` [PATCH v3 2/4] power: reset: add reboot mode driver Andy Yan
2016-02-02 10:02 ` Andy Yan
2016-02-02 18:16 ` Moritz Fischer
2016-02-02 18:16 ` Moritz Fischer
2016-02-02 18:16 ` Moritz Fischer
[not found] ` <1454407325-4804-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-03 11:54 ` kbuild test robot
2016-02-03 11:54 ` kbuild test robot
2016-02-03 11:54 ` kbuild test robot
2016-02-02 10:10 ` [PATCH v3 3/4] ARM: dts: rockchip: add syscon-reboot-mode DT node Andy Yan
2016-02-02 10:10 ` Andy Yan
2016-02-02 10:13 ` [PATCH v3 4/4] ARM64: " Andy Yan
2016-02-02 10:13 ` Andy Yan
2016-02-03 2:07 ` Shawn Lin [this message]
2016-02-03 2:07 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B160F6.20308@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=john.stultz@linaro.org \
--cc=jun.nie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
--cc=moritz.fischer@ettus.com \
--cc=pawel.moll@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=will.deacon@arm.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.