All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mason <slash.tmp@free.fr>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Plain DFS (no voltage scaling)
Date: Wed, 3 Feb 2016 19:25:56 +0100	[thread overview]
Message-ID: <56B24634.6060001@free.fr> (raw)
In-Reply-To: <20160203161428.GJ3469@vireshk>

On 03/02/2016 17:14, Viresh Kumar wrote:
> On 03-02-16, 16:35, Mason wrote:
>> On 03/02/2016 03:10, Viresh Kumar wrote:
>>> On 02-02-16, 22:11, Mason wrote:
>>>> Hello,
>>>>
>>>> I plan to enable the on-demand governor on the tango platform:
>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/tango4-smp8758.dtsi
>>>>
>>>> I found the cpufreq-dt binding doc:
>>>>
>>>> https://www.kernel.org/doc/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
>>>> https://www.kernel.org/doc/Documentation/devicetree/bindings/opp/opp.txt
>>>>
>>>> Something is not clear to me:
>>>>
>>>> If my platform cannot scale the voltage, what information
>>>> should I put in the voltage part of the DT?
>>>
>>> Wouldn't matter if there is no regulator. i.e. you should keep 0, but
>>> even if they have something non-zero, core code will ignore it. But
>>> yeah, it makes sense to keep it zero.
>>
>> Hmmm, I am missing something obvious.
>>
>> My config contains:
>>
>> CONFIG_CPU_FREQ=y
>> CONFIG_CPU_FREQ_GOV_COMMON=y
>> CONFIG_CPU_FREQ_STAT=y
>> CONFIG_CPU_FREQ_STAT_DETAILS=y
>> CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
>> CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
>> CONFIG_CPU_FREQ_GOV_ONDEMAND=y
>> CONFIG_CPUFREQ_DT=y
>>
>> Yet, neither dt_cpufreq_probe() nor cpufreq_init() are being called.
>>
>> Could someone please point to my mistake?
> 
> You need to create a platform device to get cpufreq-dt driver probed.
> Check other users..

The sunxi guys pointed me in the right direction.

http://lxr.free-electrons.com/source/arch/arm/mach-sunxi/sunxi.c#L20

Why isn't there a compatible string like other drivers?

Such as
  compatible = "cpufreq-dt"
which would enable cpufreq on the platform?

Regards.


WARNING: multiple messages have this Message-ID (diff)
From: slash.tmp@free.fr (Mason)
To: linux-arm-kernel@lists.infradead.org
Subject: Plain DFS (no voltage scaling)
Date: Wed, 3 Feb 2016 19:25:56 +0100	[thread overview]
Message-ID: <56B24634.6060001@free.fr> (raw)
In-Reply-To: <20160203161428.GJ3469@vireshk>

On 03/02/2016 17:14, Viresh Kumar wrote:
> On 03-02-16, 16:35, Mason wrote:
>> On 03/02/2016 03:10, Viresh Kumar wrote:
>>> On 02-02-16, 22:11, Mason wrote:
>>>> Hello,
>>>>
>>>> I plan to enable the on-demand governor on the tango platform:
>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/tango4-smp8758.dtsi
>>>>
>>>> I found the cpufreq-dt binding doc:
>>>>
>>>> https://www.kernel.org/doc/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
>>>> https://www.kernel.org/doc/Documentation/devicetree/bindings/opp/opp.txt
>>>>
>>>> Something is not clear to me:
>>>>
>>>> If my platform cannot scale the voltage, what information
>>>> should I put in the voltage part of the DT?
>>>
>>> Wouldn't matter if there is no regulator. i.e. you should keep 0, but
>>> even if they have something non-zero, core code will ignore it. But
>>> yeah, it makes sense to keep it zero.
>>
>> Hmmm, I am missing something obvious.
>>
>> My config contains:
>>
>> CONFIG_CPU_FREQ=y
>> CONFIG_CPU_FREQ_GOV_COMMON=y
>> CONFIG_CPU_FREQ_STAT=y
>> CONFIG_CPU_FREQ_STAT_DETAILS=y
>> CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
>> CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
>> CONFIG_CPU_FREQ_GOV_ONDEMAND=y
>> CONFIG_CPUFREQ_DT=y
>>
>> Yet, neither dt_cpufreq_probe() nor cpufreq_init() are being called.
>>
>> Could someone please point to my mistake?
> 
> You need to create a platform device to get cpufreq-dt driver probed.
> Check other users..

The sunxi guys pointed me in the right direction.

http://lxr.free-electrons.com/source/arch/arm/mach-sunxi/sunxi.c#L20

Why isn't there a compatible string like other drivers?

Such as
  compatible = "cpufreq-dt"
which would enable cpufreq on the platform?

Regards.

  reply	other threads:[~2016-02-03 18:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 21:11 Plain DFS (no voltage scaling) Mason
2016-02-02 21:11 ` Mason
2016-02-03  2:10 ` Viresh Kumar
2016-02-03  2:10   ` Viresh Kumar
2016-02-03 15:35   ` Mason
2016-02-03 15:35     ` Mason
2016-02-03 16:14     ` Viresh Kumar
2016-02-03 16:14       ` Viresh Kumar
2016-02-03 18:25       ` Mason [this message]
2016-02-03 18:25         ` Mason
2016-02-04  3:23         ` Viresh Kumar
2016-02-04  3:23           ` Viresh Kumar
2016-02-03 15:07 ` Mason
2016-02-03 15:07   ` Mason
2016-02-03 16:13   ` Viresh Kumar
2016-02-03 16:13     ` Viresh Kumar
2016-02-03 18:19     ` Mason
2016-02-03 18:19       ` Mason
2016-02-04  3:23       ` Viresh Kumar
2016-02-04  3:23         ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B24634.6060001@free.fr \
    --to=slash.tmp@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.