All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Joonsoo Kim <js1304@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Takashi Iwai <tiwai@suse.com>,
	Chris Metcalf <cmetcalf@ezchip.com>,
	Christoph Lameter <cl@linux.com>,
	linux-api@vger.kernel.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 1/5] mm/vmalloc: query dynamic DEBUG_PAGEALLOC setting
Date: Thu, 4 Feb 2016 09:32:14 +0100	[thread overview]
Message-ID: <56B30C8E.200@de.ibm.com> (raw)
In-Reply-To: <1454565386-10489-2-git-send-email-iamjoonsoo.kim@lge.com>

On 02/04/2016 06:56 AM, Joonsoo Kim wrote:
> We can disable debug_pagealloc processing even if the code is complied
> with CONFIG_DEBUG_PAGEALLOC. This patch changes the code to query
> whether it is enabled or not in runtime.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>


> ---
>  mm/vmalloc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index fb42a5b..e0e51bd 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -543,10 +543,10 @@ static void vmap_debug_free_range(unsigned long start, unsigned long end)
>  	 * debugging doesn't do a broadcast TLB flush so it is a lot
>  	 * faster).
>  	 */
> -#ifdef CONFIG_DEBUG_PAGEALLOC
> -	vunmap_page_range(start, end);
> -	flush_tlb_kernel_range(start, end);
> -#endif
> +	if (debug_pagealloc_enabled()) {
> +		vunmap_page_range(start, end);
> +		flush_tlb_kernel_range(start, end);
> +	}
>  }
> 
>  /*
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Joonsoo Kim <js1304@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Takashi Iwai <tiwai@suse.com>,
	Chris Metcalf <cmetcalf@ezchip.com>,
	Christoph Lameter <cl@linux.com>,
	linux-api@vger.kernel.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 1/5] mm/vmalloc: query dynamic DEBUG_PAGEALLOC setting
Date: Thu, 4 Feb 2016 09:32:14 +0100	[thread overview]
Message-ID: <56B30C8E.200@de.ibm.com> (raw)
In-Reply-To: <1454565386-10489-2-git-send-email-iamjoonsoo.kim@lge.com>

On 02/04/2016 06:56 AM, Joonsoo Kim wrote:
> We can disable debug_pagealloc processing even if the code is complied
> with CONFIG_DEBUG_PAGEALLOC. This patch changes the code to query
> whether it is enabled or not in runtime.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>


> ---
>  mm/vmalloc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index fb42a5b..e0e51bd 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -543,10 +543,10 @@ static void vmap_debug_free_range(unsigned long start, unsigned long end)
>  	 * debugging doesn't do a broadcast TLB flush so it is a lot
>  	 * faster).
>  	 */
> -#ifdef CONFIG_DEBUG_PAGEALLOC
> -	vunmap_page_range(start, end);
> -	flush_tlb_kernel_range(start, end);
> -#endif
> +	if (debug_pagealloc_enabled()) {
> +		vunmap_page_range(start, end);
> +		flush_tlb_kernel_range(start, end);
> +	}
>  }
> 
>  /*
> 

  reply	other threads:[~2016-02-04  8:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04  5:56 [PATCH 0/5] follow-up "Optimize CONFIG_DEBUG_PAGEALLOC" Joonsoo Kim
2016-02-04  5:56 ` Joonsoo Kim
2016-02-04  5:56 ` Joonsoo Kim
2016-02-04  5:56 ` [PATCH 1/5] mm/vmalloc: query dynamic DEBUG_PAGEALLOC setting Joonsoo Kim
2016-02-04  5:56   ` Joonsoo Kim
2016-02-04  8:32   ` Christian Borntraeger [this message]
2016-02-04  8:32     ` Christian Borntraeger
     [not found]   ` <1454565386-10489-2-git-send-email-iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org>
2016-02-04 22:18     ` David Rientjes
2016-02-04 22:18       ` David Rientjes
2016-02-04 22:18       ` David Rientjes
     [not found]       ` <alpine.DEB.2.10.1602041417330.29117-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2016-02-05 16:13         ` Joonsoo Kim
2016-02-05 16:13           ` Joonsoo Kim
2016-02-05 16:13           ` Joonsoo Kim
2016-02-04  5:56 ` [PATCH 2/5] mm/slub: " Joonsoo Kim
2016-02-04  5:56   ` Joonsoo Kim
     [not found]   ` <1454565386-10489-3-git-send-email-iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org>
2016-02-04  8:31     ` Christian Borntraeger
2016-02-04  8:31       ` Christian Borntraeger
2016-02-04  8:31       ` Christian Borntraeger
2016-02-04 16:21       ` Joonsoo Kim
2016-02-04 16:21         ` Joonsoo Kim
2016-02-04  5:56 ` [PATCH 3/5] sound: " Joonsoo Kim
2016-02-04  5:56   ` Joonsoo Kim
2016-02-04 22:19   ` David Rientjes
2016-02-04 22:19     ` David Rientjes
2016-02-05  9:26   ` Takashi Iwai
2016-02-05  9:26     ` Takashi Iwai
2016-02-04  5:56 ` [PATCH 4/5] powerpc: " Joonsoo Kim
2016-02-04  5:56   ` Joonsoo Kim
2016-02-04 22:22   ` David Rientjes
2016-02-04 22:22     ` David Rientjes
2016-02-04  5:56 ` [PATCH 5/5] tile: " Joonsoo Kim
2016-02-04  5:56   ` Joonsoo Kim
     [not found]   ` <1454565386-10489-6-git-send-email-iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org>
2016-02-09 16:56     ` Chris Metcalf
2016-02-09 16:56       ` Chris Metcalf
2016-02-09 16:56       ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B30C8E.200@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=cl@linux.com \
    --cc=cmetcalf@ezchip.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=js1304@gmail.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.