From: Doug Ledford <dledford@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: linux-rdma@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: amso1100: fix format string for 64-bit phys_addr
Date: Thu, 4 Feb 2016 07:15:05 -0500 [thread overview]
Message-ID: <56B340C9.2060303@redhat.com> (raw)
In-Reply-To: <2307631.X1DYNXxKPZ@wuerfel>
[-- Attachment #1.1: Type: text/plain, Size: 1809 bytes --]
On 02/01/2016 11:34 AM, Arnd Bergmann wrote:
> The amso1100 driver prints a phys_addr_t by casting it to a pointer,
> which causes a warning when phys_addr_t is 64-bit and pointers
> are 32-bit:
>
> drivers/staging/rdma/amso1100/c2.c: In function 'c2_rx_error':
> drivers/staging/rdma/amso1100/c2.c:430:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> This changes the format string to print the address as a 64-bit
> number all the time to avoids the warnings. Ideally we would use
> the %pap format string for phys_addr_t, but that doesn't work
> here easily as it requires passing a pointer to the address.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Found on ARM randconfig testing. This must have been there forever but is
> rather hard to trigger even with randconfig builds.
>
> diff --git a/drivers/staging/rdma/amso1100/c2.c b/drivers/staging/rdma/amso1100/c2.c
> index b46ebd1ae15a..170a42a60552 100644
> --- a/drivers/staging/rdma/amso1100/c2.c
> +++ b/drivers/staging/rdma/amso1100/c2.c
> @@ -426,8 +426,8 @@ static void c2_rx_error(struct c2_port *c2_port, struct c2_element *elem)
> pr_debug(" index : %Zu\n",
> elem - c2_port->rx_ring.start);
> pr_debug(" len : %u\n", rx_desc->len);
> - pr_debug(" rxp_hdr : %p [PA %p]\n", rxp_hdr,
> - (void *) __pa((unsigned long) rxp_hdr));
> + pr_debug(" rxp_hdr : %p [PA %016llx\n", rxp_hdr,
> + (u64)__pa((unsigned long) rxp_hdr));
> pr_debug(" flags : 0x%x\n", rxp_hdr->flags);
> pr_debug(" status: 0x%x\n", rxp_hdr->status);
> pr_debug(" len : %u\n", rxp_hdr->len);
>
I've sent off a deletion of this file to Linus already, sorry.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: dledford@redhat.com (Doug Ledford)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: amso1100: fix format string for 64-bit phys_addr
Date: Thu, 4 Feb 2016 07:15:05 -0500 [thread overview]
Message-ID: <56B340C9.2060303@redhat.com> (raw)
In-Reply-To: <2307631.X1DYNXxKPZ@wuerfel>
On 02/01/2016 11:34 AM, Arnd Bergmann wrote:
> The amso1100 driver prints a phys_addr_t by casting it to a pointer,
> which causes a warning when phys_addr_t is 64-bit and pointers
> are 32-bit:
>
> drivers/staging/rdma/amso1100/c2.c: In function 'c2_rx_error':
> drivers/staging/rdma/amso1100/c2.c:430:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> This changes the format string to print the address as a 64-bit
> number all the time to avoids the warnings. Ideally we would use
> the %pap format string for phys_addr_t, but that doesn't work
> here easily as it requires passing a pointer to the address.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Found on ARM randconfig testing. This must have been there forever but is
> rather hard to trigger even with randconfig builds.
>
> diff --git a/drivers/staging/rdma/amso1100/c2.c b/drivers/staging/rdma/amso1100/c2.c
> index b46ebd1ae15a..170a42a60552 100644
> --- a/drivers/staging/rdma/amso1100/c2.c
> +++ b/drivers/staging/rdma/amso1100/c2.c
> @@ -426,8 +426,8 @@ static void c2_rx_error(struct c2_port *c2_port, struct c2_element *elem)
> pr_debug(" index : %Zu\n",
> elem - c2_port->rx_ring.start);
> pr_debug(" len : %u\n", rx_desc->len);
> - pr_debug(" rxp_hdr : %p [PA %p]\n", rxp_hdr,
> - (void *) __pa((unsigned long) rxp_hdr));
> + pr_debug(" rxp_hdr : %p [PA %016llx\n", rxp_hdr,
> + (u64)__pa((unsigned long) rxp_hdr));
> pr_debug(" flags : 0x%x\n", rxp_hdr->flags);
> pr_debug(" status: 0x%x\n", rxp_hdr->status);
> pr_debug(" len : %u\n", rxp_hdr->len);
>
I've sent off a deletion of this file to Linus already, sorry.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160204/f4c4bc6a/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Doug Ledford <dledford@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-rdma@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: amso1100: fix format string for 64-bit phys_addr
Date: Thu, 4 Feb 2016 07:15:05 -0500 [thread overview]
Message-ID: <56B340C9.2060303@redhat.com> (raw)
In-Reply-To: <2307631.X1DYNXxKPZ@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]
On 02/01/2016 11:34 AM, Arnd Bergmann wrote:
> The amso1100 driver prints a phys_addr_t by casting it to a pointer,
> which causes a warning when phys_addr_t is 64-bit and pointers
> are 32-bit:
>
> drivers/staging/rdma/amso1100/c2.c: In function 'c2_rx_error':
> drivers/staging/rdma/amso1100/c2.c:430:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> This changes the format string to print the address as a 64-bit
> number all the time to avoids the warnings. Ideally we would use
> the %pap format string for phys_addr_t, but that doesn't work
> here easily as it requires passing a pointer to the address.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Found on ARM randconfig testing. This must have been there forever but is
> rather hard to trigger even with randconfig builds.
>
> diff --git a/drivers/staging/rdma/amso1100/c2.c b/drivers/staging/rdma/amso1100/c2.c
> index b46ebd1ae15a..170a42a60552 100644
> --- a/drivers/staging/rdma/amso1100/c2.c
> +++ b/drivers/staging/rdma/amso1100/c2.c
> @@ -426,8 +426,8 @@ static void c2_rx_error(struct c2_port *c2_port, struct c2_element *elem)
> pr_debug(" index : %Zu\n",
> elem - c2_port->rx_ring.start);
> pr_debug(" len : %u\n", rx_desc->len);
> - pr_debug(" rxp_hdr : %p [PA %p]\n", rxp_hdr,
> - (void *) __pa((unsigned long) rxp_hdr));
> + pr_debug(" rxp_hdr : %p [PA %016llx\n", rxp_hdr,
> + (u64)__pa((unsigned long) rxp_hdr));
> pr_debug(" flags : 0x%x\n", rxp_hdr->flags);
> pr_debug(" status: 0x%x\n", rxp_hdr->status);
> pr_debug(" len : %u\n", rxp_hdr->len);
>
I've sent off a deletion of this file to Linus already, sorry.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
next prev parent reply other threads:[~2016-02-04 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 16:34 [PATCH] staging: amso1100: fix format string for 64-bit phys_addr Arnd Bergmann
2016-02-01 16:34 ` Arnd Bergmann
2016-02-01 16:34 ` Arnd Bergmann
2016-02-04 12:15 ` Doug Ledford [this message]
2016-02-04 12:15 ` Doug Ledford
2016-02-04 12:15 ` Doug Ledford
2016-02-04 13:07 ` Arnd Bergmann
2016-02-04 13:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B340C9.2060303@redhat.com \
--to=dledford@redhat.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hal.rosenstock@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.