All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Timur Tabi <timur@codeaurora.org>, Fu Wei <fu.wei@linaro.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Paweł Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Wim Van Sebroeck" <wim@iguana.be>, "Jon Corbet" <corbet@lwn.net>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"Suravee Suthikulpanit" <Suravee.Suthikulpanit@amd.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Linaro ACPI Mailman List" <linaro-acpi@lists.linaro.org>,
	rruigrok@codeaurora.org, "Abdulhamid,
	Harb" <harba@codeaurora.org>,
	"Christopher Covington" <cov@codeaurora.org>,
	"Dave Young" <dyoung@redhat.com>,
	"Pratyush Anand" <panand@redhat.com>,
	"G Gregory" <graeme.gregory@linaro.org>,
	"Al Stone" <al.stone@linaro.org>,
	"Hanjun Guo" <hanjun.guo@linaro.org>,
	"Jon Masters" <jcm@redhat.com>, "Arnd Bergmann" <arnd@arndb.de>,
	"Leo Duran" <leo.duran@amd.com>,
	"Sudeep Holla" <sudeep.holla@arm.com>
Subject: Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support
Date: Thu, 4 Feb 2016 06:41:35 -0800	[thread overview]
Message-ID: <56B3631F.6090304@roeck-us.net> (raw)
In-Reply-To: <56B35698.4020100@codeaurora.org>

On 02/04/2016 05:48 AM, Timur Tabi wrote:
> Guenter Roeck wrote:
>> Also, if panic is enabled, the timeout needs to be adjusted accordingly
>> (to only panic after the entire timeout period has expired, not after
>> half of it). We can not panic the system after timeout / 2.
>
> It's a debugging feature, not an actual watchdog timeout panic.  That's why it's disabled by default.
>

"* When the first stage(the half timeout) is reached, WS0 interrupt is
  * triggered, at this moment the second watch period starts;
  * In the WS0 interrupt routine, panic will be triggered for saving the
  * system context.
  * If the system is getting into trouble and cannot be reset by panic or
  * restart properly by the kdump kernel(if supported), then the second
  * stage (the timeout) will be reached, system will be reset by WS1."

That doesn't sound like debugging to me.

Guenter


WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support
Date: Thu, 4 Feb 2016 06:41:35 -0800	[thread overview]
Message-ID: <56B3631F.6090304@roeck-us.net> (raw)
In-Reply-To: <56B35698.4020100@codeaurora.org>

On 02/04/2016 05:48 AM, Timur Tabi wrote:
> Guenter Roeck wrote:
>> Also, if panic is enabled, the timeout needs to be adjusted accordingly
>> (to only panic after the entire timeout period has expired, not after
>> half of it). We can not panic the system after timeout / 2.
>
> It's a debugging feature, not an actual watchdog timeout panic.  That's why it's disabled by default.
>

"* When the first stage(the half timeout) is reached, WS0 interrupt is
  * triggered, at this moment the second watch period starts;
  * In the WS0 interrupt routine, panic will be triggered for saving the
  * system context.
  * If the system is getting into trouble and cannot be reset by panic or
  * restart properly by the kdump kernel(if supported), then the second
  * stage (the timeout) will be reached, system will be reset by WS1."

That doesn't sound like debugging to me.

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Timur Tabi <timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Fu Wei <fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Paweł Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Ian Campbell"
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"Wim Van Sebroeck" <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
	"Jon Corbet" <corbet-T1hC0tSOHrs@public.gmane.org>,
	"Catalin Marinas" <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	"Will Deacon" <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	"Suravee Suthikulpanit"
	<Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Linaro ACPI Mailman List"
	<linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org>,
	rruigrok-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, "Abdulhamid,
	Harb" <harba-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"Christopher Covington"
	<cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"Dave Young" <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Pratyush Anand" <panand-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"G Gregory"
	<graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Al Stone" <al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support
Date: Thu, 4 Feb 2016 06:41:35 -0800	[thread overview]
Message-ID: <56B3631F.6090304@roeck-us.net> (raw)
In-Reply-To: <56B35698.4020100-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

On 02/04/2016 05:48 AM, Timur Tabi wrote:
> Guenter Roeck wrote:
>> Also, if panic is enabled, the timeout needs to be adjusted accordingly
>> (to only panic after the entire timeout period has expired, not after
>> half of it). We can not panic the system after timeout / 2.
>
> It's a debugging feature, not an actual watchdog timeout panic.  That's why it's disabled by default.
>

"* When the first stage(the half timeout) is reached, WS0 interrupt is
  * triggered, at this moment the second watch period starts;
  * In the WS0 interrupt routine, panic will be triggered for saving the
  * system context.
  * If the system is getting into trouble and cannot be reset by panic or
  * restart properly by the kdump kernel(if supported), then the second
  * stage (the timeout) will be reached, system will be reset by WS1."

That doesn't sound like debugging to me.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-02-04 14:41 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 17:18 [PATCH v10 0/5] Watchdog: introduce ARM SBSA watchdog driver fu.wei
2016-02-03 17:18 ` fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 1/5] Documentation: add sbsa-gwdt driver documentation fu.wei
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 2/5] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts fu.wei
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 3/5] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi fu.wei
2016-02-03 17:18   ` fu.wei-QSEj5FYQhm4dnm+yROfE0A
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:18 ` [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver fu.wei
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:48   ` Timur Tabi
2016-02-03 17:48     ` Timur Tabi
2016-02-03 17:57     ` Fu Wei
2016-02-03 17:57       ` Fu Wei
2016-02-03 17:57       ` Fu Wei
2016-02-03 17:58       ` Timur Tabi
2016-02-03 17:58         ` Timur Tabi
2016-02-03 17:58         ` Timur Tabi
2016-02-03 18:09         ` Fu Wei
2016-02-03 18:09           ` Fu Wei
2016-02-03 18:09           ` Fu Wei
2016-02-03 18:12           ` Timur Tabi
2016-02-03 18:12             ` Timur Tabi
2016-02-03 18:12             ` Timur Tabi
2016-02-04 16:25   ` Mathieu Poirier
2016-02-04 16:25     ` Mathieu Poirier
2016-02-04 16:25     ` Mathieu Poirier
2016-02-05  9:01     ` Fu Wei
2016-02-05  9:01       ` Fu Wei
2016-02-05  9:01       ` Fu Wei
2016-02-04 16:31   ` Will Deacon
2016-02-04 16:31     ` Will Deacon
2016-02-04 16:31     ` Will Deacon
2016-02-04 16:37     ` Timur Tabi
2016-02-04 16:37       ` Timur Tabi
2016-02-04 16:37       ` Timur Tabi
2016-02-04 16:46       ` Guenter Roeck
2016-02-04 16:46         ` Guenter Roeck
2016-02-05  8:52         ` Fu Wei
2016-02-05  8:52           ` Fu Wei
2016-02-05  8:52           ` Fu Wei
2016-02-03 17:18 ` [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support fu.wei
2016-02-03 17:18   ` fu.wei at linaro.org
2016-02-03 17:27   ` Timur Tabi
2016-02-03 17:27     ` Timur Tabi
2016-02-03 17:49     ` Fu Wei
2016-02-03 17:49       ` Fu Wei
2016-02-03 17:49       ` Fu Wei
2016-02-03 17:53       ` Timur Tabi
2016-02-03 17:53         ` Timur Tabi
2016-02-03 17:53         ` Timur Tabi
2016-02-03 18:06         ` Fu Wei
2016-02-03 18:06           ` Fu Wei
2016-02-03 18:06           ` Fu Wei
2016-02-03 18:08           ` Timur Tabi
2016-02-03 18:08             ` Timur Tabi
2016-02-03 18:08             ` Timur Tabi
2016-02-03 18:18             ` Fu Wei
2016-02-03 18:18               ` Fu Wei
2016-02-03 18:18               ` Fu Wei
2016-02-03 18:26               ` Timur Tabi
2016-02-03 18:26                 ` Timur Tabi
2016-02-03 18:26                 ` Timur Tabi
2016-02-03 18:37                 ` Fu Wei
2016-02-03 18:37                   ` Fu Wei
2016-02-03 18:37                   ` Fu Wei
2016-02-03 18:45                   ` Timur Tabi
2016-02-03 18:45                     ` Timur Tabi
2016-02-03 18:45                     ` Timur Tabi
2016-02-03 23:00                     ` Fu Wei
2016-02-03 23:00                       ` Fu Wei
2016-02-03 23:00                       ` Fu Wei
2016-02-04  5:17                       ` Guenter Roeck
2016-02-04  5:17                         ` Guenter Roeck
2016-02-04  5:17                         ` Guenter Roeck
2016-02-04 13:48                         ` Timur Tabi
2016-02-04 13:48                           ` Timur Tabi
2016-02-04 13:48                           ` Timur Tabi
2016-02-04 14:41                           ` Guenter Roeck [this message]
2016-02-04 14:41                             ` Guenter Roeck
2016-02-04 14:41                             ` Guenter Roeck
2016-02-05  9:51                         ` Fu Wei
2016-02-05  9:51                           ` Fu Wei
2016-02-05  9:51                           ` Fu Wei
2016-02-05 13:02                           ` Thomas Petazzoni
2016-02-05 13:02                             ` Thomas Petazzoni
2016-02-05 13:02                             ` Thomas Petazzoni
2016-02-05 13:08                             ` Timur Tabi
2016-02-05 13:08                               ` Timur Tabi
2016-02-05 13:08                               ` Timur Tabi
2016-02-05 13:33                               ` Thomas Petazzoni
2016-02-05 13:33                                 ` Thomas Petazzoni
2016-02-05 13:33                                 ` Thomas Petazzoni
2016-02-05 14:42                           ` Guenter Roeck
2016-02-05 14:42                             ` Guenter Roeck
2016-02-05 14:42                             ` Guenter Roeck
2016-02-05 18:21                             ` Fu Wei
2016-02-05 18:21                               ` Fu Wei
2016-02-05 18:21                               ` Fu Wei
2016-02-05 23:54                               ` Guenter Roeck
2016-02-05 23:54                                 ` Guenter Roeck
2016-02-05 23:54                                 ` Guenter Roeck
2016-02-06 18:02                                 ` Fu Wei
2016-02-06 18:02                                   ` Fu Wei
2016-02-06 18:02                                   ` Fu Wei
2016-02-06 18:55                                   ` Timur Tabi
2016-02-06 18:55                                     ` Timur Tabi
2016-02-06 18:55                                     ` Timur Tabi
2016-02-07  2:02                                     ` Fu Wei
2016-02-07  2:02                                       ` Fu Wei
2016-02-07  2:02                                       ` Fu Wei
2016-02-06 18:57                                   ` Guenter Roeck
2016-02-06 18:57                                     ` Guenter Roeck
2016-02-06 18:57                                     ` Guenter Roeck
2016-02-07  2:12                                     ` Fu Wei
2016-02-07  2:12                                       ` Fu Wei
2016-02-07  2:12                                       ` Fu Wei
2016-02-04 16:32   ` Mathieu Poirier
2016-02-04 16:32     ` Mathieu Poirier
2016-02-04 16:32     ` Mathieu Poirier
2016-02-04 16:41     ` Guenter Roeck
2016-02-04 16:41       ` Guenter Roeck
2016-02-04 16:41       ` Guenter Roeck
2016-02-04 16:43     ` Timur Tabi
2016-02-04 16:43       ` Timur Tabi
2016-02-04 16:43       ` Timur Tabi
2016-02-05  9:20       ` Fu Wei
2016-02-05  9:20         ` Fu Wei
2016-02-05  9:20         ` Fu Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B3631F.6090304@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Suravee.Suthikulpanit@amd.com \
    --cc=al.stone@linaro.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=cov@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dyoung@redhat.com \
    --cc=fu.wei@linaro.org \
    --cc=galak@codeaurora.org \
    --cc=graeme.gregory@linaro.org \
    --cc=hanjun.guo@linaro.org \
    --cc=harba@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jcm@redhat.com \
    --cc=leo.duran@amd.com \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=panand@redhat.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rruigrok@codeaurora.org \
    --cc=sudeep.holla@arm.com \
    --cc=timur@codeaurora.org \
    --cc=will.deacon@arm.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.