From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
lee.jones@linaro.org, alexandre.belloni@free-electrons.com
Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally
Date: Thu, 4 Feb 2016 13:49:26 -0300 [thread overview]
Message-ID: <56B38116.2010302@osg.samsung.com> (raw)
In-Reply-To: <56B2BC7B.4070807@nvidia.com>
Hello Laxman,
On 02/03/2016 11:50 PM, Laxman Dewangan wrote:
[snip]
>>>>
>>> Looks good and works properly (RTC, unbind/rebind, wakealarm again)
>>> but... after applying this patch the device cannot suspend to RAM after
>>> unbind/rebind.
>>>
>>> Reproduce path, after booting:
>>> $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/unbind
>>> $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/bind
>>> $ rtcwake -d rtc2 -m mem -s 5 -v
>>> (or instead of rtcwake: echo mem > /sys/power/state)
>>
>
> Can you please also try to test in your setup which have MAX77802?
> On this, we do not create i2c client and do regmap_init_i2c. So may be it helps on narrow down the issue.
>
Sorry for the delay but I was busy with others tasks. I've tested it
on an Exynos5800 Peach Pi (which has a max77802) and I've the same
issue. The system doesn't suspend after the max77802-rc unbind.
As Krzysztof narrowed down, commenting the regmap_del_irq_chip() call
in the .remove callback makes it to not fail again.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
lee.jones@linaro.org, alexandre.belloni@free-electrons.com
Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: Re: [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally
Date: Thu, 4 Feb 2016 13:49:26 -0300 [thread overview]
Message-ID: <56B38116.2010302@osg.samsung.com> (raw)
In-Reply-To: <56B2BC7B.4070807@nvidia.com>
Hello Laxman,
On 02/03/2016 11:50 PM, Laxman Dewangan wrote:
[snip]
>>>>
>>> Looks good and works properly (RTC, unbind/rebind, wakealarm again)
>>> but... after applying this patch the device cannot suspend to RAM after
>>> unbind/rebind.
>>>
>>> Reproduce path, after booting:
>>> $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/unbind
>>> $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/bind
>>> $ rtcwake -d rtc2 -m mem -s 5 -v
>>> (or instead of rtcwake: echo mem > /sys/power/state)
>>
>
> Can you please also try to test in your setup which have MAX77802?
> On this, we do not create i2c client and do regmap_init_i2c. So may be it helps on narrow down the issue.
>
Sorry for the delay but I was busy with others tasks. I've tested it
on an Exynos5800 Peach Pi (which has a max77802) and I've the same
issue. The system doesn't suspend after the max77802-rc unbind.
As Krzysztof narrowed down, commenting the regmap_del_irq_chip() call
in the .remove callback makes it to not fail again.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-02-04 16:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 13:47 [rtc-linux] [PATCH V3 0/5] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan
2016-02-03 13:47 ` Laxman Dewangan
2016-02-03 13:47 ` [rtc-linux] [PATCH V3 1/5] rtc: max77686: fix checkpatch error Laxman Dewangan
2016-02-03 13:47 ` Laxman Dewangan
2016-02-03 13:47 ` [rtc-linux] [PATCH V3 2/5] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan
2016-02-03 13:47 ` Laxman Dewangan
2016-02-03 13:47 ` [rtc-linux] [PATCH V3 3/5] rtc: max77686: avoid reference of parent device info multiple places Laxman Dewangan
2016-02-03 13:47 ` Laxman Dewangan
2016-02-03 13:47 ` [rtc-linux] [PATCH V3 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan
2016-02-03 13:47 ` Laxman Dewangan
2016-02-03 13:47 ` [rtc-linux] [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan
2016-02-03 13:47 ` Laxman Dewangan
2016-02-04 0:10 ` [rtc-linux] " Krzysztof Kozlowski
2016-02-04 0:10 ` Krzysztof Kozlowski
2016-02-04 2:03 ` [rtc-linux] " Laxman Dewangan
2016-02-04 2:03 ` Laxman Dewangan
2016-02-04 2:50 ` [rtc-linux] " Laxman Dewangan
2016-02-04 2:50 ` Laxman Dewangan
2016-02-04 3:04 ` [rtc-linux] " Javier Martinez Canillas
2016-02-04 3:04 ` Javier Martinez Canillas
2016-02-04 16:49 ` Javier Martinez Canillas [this message]
2016-02-04 16:49 ` Javier Martinez Canillas
2016-02-04 6:58 ` [rtc-linux] " Krzysztof Kozlowski
2016-02-04 6:58 ` Krzysztof Kozlowski
2016-02-04 9:08 ` [rtc-linux] " Krzysztof Kozlowski
2016-02-04 9:08 ` Krzysztof Kozlowski
2016-02-04 10:13 ` [rtc-linux] " Laxman Dewangan
2016-02-04 10:13 ` Laxman Dewangan
2016-02-04 17:35 ` [rtc-linux] " Javier Martinez Canillas
2016-02-04 17:35 ` Javier Martinez Canillas
2016-02-05 14:37 ` [rtc-linux] " Laxman Dewangan
2016-02-05 14:37 ` Laxman Dewangan
2016-02-06 5:30 ` [rtc-linux] " Javier Martinez Canillas
2016-02-06 5:30 ` Javier Martinez Canillas
2016-02-06 6:29 ` [rtc-linux] " Laxman Dewangan
2016-02-06 6:29 ` Laxman Dewangan
2016-02-06 13:01 ` [rtc-linux] " Javier Martinez Canillas
2016-02-06 13:01 ` Javier Martinez Canillas
2016-02-06 13:40 ` [rtc-linux] " Laxman Dewangan
2016-02-06 13:40 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B38116.2010302@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.