Re: [Qemu-devel] [PATCH v5 9/9] cputlb: modernise the debug support

[Richard Henderson <rth@twiddle.net>]

On 02/05/2016 01:56 AM, Alex Bennée wrote:
> To avoid cluttering the code with #ifdef legs we wrap up the print
> statements into a tlb_debug() macro. As access to the virtual TLB can
> get quite heavy defining DEBUG_TLB_LOG will ensure all the logs go to
> the qemu_log target of CPU_LOG_MMU instead of stderr. This remains
> compile time optional as these debug statements haven't been considered
> for usefulness for user visible logging.
>
> I've also removed DEBUG_TLB_CHECK which wasn't used.
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
>
> ---
> v2
>    - ensure compiler checks format strings even if debug is optimised out
> v5
>    - reword commit to justify not just using qemu_log at this time
> ---
>   cputlb.c | 54 +++++++++++++++++++++++++++++++++++-------------------
>   1 file changed, 35 insertions(+), 19 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~