From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH 1/3] x86/mm: drop guest_{map, get_eff}_l1e() hooks
Date: Fri, 5 Feb 2016 14:41:57 +0000 [thread overview]
Message-ID: <56B4B4B5.9020905@citrix.com> (raw)
In-Reply-To: <56B464EA02000078000CEDB7@prv-mh.provo.novell.com>
On 05/02/16 08:01, Jan Beulich wrote:
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -844,6 +844,15 @@ void paging_final_teardown(struct domain
> * creation. */
> int paging_enable(struct domain *d, u32 mode)
> {
> + switch ( mode & (PG_external | PG_translate) )
> + {
> + case 0:
> + case PG_external | PG_translate:
> + break;
> + default:
> + return -EINVAL;
> + }
if ( (mode & PG_external) != (mode & PG_translate) )
return -EINVAL;
seems rather more concise.
Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Definitely a good improvement.
next prev parent reply other threads:[~2016-02-05 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 7:51 [PATCH 0/3] x86/mm: paging simplifications Jan Beulich
2016-02-05 8:01 ` [PATCH 1/3] x86/mm: drop guest_{map, get_eff}_l1e() hooks Jan Beulich
2016-02-05 14:41 ` Andrew Cooper [this message]
2016-02-05 15:24 ` Tim Deegan
2016-02-05 15:30 ` Jan Beulich
2016-02-05 8:02 ` [PATCH 2/3] x86/mm: make {cmpxchg, write}_guest_entry() hook shadow mode specific Jan Beulich
2016-02-05 14:59 ` Andrew Cooper
2016-02-05 8:02 ` [PATCH 3/3] x86/shadow: remove a few 32-bit hypervisor leftovers Jan Beulich
2016-02-05 15:22 ` [PATCH 0/3] x86/mm: paging simplifications Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B4B4B5.9020905@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.