Re: [PATCH v3 2/3] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

[Razvan Cojocaru <rcojocaru@bitdefender.com>]

On 02/05/2016 11:22 PM, Tamas K Lengyel wrote:
> The altp2m subsystem in its current form duplicates much of the existing
> code present in p2m for setting mem_access permissions. In this patch we
> consolidate the two versions but keep the separate MEMOP and HVMOP interfaces.
> 
> Signed-off-by: Tamas K Lengyel <tlengyel@novetta.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
> Cc: Stefano Stabellini <stefano.stabellini@citrix.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> v3: Keep the external-facing interfaces and tools as they are
>     Pass gfn_t and make p2m_set_altp2m_mem_access inline
>     Remove goto and just return rc directly
> v2: Don't deprecate the HVMOP hypercall for setting mem_access
>     Use unsigned int instead of unsigned long
> ---
>  xen/arch/arm/p2m.c           |   9 +--
>  xen/arch/x86/hvm/hvm.c       |   6 +-
>  xen/arch/x86/mm/p2m.c        | 168 +++++++++++++++++++------------------------
>  xen/common/mem_access.c      |   2 +-
>  xen/include/asm-x86/p2m.h    |   4 --
>  xen/include/xen/p2m-common.h |   3 +-
>  6 files changed, 86 insertions(+), 106 deletions(-)

Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>


Thanks,
Razvan