From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>, Arnd Bergmann <arnd@arndb.de>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] iio: chemical: select IRQ_WORK for ATLAS ph sensor
Date: Sat, 6 Feb 2016 18:38:54 +0000 [thread overview]
Message-ID: <56B63DBE.8040507@kernel.org> (raw)
In-Reply-To: <CAKzfze8b7Q4ZHyXW=wq4K2ETFoMrfERpTci2dSAzSgCCrWpnzg@mail.gmail.com>
On 03/02/16 07:55, Matt Ranostay wrote:
> Reviewed-by: Matt Ranostay <mranostay@gmail.com>
>
> On Tue, Feb 2, 2016 at 6:36 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The newly added atlas-ph-sensor driver uses irq_work_queue, which
>> may not always be enabled:
>>
>> ERROR: "irq_work_queue" [drivers/iio/chemical/atlas-ph-sensor.ko] undefined!
>>
>> This adds a 'select' statement to Kconfig to ensure it's there
>> when we need it.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 27dec00ecf2d ("iio: chemical: add Atlas pH-SM sensor support")
>>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to fail to spot and IRQ_WORK related issues ;)
Thanks,
Jonathan
>> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
>> index ce7cd1370f74..f73290f84c90 100644
>> --- a/drivers/iio/chemical/Kconfig
>> +++ b/drivers/iio/chemical/Kconfig
>> @@ -10,6 +10,7 @@ config ATLAS_PH_SENSOR
>> select REGMAP_I2C
>> select IIO_BUFFER
>> select IIO_TRIGGERED_BUFFER
>> + select IRQ_WORK
>> help
>> Say Y here to build I2C interface support for the Atlas
>> Scientific OEM pH-SM sensor.
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: chemical: select IRQ_WORK for ATLAS ph sensor
Date: Sat, 6 Feb 2016 18:38:54 +0000 [thread overview]
Message-ID: <56B63DBE.8040507@kernel.org> (raw)
In-Reply-To: <CAKzfze8b7Q4ZHyXW=wq4K2ETFoMrfERpTci2dSAzSgCCrWpnzg@mail.gmail.com>
On 03/02/16 07:55, Matt Ranostay wrote:
> Reviewed-by: Matt Ranostay <mranostay@gmail.com>
>
> On Tue, Feb 2, 2016 at 6:36 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The newly added atlas-ph-sensor driver uses irq_work_queue, which
>> may not always be enabled:
>>
>> ERROR: "irq_work_queue" [drivers/iio/chemical/atlas-ph-sensor.ko] undefined!
>>
>> This adds a 'select' statement to Kconfig to ensure it's there
>> when we need it.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 27dec00ecf2d ("iio: chemical: add Atlas pH-SM sensor support")
>>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to fail to spot and IRQ_WORK related issues ;)
Thanks,
Jonathan
>> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
>> index ce7cd1370f74..f73290f84c90 100644
>> --- a/drivers/iio/chemical/Kconfig
>> +++ b/drivers/iio/chemical/Kconfig
>> @@ -10,6 +10,7 @@ config ATLAS_PH_SENSOR
>> select REGMAP_I2C
>> select IIO_BUFFER
>> select IIO_TRIGGERED_BUFFER
>> + select IRQ_WORK
>> help
>> Say Y here to build I2C interface support for the Atlas
>> Scientific OEM pH-SM sensor.
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-02-06 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 14:36 [PATCH] iio: chemical: select IRQ_WORK for ATLAS ph sensor Arnd Bergmann
2016-02-02 14:36 ` Arnd Bergmann
2016-02-03 7:55 ` Matt Ranostay
2016-02-03 7:55 ` Matt Ranostay
2016-02-06 18:38 ` Jonathan Cameron [this message]
2016-02-06 18:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B63DBE.8040507@kernel.org \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.