All of lore.kernel.org
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] Documentation: bindings: document the Alpine MSIX driver
Date: Mon, 8 Feb 2016 14:55:57 +0000	[thread overview]
Message-ID: <56B8AC7D.8060102@arm.com> (raw)
In-Reply-To: <1454922971-17405-3-git-send-email-antoine.tenart@free-electrons.com>

On 08/02/16 09:16, Antoine Tenart wrote:
> Following the addition of the Alpine MSIX driver, this patch adds the
> corresponding bindings documentation.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> Signed-off-by: Tsahee Zidenberg <tsahee@annapurnalabs.com>
> ---
>  .../interrupt-controller/al,alpine-msix.txt        | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt b/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> new file mode 100644
> index 000000000000..a77d5a76e8d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> @@ -0,0 +1,22 @@
> +Alpine MSIX controller
> +
> +Required properties:
> +
> +- compatible: should be "al,alpine-msix"
> +- reg: physical base address and size of the registers
> +- interrupt-controller: identifies the node as an interrupt controller
> +- msi-controller: identifies the node as an PCI Message Signaled Interrupt
> +		  controller
> +- al,msi-base-spi: SPI base of the MSI frame
> +- al,msi-num-spis: number of SPIs assigned to the MSI frame
> +
> +Example:
> +
> +msix: msix {
> +	compatible = "al,alpine-msix";
> +	reg = <0x0 0xfbe00000 0x0 0x100000>;
> +	interrupt-controller;
> +	msi-controller;
> +	al,msi-base-spi = <160>;
> +	al,msi-num-spis = <160>;
> +};
> 

This example seems to rely on an implicit interrupt-parent. You probably
want to update the example to clarify it.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>,
	tglx@linutronix.de, jason@lakedaemon.net,
	tsahee@annapurnalabs.com
Cc: rshitrit@annapurnalabs.com, thomas.petazzoni@free-electrons.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] Documentation: bindings: document the Alpine MSIX driver
Date: Mon, 8 Feb 2016 14:55:57 +0000	[thread overview]
Message-ID: <56B8AC7D.8060102@arm.com> (raw)
In-Reply-To: <1454922971-17405-3-git-send-email-antoine.tenart@free-electrons.com>

On 08/02/16 09:16, Antoine Tenart wrote:
> Following the addition of the Alpine MSIX driver, this patch adds the
> corresponding bindings documentation.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> Signed-off-by: Tsahee Zidenberg <tsahee@annapurnalabs.com>
> ---
>  .../interrupt-controller/al,alpine-msix.txt        | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt b/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> new file mode 100644
> index 000000000000..a77d5a76e8d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> @@ -0,0 +1,22 @@
> +Alpine MSIX controller
> +
> +Required properties:
> +
> +- compatible: should be "al,alpine-msix"
> +- reg: physical base address and size of the registers
> +- interrupt-controller: identifies the node as an interrupt controller
> +- msi-controller: identifies the node as an PCI Message Signaled Interrupt
> +		  controller
> +- al,msi-base-spi: SPI base of the MSI frame
> +- al,msi-num-spis: number of SPIs assigned to the MSI frame
> +
> +Example:
> +
> +msix: msix {
> +	compatible = "al,alpine-msix";
> +	reg = <0x0 0xfbe00000 0x0 0x100000>;
> +	interrupt-controller;
> +	msi-controller;
> +	al,msi-base-spi = <160>;
> +	al,msi-num-spis = <160>;
> +};
> 

This example seems to rely on an implicit interrupt-parent. You probably
want to update the example to clarify it.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2016-02-08 14:55 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08  9:16 [PATCH 0/6] irqchip: introduce the Alpine MSIX driver Antoine Tenart
2016-02-08  9:16 ` Antoine Tenart
2016-02-08  9:16 ` [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Antoine Tenart
2016-02-08  9:16   ` Antoine Tenart
2016-02-08  9:44   ` Marc Zyngier
2016-02-08  9:44     ` Marc Zyngier
2016-02-08  9:53     ` Thomas Petazzoni
2016-02-08  9:53       ` Thomas Petazzoni
2016-02-08 10:08       ` Marc Zyngier
2016-02-08 10:08         ` Marc Zyngier
2016-02-08 10:26     ` Antoine Tenart
2016-02-08 10:26       ` Antoine Tenart
2016-02-08 10:32       ` Marc Zyngier
2016-02-08 10:32         ` Marc Zyngier
2016-02-08 10:44         ` Antoine Tenart
2016-02-08 10:44           ` Antoine Tenart
2016-02-08 10:56           ` Marc Zyngier
2016-02-08 10:56             ` Marc Zyngier
2016-02-08 11:01             ` Antoine Tenart
2016-02-08 11:01               ` Antoine Tenart
2016-02-08 14:04     ` Antoine Tenart
2016-02-08 14:04       ` Antoine Tenart
2016-02-08 14:11       ` Marc Zyngier
2016-02-08 14:11         ` Marc Zyngier
2016-02-08 10:31   ` Thomas Gleixner
2016-02-08 10:31     ` Thomas Gleixner
2016-02-08 14:17     ` Antoine Tenart
2016-02-08 14:17       ` Antoine Tenart
2016-02-08 14:29       ` Marc Zyngier
2016-02-08 14:29         ` Marc Zyngier
2016-02-08 14:48         ` Antoine Tenart
2016-02-08 14:48           ` Antoine Tenart
2016-02-08 15:01           ` Marc Zyngier
2016-02-08 15:01             ` Marc Zyngier
2016-02-08  9:16 ` [PATCH 2/6] Documentation: bindings: document the Alpine MSIX driver Antoine Tenart
2016-02-08  9:16   ` Antoine Tenart
2016-02-08  9:16   ` Antoine Tenart
2016-02-08 14:55   ` Marc Zyngier [this message]
2016-02-08 14:55     ` Marc Zyngier
2016-02-08 15:05     ` Antoine Tenart
2016-02-08 15:05       ` Antoine Tenart
2016-02-08  9:16 ` [PATCH 3/6] arm64: dts: alpine: add the MSIX node in the Alpine v2 dtsi Antoine Tenart
2016-02-08  9:16   ` Antoine Tenart
2016-02-08  9:16 ` [PATCH 4/6] ARM: dts: alpine: add the MSIX node Antoine Tenart
2016-02-08  9:16   ` Antoine Tenart
2016-02-08  9:16 ` [PATCH 5/6] arm64: alpine: select the Alpine MSI controller driver Antoine Tenart
2016-02-08  9:16   ` Antoine Tenart
2016-02-08  9:16 ` [PATCH 6/6] arm: " Antoine Tenart
2016-02-08  9:16   ` Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B8AC7D.8060102@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.