* [PATCH] drm: fix missing reference counting decrease @ 2016-02-01 16:08 Insu Yun 2016-02-09 14:48 ` Harry Wentland 0 siblings, 1 reply; 4+ messages in thread From: Insu Yun @ 2016-02-01 16:08 UTC (permalink / raw) To: airlied, dri-devel, linux-kernel Cc: taesoo, yeongjin.jang, insu, changwoo, Insu Yun In drm_dp_mst_allocate_vcpi, it returns true in two paths, but in one path, there is no reference couting decrease. Signed-off-by: Insu Yun <wuninsu@gmail.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 6ed90a2..fe273b6 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -2446,6 +2446,7 @@ bool drm_dp_mst_allocate_vcpi(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp DRM_DEBUG_KMS("payload: vcpi %d already allocated for pbn %d - requested pbn %d\n", port->vcpi.vcpi, port->vcpi.pbn, pbn); if (pbn == port->vcpi.pbn) { *slots = port->vcpi.num_slots; + drm_dp_put_port(port); return true; } } -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: fix missing reference counting decrease 2016-02-01 16:08 [PATCH] drm: fix missing reference counting decrease Insu Yun @ 2016-02-09 14:48 ` Harry Wentland 0 siblings, 0 replies; 4+ messages in thread From: Harry Wentland @ 2016-02-09 14:48 UTC (permalink / raw) To: Insu Yun, airlied, dri-devel, linux-kernel Cc: yeongjin.jang, taesoo, insu, changwoo, Deucher, Alexander, Lysenko, Mykola [-- Attachment #1: Type: text/plain, Size: 1048 bytes --] This looks good but we should probably do the same for all return paths when reference for port has been acquired. Please see attached patch. Thanks, Harry On 2016-02-01 11:08 AM, Insu Yun wrote: > In drm_dp_mst_allocate_vcpi, it returns true in two paths, > but in one path, there is no reference couting decrease. > > Signed-off-by: Insu Yun <wuninsu@gmail.com> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 6ed90a2..fe273b6 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2446,6 +2446,7 @@ bool drm_dp_mst_allocate_vcpi(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp > DRM_DEBUG_KMS("payload: vcpi %d already allocated for pbn %d - requested pbn %d\n", port->vcpi.vcpi, port->vcpi.pbn, pbn); > if (pbn == port->vcpi.pbn) { > *slots = port->vcpi.num_slots; > + drm_dp_put_port(port); > return true; > } > } [-- Attachment #2: 0001-drm-dp-mst-Fix-missing-ref-count-decrease.patch --] [-- Type: text/x-patch, Size: 1441 bytes --] >From a6d4dc6206f06a3d1acc05ea5bf3b4885cc96a0a Mon Sep 17 00:00:00 2001 From: Harry Wentland <harry.wentland@amd.com> Date: Tue, 9 Feb 2016 09:33:11 -0500 Subject: [PATCH] drm/dp/mst: Fix missing ref count decrease Decrease ref count for port on all exit conditions. Signed-off-by: Harry Wentland <harry.wentland@amd.com> Reviewed-by: Mykola Lysenko <mykola.lysenko@amd.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 5662e68ecccd..fa50fd0cb5ef 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -2498,7 +2498,8 @@ bool drm_dp_mst_allocate_vcpi(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp DRM_DEBUG_KMS("payload: vcpi %d already allocated for pbn %d - requested pbn %d\n", port->vcpi.vcpi, port->vcpi.pbn, pbn); if (pbn == port->vcpi.pbn) { *slots = port->vcpi.num_slots; - return true; + ret = 0; + goto out; } } @@ -2510,10 +2511,10 @@ bool drm_dp_mst_allocate_vcpi(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp DRM_DEBUG_KMS("initing vcpi for %d %d\n", pbn, port->vcpi.num_slots); *slots = port->vcpi.num_slots; - drm_dp_put_port(port); - return true; + ret = 0; out: - return false; + drm_dp_put_port(port); + return ret == 0; } EXPORT_SYMBOL(drm_dp_mst_allocate_vcpi); -- 2.1.4 [-- Attachment #3: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: fix missing reference counting decrease @ 2016-02-09 14:48 ` Harry Wentland 0 siblings, 0 replies; 4+ messages in thread From: Harry Wentland @ 2016-02-09 14:48 UTC (permalink / raw) To: Insu Yun, airlied, dri-devel, linux-kernel Cc: yeongjin.jang, taesoo, insu, changwoo, Lysenko, Mykola, Deucher, Alexander [-- Attachment #1: Type: text/plain, Size: 1048 bytes --] This looks good but we should probably do the same for all return paths when reference for port has been acquired. Please see attached patch. Thanks, Harry On 2016-02-01 11:08 AM, Insu Yun wrote: > In drm_dp_mst_allocate_vcpi, it returns true in two paths, > but in one path, there is no reference couting decrease. > > Signed-off-by: Insu Yun <wuninsu@gmail.com> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 6ed90a2..fe273b6 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2446,6 +2446,7 @@ bool drm_dp_mst_allocate_vcpi(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp > DRM_DEBUG_KMS("payload: vcpi %d already allocated for pbn %d - requested pbn %d\n", port->vcpi.vcpi, port->vcpi.pbn, pbn); > if (pbn == port->vcpi.pbn) { > *slots = port->vcpi.num_slots; > + drm_dp_put_port(port); > return true; > } > } [-- Attachment #2: 0001-drm-dp-mst-Fix-missing-ref-count-decrease.patch --] [-- Type: text/x-patch, Size: 1441 bytes --] >From a6d4dc6206f06a3d1acc05ea5bf3b4885cc96a0a Mon Sep 17 00:00:00 2001 From: Harry Wentland <harry.wentland@amd.com> Date: Tue, 9 Feb 2016 09:33:11 -0500 Subject: [PATCH] drm/dp/mst: Fix missing ref count decrease Decrease ref count for port on all exit conditions. Signed-off-by: Harry Wentland <harry.wentland@amd.com> Reviewed-by: Mykola Lysenko <mykola.lysenko@amd.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 5662e68ecccd..fa50fd0cb5ef 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -2498,7 +2498,8 @@ bool drm_dp_mst_allocate_vcpi(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp DRM_DEBUG_KMS("payload: vcpi %d already allocated for pbn %d - requested pbn %d\n", port->vcpi.vcpi, port->vcpi.pbn, pbn); if (pbn == port->vcpi.pbn) { *slots = port->vcpi.num_slots; - return true; + ret = 0; + goto out; } } @@ -2510,10 +2511,10 @@ bool drm_dp_mst_allocate_vcpi(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp DRM_DEBUG_KMS("initing vcpi for %d %d\n", pbn, port->vcpi.num_slots); *slots = port->vcpi.num_slots; - drm_dp_put_port(port); - return true; + ret = 0; out: - return false; + drm_dp_put_port(port); + return ret == 0; } EXPORT_SYMBOL(drm_dp_mst_allocate_vcpi); -- 2.1.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: fix missing reference counting decrease 2016-02-09 14:48 ` Harry Wentland (?) @ 2016-02-09 16:07 ` Insu Yun -1 siblings, 0 replies; 4+ messages in thread From: Insu Yun @ 2016-02-09 16:07 UTC (permalink / raw) To: Harry Wentland Cc: Yeongjin Jang, Taesoo Kim, Yun, Insu, LKML, dri-devel, Lysenko, Mykola, Deucher, Alexander, Changwoo Min [-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --] For me, it is good :) On Tue, Feb 9, 2016 at 9:48 AM, Harry Wentland <harry.wentland@amd.com> wrote: > This looks good but we should probably do the same for all return paths > when reference for port has been acquired. > > Please see attached patch. > > Thanks, > Harry > > > On 2016-02-01 11:08 AM, Insu Yun wrote: > >> In drm_dp_mst_allocate_vcpi, it returns true in two paths, >> but in one path, there is no reference couting decrease. >> >> Signed-off-by: Insu Yun <wuninsu@gmail.com> >> --- >> drivers/gpu/drm/drm_dp_mst_topology.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c >> b/drivers/gpu/drm/drm_dp_mst_topology.c >> index 6ed90a2..fe273b6 100644 >> --- a/drivers/gpu/drm/drm_dp_mst_topology.c >> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c >> @@ -2446,6 +2446,7 @@ bool drm_dp_mst_allocate_vcpi(struct >> drm_dp_mst_topology_mgr *mgr, struct drm_dp >> DRM_DEBUG_KMS("payload: vcpi %d already allocated for pbn >> %d - requested pbn %d\n", port->vcpi.vcpi, port->vcpi.pbn, pbn); >> if (pbn == port->vcpi.pbn) { >> *slots = port->vcpi.num_slots; >> + drm_dp_put_port(port); >> return true; >> } >> } >> > > -- Regards Insu Yun [-- Attachment #1.2: Type: text/html, Size: 2083 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-09 16:22 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-01 16:08 [PATCH] drm: fix missing reference counting decrease Insu Yun 2016-02-09 14:48 ` Harry Wentland 2016-02-09 14:48 ` Harry Wentland 2016-02-09 16:07 ` Insu Yun
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.