All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Juri Lelli <juri.lelli@arm.com>,
	Vincent Guittot <vincent.guittot@linaro.org>
Cc: Morten Rasmussen <morten.rasmussen@arm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	LAK <linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Mark Brown <broonie@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH v3 2/6] drivers/cpufreq: implement init_cpu_capacity_default()
Date: Tue, 9 Feb 2016 15:54:50 +0000	[thread overview]
Message-ID: <56BA0BCA.6090903@arm.com> (raw)
In-Reply-To: <20160205093040.GG29586@e106622-lin>

On 05/02/16 09:30, Juri Lelli wrote:
> On 04/02/16 16:46, Vincent Guittot wrote:
>> On 4 February 2016 at 16:44, Vincent Guittot <vincent.guittot@linaro.org> wrote:
>>> On 4 February 2016 at 15:13, Juri Lelli <juri.lelli@arm.com> wrote:
>>>> On 04/02/16 13:35, Vincent Guittot wrote:
>>>>> On 4 February 2016 at 13:16, Juri Lelli <juri.lelli@arm.com> wrote:
>>>>>> Hi Vincent,
>>>>>>
>>>>>> On 04/02/16 13:03, Vincent Guittot wrote:
>>>>>>> On 4 February 2016 at 10:36, Morten Rasmussen <morten.rasmussen@arm.com> wrote:
>>>>>>>> On Wed, Feb 03, 2016 at 10:04:37PM +0100, Vincent Guittot wrote:
>>>>>>>>> On 3 February 2016 at 12:59, Juri Lelli <juri.lelli@arm.com> wrote:

[...]

>>>
>>> AFAICT, They don't have a dedicated cpufreq driver.
>>>
>>> More generally speaking, it can take time before having
>>
>> email sent before the ne d of the sentence ...
>>
>> More generally speaking, it can take time before having a cpufreq
>> driver whereas we want to run and test scheduler behavior of these
>> heterogenous platform
>>
> 
> I'm not familiar with this platform, but from what you are saying and
> what I could find online, it looks like full Linux support is not
> finished yet. Can we consider that as still in development? And if we
> can do that, maybe is fair enough that we use the sysfs interface to
> play with that platform until support is complete.
> 
> Do others have any opinion on this point?

IMHO, the solution should work for all of heterogeneous systems, (a) w/
cpufreq and driver, (b) w/ cpufreq and no driver loaded (yet) or (c) w/o
cpufreq.

That means that you can't put the benchmarking only into
cpufreq_register_driver() and rely on cpufreq policy topology.

Maybe you could do this for (b) and (c) inside an initcall and use
topology_core_cpumask() to figure out which cpu to profile?

This would then happen w/ the cpu frequency set by the fw.

But this then has to be synchronized somehow with the benchmarking
approach in cpufreq_register_driver().

[...]

WARNING: multiple messages have this Message-ID (diff)
From: dietmar.eggemann@arm.com (Dietmar Eggemann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/6] drivers/cpufreq: implement init_cpu_capacity_default()
Date: Tue, 9 Feb 2016 15:54:50 +0000	[thread overview]
Message-ID: <56BA0BCA.6090903@arm.com> (raw)
In-Reply-To: <20160205093040.GG29586@e106622-lin>

On 05/02/16 09:30, Juri Lelli wrote:
> On 04/02/16 16:46, Vincent Guittot wrote:
>> On 4 February 2016 at 16:44, Vincent Guittot <vincent.guittot@linaro.org> wrote:
>>> On 4 February 2016 at 15:13, Juri Lelli <juri.lelli@arm.com> wrote:
>>>> On 04/02/16 13:35, Vincent Guittot wrote:
>>>>> On 4 February 2016 at 13:16, Juri Lelli <juri.lelli@arm.com> wrote:
>>>>>> Hi Vincent,
>>>>>>
>>>>>> On 04/02/16 13:03, Vincent Guittot wrote:
>>>>>>> On 4 February 2016 at 10:36, Morten Rasmussen <morten.rasmussen@arm.com> wrote:
>>>>>>>> On Wed, Feb 03, 2016 at 10:04:37PM +0100, Vincent Guittot wrote:
>>>>>>>>> On 3 February 2016 at 12:59, Juri Lelli <juri.lelli@arm.com> wrote:

[...]

>>>
>>> AFAICT, They don't have a dedicated cpufreq driver.
>>>
>>> More generally speaking, it can take time before having
>>
>> email sent before the ne d of the sentence ...
>>
>> More generally speaking, it can take time before having a cpufreq
>> driver whereas we want to run and test scheduler behavior of these
>> heterogenous platform
>>
> 
> I'm not familiar with this platform, but from what you are saying and
> what I could find online, it looks like full Linux support is not
> finished yet. Can we consider that as still in development? And if we
> can do that, maybe is fair enough that we use the sysfs interface to
> play with that platform until support is complete.
> 
> Do others have any opinion on this point?

IMHO, the solution should work for all of heterogeneous systems, (a) w/
cpufreq and driver, (b) w/ cpufreq and no driver loaded (yet) or (c) w/o
cpufreq.

That means that you can't put the benchmarking only into
cpufreq_register_driver() and rely on cpufreq policy topology.

Maybe you could do this for (b) and (c) inside an initcall and use
topology_core_cpumask() to figure out which cpu to profile?

This would then happen w/ the cpu frequency set by the fw.

But this then has to be synchronized somehow with the benchmarking
approach in cpufreq_register_driver().

[...]

  reply	other threads:[~2016-02-09 15:54 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 11:59 [PATCH v3 0/6] CPUs capacity information for heterogeneous systems Juri Lelli
2016-02-03 11:59 ` Juri Lelli
2016-02-03 11:59 ` [PATCH v3 1/6] ARM: initialize cpu_scale to its default Juri Lelli
2016-02-03 11:59   ` Juri Lelli
2016-02-03 11:59 ` [PATCH v3 2/6] drivers/cpufreq: implement init_cpu_capacity_default() Juri Lelli
2016-02-03 11:59   ` Juri Lelli
2016-02-03 21:04   ` Vincent Guittot
2016-02-03 21:04     ` Vincent Guittot
2016-02-04  9:36     ` Morten Rasmussen
2016-02-04  9:36       ` Morten Rasmussen
2016-02-04 12:03       ` Vincent Guittot
2016-02-04 12:03         ` Vincent Guittot
     [not found]         ` <CAKfTPtB4G3bP5N0hU6zWXJTddO34x3RnyGpp-4_otc8O=Wq2hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-04 12:16           ` Juri Lelli
2016-02-04 12:16             ` Juri Lelli
2016-02-04 12:16             ` Juri Lelli
2016-02-04 12:35             ` Vincent Guittot
2016-02-04 12:35               ` Vincent Guittot
2016-02-04 14:13               ` Juri Lelli
2016-02-04 14:13                 ` Juri Lelli
2016-02-04 15:44                 ` Vincent Guittot
2016-02-04 15:44                   ` Vincent Guittot
2016-02-04 15:46                   ` Vincent Guittot
2016-02-04 15:46                     ` Vincent Guittot
     [not found]                     ` <CAKfTPtD4jTmUZoShGBm3oAFywizjp8jsEukmkeZU+x+zk-KZRA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-05  9:30                       ` Juri Lelli
2016-02-05  9:30                         ` Juri Lelli
2016-02-05  9:30                         ` Juri Lelli
2016-02-09 15:54                         ` Dietmar Eggemann [this message]
2016-02-09 15:54                           ` Dietmar Eggemann
     [not found]                           ` <56BA0BCA.6090903-5wv7dgnIgG8@public.gmane.org>
2016-02-10 14:25                             ` Juri Lelli
2016-02-10 14:25                               ` Juri Lelli
2016-02-10 14:25                               ` Juri Lelli
2016-02-03 11:59 ` [PATCH v3 3/6] arm: Enable dynamic CPU capacity initialization Juri Lelli
2016-02-03 11:59   ` Juri Lelli
2016-02-03 11:59   ` Juri Lelli
2016-02-03 11:59 ` [PATCH v3 4/6] arm64: " Juri Lelli
2016-02-03 11:59   ` Juri Lelli
2016-02-08 12:28   ` Dietmar Eggemann
2016-02-08 12:28     ` Dietmar Eggemann
     [not found]     ` <56B889F7.306-5wv7dgnIgG8@public.gmane.org>
2016-02-08 13:13       ` Mark Brown
2016-02-08 13:13         ` Mark Brown
2016-02-08 13:13         ` Mark Brown
2016-02-08 13:41         ` Dietmar Eggemann
2016-02-08 13:41           ` Dietmar Eggemann
2016-02-03 11:59 ` [PATCH v3 5/6] arm: add sysfs cpu_capacity attribute Juri Lelli
2016-02-03 11:59   ` Juri Lelli
2016-02-03 11:59 ` [PATCH v3 6/6] arm64: " Juri Lelli
2016-02-03 11:59   ` Juri Lelli
2016-02-05 17:19   ` Dietmar Eggemann
2016-02-05 17:19     ` Dietmar Eggemann
     [not found]     ` <56B4D98F.3090103-5wv7dgnIgG8@public.gmane.org>
2016-02-05 17:49       ` Juri Lelli
2016-02-05 17:49         ` Juri Lelli
2016-02-05 17:49         ` Juri Lelli
     [not found] ` <1454500799-18451-1-git-send-email-juri.lelli-5wv7dgnIgG8@public.gmane.org>
2016-02-08 23:59   ` [PATCH v3 0/6] CPUs capacity information for heterogeneous systems Steve Muckle
2016-02-08 23:59     ` Steve Muckle
2016-02-08 23:59     ` Steve Muckle
     [not found]     ` <56B92BF4.4030405-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-09 10:37       ` Juri Lelli
2016-02-09 10:37         ` Juri Lelli
2016-02-09 10:37         ` Juri Lelli
2016-02-09 17:30         ` Steve Muckle
2016-02-09 17:30           ` Steve Muckle
2016-02-09 17:40           ` Juri Lelli
2016-02-09 17:40             ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BA0BCA.6090903@arm.com \
    --to=dietmar.eggemann@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=juri.lelli@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.