From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h
Date: Tue, 9 Feb 2016 17:06:47 +0100 [thread overview]
Message-ID: <56BA0E97.7060002@redhat.com> (raw)
In-Reply-To: <56BA0DBD.3060206@weilnetz.de>
On 09/02/2016 17:03, Stefan Weil wrote:
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> Without that patch, windows.h will include winsock.h
> (which conflicts with winsock2.h) when compiling sdl.c.
>
> Normally we define WIN32_LEAN_AND_MEAN, and
> windows.h won't include winsock.h.
>
> include/ui/sdl2.h and ui/sdl.c undefine that macro,
> so the order of the include files is important.
>
> Without testing this, I think that Paolo's patch is needed
> since commit e16f4c8770b73f530dad842a31298963b6c7e41d.
>
That also explains why only that file complains. Thanks!
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h
Date: Tue, 9 Feb 2016 17:06:47 +0100 [thread overview]
Message-ID: <56BA0E97.7060002@redhat.com> (raw)
In-Reply-To: <56BA0DBD.3060206@weilnetz.de>
On 09/02/2016 17:03, Stefan Weil wrote:
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> Without that patch, windows.h will include winsock.h
> (which conflicts with winsock2.h) when compiling sdl.c.
>
> Normally we define WIN32_LEAN_AND_MEAN, and
> windows.h won't include winsock.h.
>
> include/ui/sdl2.h and ui/sdl.c undefine that macro,
> so the order of the include files is important.
>
> Without testing this, I think that Paolo's patch is needed
> since commit e16f4c8770b73f530dad842a31298963b6c7e41d.
>
That also explains why only that file complains. Thanks!
Paolo
next prev parent reply other threads:[~2016-02-09 16:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 14:16 [Qemu-trivial] [PATCH] w32: include winsock2.h before windows.h Paolo Bonzini
2016-02-09 14:16 ` [Qemu-devel] " Paolo Bonzini
2016-02-09 14:21 ` [Qemu-trivial] " Daniel P. Berrange
2016-02-09 14:21 ` Daniel P. Berrange
2016-02-09 14:28 ` [Qemu-trivial] " Peter Maydell
2016-02-09 14:28 ` Peter Maydell
2016-02-09 14:37 ` [Qemu-trivial] " Paolo Bonzini
2016-02-09 14:37 ` [Qemu-devel] " Paolo Bonzini
2016-02-09 14:38 ` [Qemu-trivial] " Peter Maydell
2016-02-09 14:38 ` [Qemu-devel] " Peter Maydell
2016-02-09 16:03 ` [Qemu-trivial] " Stefan Weil
2016-02-09 16:03 ` Stefan Weil
2016-02-09 16:06 ` Paolo Bonzini [this message]
2016-02-09 16:06 ` Paolo Bonzini
2016-02-11 5:56 ` [Qemu-trivial] " Michael Tokarev
2016-02-11 5:56 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA0E97.7060002@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.