From: robin.murphy@arm.com (Robin Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base
Date: Tue, 9 Feb 2016 16:17:33 +0000 [thread overview]
Message-ID: <56BA111D.9050807@arm.com> (raw)
In-Reply-To: <20160209160812.GC9332@leverpostej>
On 09/02/16 16:08, Mark Rutland wrote:
[...]
>>>> having msi-map-mask clash with a nonzero rid-base, as that's another
>>>> thing one can easily get wrong.
[...]
>>>> + if (rid_base & ~map_mask) {
>>>> + dev_err(parent_dev,
>>>> + "Invalid msi-map translation - msi-map-mask (0x%x) ignores rid-
>>> base (0x%x)\n",
>>>> + map_mask, rid_base);
>>>> + return rid_out;
>>>> + }
[...]
>> msi-map = <0x0100 &its 0x11 0x1>;
>> msi-map-mask = <0xff>;
>>
>
> I'd say that this is an inconsistent set of properties, and it's
> probably worth warning if we encounter this. There is no possible way
> that rid-base can be encountered.
Indeed ;)
Robin.
> Thanks,
> Mark.
>
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Mark Rutland <mark.rutland@arm.com>, Stuart Yoder <stuart.yoder@nxp.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"frowand.list@gmail.com" <frowand.list@gmail.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"david.daney@cavium.com" <david.daney@cavium.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base
Date: Tue, 9 Feb 2016 16:17:33 +0000 [thread overview]
Message-ID: <56BA111D.9050807@arm.com> (raw)
In-Reply-To: <20160209160812.GC9332@leverpostej>
On 09/02/16 16:08, Mark Rutland wrote:
[...]
>>>> having msi-map-mask clash with a nonzero rid-base, as that's another
>>>> thing one can easily get wrong.
[...]
>>>> + if (rid_base & ~map_mask) {
>>>> + dev_err(parent_dev,
>>>> + "Invalid msi-map translation - msi-map-mask (0x%x) ignores rid-
>>> base (0x%x)\n",
>>>> + map_mask, rid_base);
>>>> + return rid_out;
>>>> + }
[...]
>> msi-map = <0x0100 &its 0x11 0x1>;
>> msi-map-mask = <0xff>;
>>
>
> I'd say that this is an inconsistent set of properties, and it's
> probably worth warning if we encounter this. There is no possible way
> that rid-base can be encountered.
Indeed ;)
Robin.
> Thanks,
> Mark.
>
next prev parent reply other threads:[~2016-02-09 16:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 11:04 [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Robin Murphy
2016-02-09 11:04 ` Robin Murphy
2016-02-09 12:06 ` Marc Zyngier
2016-02-09 12:06 ` Marc Zyngier
2016-02-09 15:56 ` Stuart Yoder
2016-02-09 15:56 ` Stuart Yoder
2016-02-09 15:56 ` Stuart Yoder
2016-02-09 16:08 ` Mark Rutland
2016-02-09 16:08 ` Mark Rutland
2016-02-09 16:17 ` Robin Murphy [this message]
2016-02-09 16:17 ` Robin Murphy
2016-02-09 18:19 ` Mark Rutland
2016-02-09 18:19 ` Mark Rutland
2016-02-09 16:53 ` Stuart Yoder
2016-02-09 16:53 ` Stuart Yoder
2016-02-09 17:03 ` David Daney
2016-02-09 17:03 ` David Daney
2016-02-09 17:03 ` David Daney
2016-02-09 18:12 ` Stuart Yoder
2016-02-09 18:12 ` Stuart Yoder
2016-02-09 18:12 ` Stuart Yoder
2016-02-11 11:04 ` Marc Zyngier
2016-02-11 11:04 ` Marc Zyngier
2016-02-11 18:10 ` Frank Rowand
2016-02-11 18:10 ` Frank Rowand
2016-02-11 23:15 ` Rob Herring
2016-02-11 23:15 ` Rob Herring
2016-02-11 23:15 ` Rob Herring
2016-02-12 8:32 ` Marc Zyngier
2016-02-12 8:32 ` Marc Zyngier
2016-02-12 8:32 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA111D.9050807@arm.com \
--to=robin.murphy@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.