All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <info-saaNCTdWVBT7BZbvpMY5sg@public.gmane.org>
To: stephanolbrich-Mmb7MZpHnFY@public.gmane.org,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 4/4] spi: bcm2835aux: fix CPOL/CPHA setting
Date: Tue, 9 Feb 2016 21:21:15 +0100	[thread overview]
Message-ID: <56BA4A3B.3090605@lategoodbye.de> (raw)
In-Reply-To: <1455041435-8015-5-git-send-email-stephanolbrich-Mmb7MZpHnFY@public.gmane.org>

Hi Stephan,

Am 09.02.2016 um 19:10 schrieb stephanolbrich-Mmb7MZpHnFY@public.gmane.org:
> From: Stephan Olbrich <stephanolbrich-Mmb7MZpHnFY@public.gmane.org>
>
> The auxiliary spi supports only CPHA=0 modes as the first bit is
> always output to the pin before the first clock cycle. In CPHA=1
> modes the first clock edge outputs the second bit hence the slave
> can never read the first bit.

in case auxiliary spi isn't able to handle all modes shouldn't we report 
this to the upper layers?

Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: info@lategoodbye.de (Stefan Wahren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] spi: bcm2835aux: fix CPOL/CPHA setting
Date: Tue, 9 Feb 2016 21:21:15 +0100	[thread overview]
Message-ID: <56BA4A3B.3090605@lategoodbye.de> (raw)
In-Reply-To: <1455041435-8015-5-git-send-email-stephanolbrich@gmx.de>

Hi Stephan,

Am 09.02.2016 um 19:10 schrieb stephanolbrich at gmx.de:
> From: Stephan Olbrich <stephanolbrich@gmx.de>
>
> The auxiliary spi supports only CPHA=0 modes as the first bit is
> always output to the pin before the first clock cycle. In CPHA=1
> modes the first clock edge outputs the second bit hence the slave
> can never read the first bit.

in case auxiliary spi isn't able to handle all modes shouldn't we report 
this to the upper layers?

Regards

  parent reply	other threads:[~2016-02-09 20:21 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 18:10 [PATCH 0/4] spi: bcm2835aux: auxiliary spi improvements stephanolbrich-Mmb7MZpHnFY
2016-02-09 18:10 ` stephanolbrich at gmx.de
     [not found] ` <1455041435-8015-1-git-send-email-stephanolbrich-Mmb7MZpHnFY@public.gmane.org>
2016-02-09 18:10   ` [PATCH 1/4] spi: bcm2835aux: fix bitmask defines stephanolbrich-Mmb7MZpHnFY
2016-02-09 18:10     ` stephanolbrich at gmx.de
     [not found]     ` <1455041435-8015-2-git-send-email-stephanolbrich-Mmb7MZpHnFY@public.gmane.org>
2016-02-09 19:54       ` Stefan Wahren
2016-02-09 19:54         ` Stefan Wahren
     [not found]         ` <56BA43DB.7030209-saaNCTdWVBT7BZbvpMY5sg@public.gmane.org>
2016-02-10 20:08           ` Stephan Olbrich
2016-02-10 20:08             ` Stephan Olbrich
2016-02-09 23:44       ` Eric Anholt
2016-02-09 23:44         ` Eric Anholt
2016-02-10 12:55       ` Applied "spi: bcm2835aux: fix bitmask defines" to the spi tree Mark Brown
2016-02-09 18:10   ` [PATCH 2/4] spi: bcm2835aux: disable tx fifo empty irq stephanolbrich-Mmb7MZpHnFY
2016-02-09 18:10     ` stephanolbrich at gmx.de
     [not found]     ` <1455041435-8015-3-git-send-email-stephanolbrich-Mmb7MZpHnFY@public.gmane.org>
2016-02-09 23:45       ` Eric Anholt
2016-02-09 23:45         ` Eric Anholt
2016-02-10 19:22       ` Applied "spi: bcm2835aux: disable tx fifo empty irq" to the spi tree Mark Brown
2016-02-09 18:10   ` [PATCH 3/4] spi: bcm2835aux: set up spi-mode before asserting cs-gpio stephanolbrich-Mmb7MZpHnFY
2016-02-09 18:10     ` stephanolbrich at gmx.de
     [not found]     ` <1455041435-8015-4-git-send-email-stephanolbrich-Mmb7MZpHnFY@public.gmane.org>
2016-02-09 23:49       ` Eric Anholt
2016-02-09 23:49         ` Eric Anholt
     [not found]         ` <87d1s54f7f.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2016-02-10  8:01           ` Mark Brown
2016-02-10  8:01             ` Mark Brown
     [not found]             ` <20160210080149.GQ13270-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-10 18:59               ` Eric Anholt
2016-02-10 18:59                 ` Eric Anholt
     [not found]                 ` <878u2s2xym.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2016-02-10 19:02                   ` Mark Brown
2016-02-10 19:02                     ` Mark Brown
     [not found]                     ` <20160210190204.GD13270-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-10 20:26                       ` Stephan Olbrich
2016-02-10 20:26                         ` Stephan Olbrich
2016-02-10 23:19                         ` Martin Sperl
2016-02-10 23:19                           ` Martin Sperl
2016-02-11 12:27                         ` Mark Brown
2016-02-11 12:27                           ` Mark Brown
2016-02-11 18:06       ` Martin Sperl
2016-02-11 18:06         ` Martin Sperl
2016-02-09 18:10   ` [PATCH 4/4] spi: bcm2835aux: fix CPOL/CPHA setting stephanolbrich-Mmb7MZpHnFY
2016-02-09 18:10     ` stephanolbrich at gmx.de
     [not found]     ` <1455041435-8015-5-git-send-email-stephanolbrich-Mmb7MZpHnFY@public.gmane.org>
2016-02-09 20:21       ` Stefan Wahren [this message]
2016-02-09 20:21         ` Stefan Wahren
2016-02-10  0:13       ` Eric Anholt
2016-02-10  0:13         ` Eric Anholt
     [not found]         ` <87a8n94e3x.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2016-02-10 20:45           ` Stephan Olbrich
2016-02-10 20:45             ` Stephan Olbrich
2016-02-10 21:24             ` Eric Anholt
2016-02-10 21:24               ` Eric Anholt
2016-02-11 15:25           ` Martin Sperl
2016-02-11 15:25             ` Martin Sperl
     [not found]             ` <16A848EA-6E08-48C4-B3DD-DF27333B7458-d5rIkyn9cnPYtjvyW6yDsg@public.gmane.org>
2016-02-11 16:05               ` Stephan Olbrich
2016-02-11 16:05                 ` Stephan Olbrich
2016-02-11 16:19                 ` Martin Sperl
2016-02-11 16:19                   ` Martin Sperl
     [not found]                   ` <50D0ECA7-8116-4248-AC85-6E1C8002A185-d5rIkyn9cnPYtjvyW6yDsg@public.gmane.org>
2016-02-11 18:44                     ` Martin Sperl
2016-02-11 18:44                       ` Martin Sperl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BA4A3B.3090605@lategoodbye.de \
    --to=info-saanctdwvbt7bzbvpmy5sg@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \
    --cc=lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stephanolbrich-Mmb7MZpHnFY@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.