All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: fixes when i2c encoder slave mode_fixup is null.
@ 2016-02-10 12:08 Carlos Palminha
  2016-02-10 12:25 ` Daniel Vetter
  0 siblings, 1 reply; 4+ messages in thread
From: Carlos Palminha @ 2016-02-10 12:08 UTC (permalink / raw)
  To: dri-devel, Daniel Vetter, Lars-Peter Clausen, Laurent Pinchart
  Cc: CARLOS.PALMINHA

Avoid i2c slave encoder drivers to copy/paste code to implement functions that will
only return true.

Signed-off-by: Carlos Palminha <palminha@synopsys.com>
---
 drivers/gpu/drm/drm_encoder_slave.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_encoder_slave.c b/drivers/gpu/drm/drm_encoder_slave.c
index e862907..418b94c 100644
--- a/drivers/gpu/drm/drm_encoder_slave.c
+++ b/drivers/gpu/drm/drm_encoder_slave.c
@@ -140,6 +140,8 @@ bool drm_i2c_encoder_mode_fixup(struct drm_encoder *encoder,
 		const struct drm_display_mode *mode,
 		struct drm_display_mode *adjusted_mode)
 {
+	if(!get_slave_funcs(encoder)->mode_fixup)
+		return true;
 	return get_slave_funcs(encoder)->mode_fixup(encoder, mode, adjusted_mode);
 }
 EXPORT_SYMBOL(drm_i2c_encoder_mode_fixup);
--
2.5.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm: fixes when i2c encoder slave mode_fixup is null.
  2016-02-10 12:08 [PATCH] drm: fixes when i2c encoder slave mode_fixup is null Carlos Palminha
@ 2016-02-10 12:25 ` Daniel Vetter
  2016-02-10 12:28   ` Carlos Palminha
  2016-02-10 14:05   ` Jani Nikula
  0 siblings, 2 replies; 4+ messages in thread
From: Daniel Vetter @ 2016-02-10 12:25 UTC (permalink / raw)
  To: Carlos Palminha; +Cc: Daniel Vetter, Laurent Pinchart, dri-devel

On Wed, Feb 10, 2016 at 12:08:38PM +0000, Carlos Palminha wrote:
> Avoid i2c slave encoder drivers to copy/paste code to implement functions that will
> only return true.
> 
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>

lgtm, applied to drm-misc. sil164_drv.c seems to have a dummy mode_fixup
function that's now uneeded. Can you pls follow up with a patch to remove
that one?

Thanks, Daniel

> ---
>  drivers/gpu/drm/drm_encoder_slave.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_encoder_slave.c b/drivers/gpu/drm/drm_encoder_slave.c
> index e862907..418b94c 100644
> --- a/drivers/gpu/drm/drm_encoder_slave.c
> +++ b/drivers/gpu/drm/drm_encoder_slave.c
> @@ -140,6 +140,8 @@ bool drm_i2c_encoder_mode_fixup(struct drm_encoder *encoder,
>  		const struct drm_display_mode *mode,
>  		struct drm_display_mode *adjusted_mode)
>  {
> +	if(!get_slave_funcs(encoder)->mode_fixup)
> +		return true;
>  	return get_slave_funcs(encoder)->mode_fixup(encoder, mode, adjusted_mode);
>  }
>  EXPORT_SYMBOL(drm_i2c_encoder_mode_fixup);
> --
> 2.5.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm: fixes when i2c encoder slave mode_fixup is null.
  2016-02-10 12:25 ` Daniel Vetter
@ 2016-02-10 12:28   ` Carlos Palminha
  2016-02-10 14:05   ` Jani Nikula
  1 sibling, 0 replies; 4+ messages in thread
From: Carlos Palminha @ 2016-02-10 12:28 UTC (permalink / raw)
  To: Daniel Vetter, Carlos Palminha; +Cc: Daniel Vetter, Laurent Pinchart, dri-devel

thanks daniel.

I'll check all i2c slave encoders and submit a patch set.

On 10-02-2016 12:25, Daniel Vetter wrote:
> On Wed, Feb 10, 2016 at 12:08:38PM +0000, Carlos Palminha wrote:
>> Avoid i2c slave encoder drivers to copy/paste code to implement functions that will
>> only return true.
>>
>> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
>
> lgtm, applied to drm-misc. sil164_drv.c seems to have a dummy mode_fixup
> function that's now uneeded. Can you pls follow up with a patch to remove
> that one?
>
> Thanks, Daniel
>
>> ---
>>   drivers/gpu/drm/drm_encoder_slave.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_encoder_slave.c b/drivers/gpu/drm/drm_encoder_slave.c
>> index e862907..418b94c 100644
>> --- a/drivers/gpu/drm/drm_encoder_slave.c
>> +++ b/drivers/gpu/drm/drm_encoder_slave.c
>> @@ -140,6 +140,8 @@ bool drm_i2c_encoder_mode_fixup(struct drm_encoder *encoder,
>>   		const struct drm_display_mode *mode,
>>   		struct drm_display_mode *adjusted_mode)
>>   {
>> +	if(!get_slave_funcs(encoder)->mode_fixup)
>> +		return true;
>>   	return get_slave_funcs(encoder)->mode_fixup(encoder, mode, adjusted_mode);
>>   }
>>   EXPORT_SYMBOL(drm_i2c_encoder_mode_fixup);
>> --
>> 2.5.0
>>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm: fixes when i2c encoder slave mode_fixup is null.
  2016-02-10 12:25 ` Daniel Vetter
  2016-02-10 12:28   ` Carlos Palminha
@ 2016-02-10 14:05   ` Jani Nikula
  1 sibling, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-02-10 14:05 UTC (permalink / raw)
  To: Daniel Vetter, Carlos Palminha; +Cc: Daniel Vetter, Laurent Pinchart, dri-devel

On Wed, 10 Feb 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Feb 10, 2016 at 12:08:38PM +0000, Carlos Palminha wrote:
>> Avoid i2c slave encoder drivers to copy/paste code to implement functions that will
>> only return true.
>> 
>> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
>
> lgtm, applied to drm-misc. sil164_drv.c seems to have a dummy mode_fixup
> function that's now uneeded. Can you pls follow up with a patch to remove
> that one?
>
> Thanks, Daniel
>
>> ---
>>  drivers/gpu/drm/drm_encoder_slave.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/gpu/drm/drm_encoder_slave.c b/drivers/gpu/drm/drm_encoder_slave.c
>> index e862907..418b94c 100644
>> --- a/drivers/gpu/drm/drm_encoder_slave.c
>> +++ b/drivers/gpu/drm/drm_encoder_slave.c
>> @@ -140,6 +140,8 @@ bool drm_i2c_encoder_mode_fixup(struct drm_encoder *encoder,
>>  		const struct drm_display_mode *mode,
>>  		struct drm_display_mode *adjusted_mode)
>>  {
>> +	if(!get_slave_funcs(encoder)->mode_fixup)
          ^

Please apply an ocd-space there. ;)

BR,
Jani.



>> +		return true;
>>  	return get_slave_funcs(encoder)->mode_fixup(encoder, mode, adjusted_mode);
>>  }
>>  EXPORT_SYMBOL(drm_i2c_encoder_mode_fixup);
>> --
>> 2.5.0
>> 

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-10 14:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 12:08 [PATCH] drm: fixes when i2c encoder slave mode_fixup is null Carlos Palminha
2016-02-10 12:25 ` Daniel Vetter
2016-02-10 12:28   ` Carlos Palminha
2016-02-10 14:05   ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.