From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: Provide MACRO to declare commonly defined MFD cell attributes
Date: Wed, 10 Feb 2016 18:08:49 +0530 [thread overview]
Message-ID: <56BB2F59.9030702@nvidia.com> (raw)
In-Reply-To: <1455028027-1527-1-git-send-email-lee.jones@linaro.org>
On Tuesday 09 February 2016 07:57 PM, Lee Jones wrote:
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> include/linux/mfd/core.h | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index 27dac3f..dacdc49 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -16,6 +16,38 @@
>
> #include <linux/platform_device.h>
>
> +#define MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, _match) \
> + { \
> + .name = (_name), \
> + .num_resources = ARRAY_SIZE((_res)), \
> + .resources = (_res), \
> + .platform_data = (_pdata), \
> + .pdata_size = ARRAY_SIZE((_pdata)), \
> + .of_compatible = (_compat), \
> + .acpi_match = (_match), \
> + .id = _id, \
> + }
>
Should we add the _res_size and _pdata_size also in argument and use
them instead of ARRA_SIZE and lets client set the size with help of
ARRAY_SIZE based on type of data?
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Lee Jones <lee.jones@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: Provide MACRO to declare commonly defined MFD cell attributes
Date: Wed, 10 Feb 2016 18:08:49 +0530 [thread overview]
Message-ID: <56BB2F59.9030702@nvidia.com> (raw)
In-Reply-To: <1455028027-1527-1-git-send-email-lee.jones@linaro.org>
On Tuesday 09 February 2016 07:57 PM, Lee Jones wrote:
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> include/linux/mfd/core.h | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index 27dac3f..dacdc49 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -16,6 +16,38 @@
>
> #include <linux/platform_device.h>
>
> +#define MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, _match) \
> + { \
> + .name = (_name), \
> + .num_resources = ARRAY_SIZE((_res)), \
> + .resources = (_res), \
> + .platform_data = (_pdata), \
> + .pdata_size = ARRAY_SIZE((_pdata)), \
> + .of_compatible = (_compat), \
> + .acpi_match = (_match), \
> + .id = _id, \
> + }
>
Should we add the _res_size and _pdata_size also in argument and use
them instead of ARRA_SIZE and lets client set the size with help of
ARRAY_SIZE based on type of data?
next prev parent reply other threads:[~2016-02-10 12:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 14:27 [PATCH] mfd: Provide MACRO to declare commonly defined MFD cell attributes Lee Jones
2016-02-09 14:27 ` Lee Jones
2016-02-09 15:20 ` Laxman Dewangan
2016-02-09 15:20 ` Laxman Dewangan
2016-02-10 12:38 ` Laxman Dewangan [this message]
2016-02-10 12:38 ` Laxman Dewangan
2016-02-10 15:38 ` [PATCH v2] " Lee Jones
2016-02-10 15:38 ` Lee Jones
2016-02-10 17:50 ` Laxman Dewangan
2016-02-10 17:50 ` Laxman Dewangan
2016-02-11 9:10 ` Lee Jones
2016-02-11 9:10 ` Lee Jones
2016-02-11 9:01 ` Laxman Dewangan
2016-02-11 9:01 ` Laxman Dewangan
2016-02-11 9:46 ` Lee Jones
2016-02-11 9:46 ` Lee Jones
2016-02-26 10:43 ` Andy Shevchenko
2016-02-26 10:43 ` Andy Shevchenko
2016-02-10 15:39 ` [PATCH v2] mfd: ab8500: Provide a small example using new MFD cell MACROs Lee Jones
2016-02-10 15:39 ` Lee Jones
2016-02-15 9:58 ` Linus Walleij
2016-02-15 9:58 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BB2F59.9030702@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.