All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 6/9] ARC: clocksource: DT based probe
Date: Wed, 10 Feb 2016 14:38:49 +0100	[thread overview]
Message-ID: <56BB3D69.9000606@linaro.org> (raw)
In-Reply-To: <56B888A8.5020306@synopsys.com>

On 02/08/2016 01:23 PM, Vineet Gupta wrote:
> On Monday 08 February 2016 05:40 PM, Daniel Lezcano wrote:
>> On 02/02/2016 11:58 AM, Vineet Gupta wrote:
>>> - Remove explicit clocksource setup and let it be done by OF framework
>>>     by defining CLOCKSOURCE_OF_DECLARE() for various timers
>>>
>>> - This allows multiple clocksources to be potentially registered
>>>     simultaneouly: previously we could only do one - as all of them had
>>>     same arc_counter_setup() routine for registration
>>>
>>> - Setup routines also ensure that the underlying timer actually exists.
>>>
>>> - Remove some of the panic() calls if underlying timer is NOT detcted as
>>>     a fallback clocksource might still be available
>>>     1. If GRFC doesn't exist, jiffies clocksource gets registered anyways
>>>     2. if RTC doesn't exist, TIMER1 cetainly will take over (as it is
>>>        always present)
>>>
>>> Cc: Daniel Lezcano <daniel.lezcano at linaro.org>
>>> Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
>>
>> May be it is time to move these drivers into the drivers/clocksource directory
>> where they belong to.
>
> I suppose we could, but that is only possible after this round of "moderization",
> i.e. usage of CLOCKSOURCE_OF_DECLARE() et al.
>
> Plus the move will require a bunch of mechanical crap such as read_aux_reg() which
> only ARC defines (similar to headaches Noam had for his clksrc).
>
> So if we could agree on the sanity of this round of changes, I can work towards
> the imminent move into drivers.

Ok, sounds good.


-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	linux-snps-arc@lists.infradead.org, Alexey.Brodkin@synopsys.com,
	Noam Camus <noamc@ezchip.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] ARC: clocksource: DT based probe
Date: Wed, 10 Feb 2016 14:38:49 +0100	[thread overview]
Message-ID: <56BB3D69.9000606@linaro.org> (raw)
In-Reply-To: <56B888A8.5020306@synopsys.com>

On 02/08/2016 01:23 PM, Vineet Gupta wrote:
> On Monday 08 February 2016 05:40 PM, Daniel Lezcano wrote:
>> On 02/02/2016 11:58 AM, Vineet Gupta wrote:
>>> - Remove explicit clocksource setup and let it be done by OF framework
>>>     by defining CLOCKSOURCE_OF_DECLARE() for various timers
>>>
>>> - This allows multiple clocksources to be potentially registered
>>>     simultaneouly: previously we could only do one - as all of them had
>>>     same arc_counter_setup() routine for registration
>>>
>>> - Setup routines also ensure that the underlying timer actually exists.
>>>
>>> - Remove some of the panic() calls if underlying timer is NOT detcted as
>>>     a fallback clocksource might still be available
>>>     1. If GRFC doesn't exist, jiffies clocksource gets registered anyways
>>>     2. if RTC doesn't exist, TIMER1 cetainly will take over (as it is
>>>        always present)
>>>
>>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>>
>> May be it is time to move these drivers into the drivers/clocksource directory
>> where they belong to.
>
> I suppose we could, but that is only possible after this round of "moderization",
> i.e. usage of CLOCKSOURCE_OF_DECLARE() et al.
>
> Plus the move will require a bunch of mechanical crap such as read_aux_reg() which
> only ARC defines (similar to headaches Noam had for his clksrc).
>
> So if we could agree on the sanity of this round of changes, I can work towards
> the imminent move into drivers.

Ok, sounds good.


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2016-02-10 13:38 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 10:58 [PATCH 0/9] ARC clockevent/clocksource modernization Vineet Gupta
2016-02-02 10:58 ` Vineet Gupta
2016-02-02 10:58 ` [PATCH 1/9] ARC: [dts] Add clk feeding into timers to DTs Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-02 10:58 ` [PATCH 2/9] ARC: [dts] Introduce Timer bindings Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-02 12:48   ` Alexey Brodkin
2016-02-02 12:48     ` Alexey Brodkin
2016-02-02 12:48     ` Alexey Brodkin
2016-02-02 13:15   ` Alexey Brodkin
2016-02-02 13:15     ` Alexey Brodkin
2016-02-02 14:29     ` Vineet Gupta
2016-02-02 14:29       ` Vineet Gupta
2016-02-02 15:36       ` Alexey Brodkin
2016-02-02 15:36         ` Alexey Brodkin
2016-02-02 15:36         ` Alexey Brodkin
2016-02-02 22:57         ` Alexey Brodkin
2016-02-02 22:57           ` Alexey Brodkin
2016-02-02 22:57           ` Alexey Brodkin
2016-02-03 13:44           ` Alexey Brodkin
2016-02-03 13:44             ` Alexey Brodkin
2016-02-03 13:50             ` Alexey Brodkin
2016-02-03 13:50               ` Alexey Brodkin
2016-02-03 13:50               ` Alexey Brodkin
2016-02-02 22:03   ` Rob Herring
2016-02-02 22:03     ` Rob Herring
2016-02-02 22:03     ` Rob Herring
2016-02-03  8:04     ` Vineet Gupta
2016-02-03  8:04       ` Vineet Gupta
2016-02-03 15:39       ` Rob Herring
2016-02-03 15:39         ` Rob Herring
2016-02-03 15:39         ` Rob Herring
2016-02-16  8:44         ` Vineet Gupta
2016-02-16  8:44           ` Vineet Gupta
2016-02-16  8:44           ` Vineet Gupta
2016-02-02 10:58 ` [PATCH 3/9] ARC: clockevent: switch to cpu notifier for clockevent setup Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-02 10:58 ` [PATCH 4/9] ARC: clockevent: Prepare for DT based probe Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-02 10:58 ` [PATCH 5/9] ARC: clockevent: " Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-02 10:58 ` [PATCH 6/9] ARC: clocksource: " Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-08 12:10   ` Daniel Lezcano
2016-02-08 12:10     ` Daniel Lezcano
2016-02-08 12:23     ` Vineet Gupta
2016-02-08 12:23       ` Vineet Gupta
2016-02-10 13:38       ` Daniel Lezcano [this message]
2016-02-10 13:38         ` Daniel Lezcano
2016-02-02 10:58 ` [PATCH 7/9] ARC: use fixed frequencies in arc_set_early_base_baud() Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-02 12:53   ` Alexey Brodkin
2016-02-02 12:53     ` Alexey Brodkin
2016-02-02 13:43     ` christian.ruppert
2016-02-02 13:43       ` christian.ruppert
2016-02-02 14:26       ` Alexey Brodkin
2016-02-02 14:26         ` Alexey Brodkin
2016-02-02 10:58 ` [PATCH 8/9] ARC: [plat-axs] Don't use arc_{get|set}_core_freq() for manipulating core clk Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta
2016-02-02 10:58 ` [PATCH 9/9] ARC: RIP arc_{get|set}_core_freq() clk API Vineet Gupta
2016-02-02 10:58   ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BB3D69.9000606@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.