From: Corneliu ZUZU <czuzu@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>, Tamas K Lengyel <tamas@tklengyel.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>
Subject: Re: [PATCH v2 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h
Date: Wed, 10 Feb 2016 22:54:56 +0200 [thread overview]
Message-ID: <56BBA3A0.4070008@bitdefender.com> (raw)
In-Reply-To: <56BB7E7802000078000D0C4D@prv-mh.provo.novell.com>
On 2/10/2016 7:16 PM, Jan Beulich wrote:
>>>> On 10.02.16 at 17:44, <tamas@tklengyel.com> wrote:
>> On Wed, Feb 10, 2016 at 8:54 AM, Corneliu ZUZU <czuzu@bitdefender.com>
>> wrote:
>>
>>> Rename:
>>> - arch/x86/monitor_x86.c -> arch/x86/monitor.c
>>> - asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h
>>>
>>> (previous commit explains why these renames were necessary)
>>>
>> Referencing a "previous commit" like this is not acceptable as you don't
>> know how these patches will get applied and there might be other patches
>> that get committed in-between yours. In each patch explain clearly why the
>> patch is needed. I still find it odd that you need to rename x86/monitor.c
>> -> x86/monitor_x86.c -> x86/monitor.c in the same series.
> Indeed. Thinking about it again perhaps the operations should be
> "move to common/ (mostly) verbatim" followed by "break out x86
> specific code" (if that's the smaller portion compared to what is to
> stay).
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
That's a great alternative! Will do so in v3.
Corneliu.
next prev parent reply other threads:[~2016-02-10 20:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 15:47 [PATCH v2 0/7] Vm-events: move monitor vm-events code to common-side Corneliu ZUZU
2016-02-10 15:47 ` [PATCH v2 1/7] xen/arm: fix file comments Corneliu ZUZU
2016-02-10 16:05 ` Stefano Stabellini
2016-02-10 15:50 ` [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1 Corneliu ZUZU
2016-02-10 16:18 ` Jan Beulich
2016-02-10 16:37 ` Andrew Cooper
2016-02-10 17:05 ` Jan Beulich
2016-02-10 17:04 ` Corneliu ZUZU
2016-02-10 17:11 ` Jan Beulich
2016-02-10 20:50 ` Corneliu ZUZU
2016-02-10 20:56 ` Andrew Cooper
2016-02-11 10:31 ` Jan Beulich
2016-02-11 6:03 ` Corneliu ZUZU
2016-02-10 17:28 ` Razvan Cojocaru
2016-02-10 17:52 ` Tamas K Lengyel
2016-02-10 15:52 ` [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side Corneliu ZUZU
2016-02-10 16:26 ` Jan Beulich
2016-02-10 16:30 ` Jan Beulich
2016-02-10 17:14 ` Corneliu ZUZU
2016-02-10 17:12 ` Corneliu ZUZU
2016-02-10 16:39 ` Tamas K Lengyel
2016-02-10 17:34 ` Corneliu ZUZU
2016-02-10 17:56 ` Tamas K Lengyel
2016-02-11 7:21 ` Corneliu ZUZU
2016-02-11 15:44 ` Tamas K Lengyel
2016-02-12 6:05 ` Corneliu ZUZU
2016-02-12 8:14 ` Corneliu ZUZU
2016-02-11 6:20 ` Corneliu ZUZU
2016-02-10 15:54 ` [PATCH v2 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h Corneliu ZUZU
2016-02-10 16:44 ` Tamas K Lengyel
2016-02-10 17:16 ` Jan Beulich
2016-02-10 20:54 ` Corneliu ZUZU [this message]
2016-02-10 20:36 ` Corneliu ZUZU
2016-02-10 15:56 ` [PATCH v2 5/7] xen/vm-events: Move hvm_event_* functions to common-side Corneliu ZUZU
2016-02-10 15:58 ` [PATCH v2 6/7] Rename event_x86.c to event.c and event_arch.h to event.h + minor fixes Corneliu ZUZU
2016-02-10 16:00 ` [PATCH v2 7/7] xen/vm-events: move arch_domain.monitor bits to common Corneliu ZUZU
2016-02-10 16:29 ` Jan Beulich
2016-02-10 17:14 ` Corneliu ZUZU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BBA3A0.4070008@bitdefender.com \
--to=czuzu@bitdefender.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=rcojocaru@bitdefender.com \
--cc=stefano.stabellini@citrix.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.