From: Jeremy Kerr <jk@ozlabs.org>
To: openbmc@lists.ozlabs.org
Subject: Code review and deadlines around initial OpenBMC prototypes
Date: Thu, 11 Feb 2016 16:44:35 +0800 [thread overview]
Message-ID: <56BC49F3.8070809@ozlabs.org> (raw)
Hi all,
The IBMers working on OpenBMC are sprinting for a first internal
prototype of the code, with a few functional components still in
development.
Because of this, here's a lot of churn happening at the moment (to get
this prototype launched), but we don't want to let code quality be left
aside as a result.
So, a request to contributors: please take note of any review to your
patch. If you can rework your change in response, please make it a
priority to do so. To save time, most of the folks conducting review are
also available on our IRC channel, #openbmc on irc.freenode.net.
If you see a review for your code *after it has been committed*, and/or
you do not have bandwidth to address the feedback, please file an issue
on the relevant github project. I have created the "code-review" label
on the main openbmc project; please use this for such issues. If you
need it for other github repos, send me a private mail and I'll create one.
During the next few weeks, it'll be especially important to do this, as
we don't want reviews to remain unaddressed after this prototyping work
is complete. Provided we address the issues raised, I don't foresee us
having to continue the issue-filing long-term.
Another note: we have the contribution guidelines available:
https://github.com/openbmc/docs/blob/master/contributing.md
if you haven't already, please take the time to read this, and follow
the when contributing.
Regards,
Jeremy
reply other threads:[~2016-02-11 8:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BC49F3.8070809@ozlabs.org \
--to=jk@ozlabs.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.