Code review and deadlines around initial OpenBMC prototypes

Code review and deadlines around initial OpenBMC prototypes

[Jeremy Kerr]

Hi all,

The IBMers working on OpenBMC are sprinting for a first internal
prototype of the code, with a few functional components still in
development.

Because of this, here's a lot of churn happening at the moment (to get
this prototype launched), but we don't want to let code quality be left
aside as a result.

So, a request to contributors: please take note of any review to your
patch. If you can rework your change in response, please make it a
priority to do so. To save time, most of the folks conducting review are
also available on our IRC channel, #openbmc on irc.freenode.net.

If you see a review for your code *after it has been committed*, and/or
you do not have bandwidth to address the feedback, please file an issue
on the relevant github project. I have created the "code-review" label
on the main openbmc project; please use this for such issues. If you
need it for other github repos, send me a private mail and I'll create one.

During the next few weeks, it'll be especially important to do this, as
we don't want reviews to remain unaddressed after this prototyping work
is complete. Provided we address the issues raised, I don't foresee us
having to continue the issue-filing long-term.

Another note: we have the contribution guidelines available:

  https://github.com/openbmc/docs/blob/master/contributing.md

if you haven't already, please take the time to read this, and follow
the when contributing.

Regards,


Jeremy