All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: vinod.koul@intel.com
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, nsekhar@ti.com,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] dmaengine: edma: Implement device_synchronize callback
Date: Thu, 11 Feb 2016 11:00:57 +0200	[thread overview]
Message-ID: <56BC4DC9.6000309@ti.com> (raw)
In-Reply-To: <1455180872-2620-1-git-send-email-peter.ujfalusi@ti.com>

On 02/11/2016 10:54 AM, Peter Ujfalusi wrote:
> We need the callback to support the dmaengine_terminate_sync().

I have made some typos and I only compiled the kernel after sending the patch..
Resending.

> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/dma/edma.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 2dac314a2d7a..ea0d919a3318 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -869,6 +869,13 @@ static int edma_terminate_all(struct dma_chan *chan)
>  	return 0;
>  }
>  
> +static void edma_synchronize(struct dma_chan *c)
> +{
> +	struct edma_chan *echan = to_edma_chan(chan);
> +
> +	vchan_synchronize(&echan->vchan);
> +}
> +
>  static int edma_slave_config(struct dma_chan *chan,
>  	struct dma_slave_config *cfg)
>  {
> @@ -1808,6 +1815,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
>  	s_ddev->device_pause = edma_dma_pause;
>  	s_ddev->device_resume = edma_dma_resume;
>  	s_ddev->device_terminate_all = edma_terminate_all;
> +	s_ddev->device_synchronize = edma_synchronize;
>  
>  	s_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>  	s_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> @@ -1833,6 +1841,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
>  		m_ddev->device_pause = edma_dma_pause;
>  		m_ddev->device_resume = edma_dma_resume;
>  		m_ddev->device_terminate_all = edma_terminate_all;
> +		m_ddev->device_synchronize = edma_synchronize;
>  
>  		m_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>  		m_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> 


-- 
Péter

WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: edma: Implement device_synchronize callback
Date: Thu, 11 Feb 2016 11:00:57 +0200	[thread overview]
Message-ID: <56BC4DC9.6000309@ti.com> (raw)
In-Reply-To: <1455180872-2620-1-git-send-email-peter.ujfalusi@ti.com>

On 02/11/2016 10:54 AM, Peter Ujfalusi wrote:
> We need the callback to support the dmaengine_terminate_sync().

I have made some typos and I only compiled the kernel after sending the patch..
Resending.

> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/dma/edma.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 2dac314a2d7a..ea0d919a3318 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -869,6 +869,13 @@ static int edma_terminate_all(struct dma_chan *chan)
>  	return 0;
>  }
>  
> +static void edma_synchronize(struct dma_chan *c)
> +{
> +	struct edma_chan *echan = to_edma_chan(chan);
> +
> +	vchan_synchronize(&echan->vchan);
> +}
> +
>  static int edma_slave_config(struct dma_chan *chan,
>  	struct dma_slave_config *cfg)
>  {
> @@ -1808,6 +1815,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
>  	s_ddev->device_pause = edma_dma_pause;
>  	s_ddev->device_resume = edma_dma_resume;
>  	s_ddev->device_terminate_all = edma_terminate_all;
> +	s_ddev->device_synchronize = edma_synchronize;
>  
>  	s_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>  	s_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> @@ -1833,6 +1841,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
>  		m_ddev->device_pause = edma_dma_pause;
>  		m_ddev->device_resume = edma_dma_resume;
>  		m_ddev->device_terminate_all = edma_terminate_all;
> +		m_ddev->device_synchronize = edma_synchronize;
>  
>  		m_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>  		m_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> 


-- 
P?ter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vinod.koul@intel.com>
Cc: <linux-kernel@vger.kernel.org>, <dmaengine@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <nsekhar@ti.com>,
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: edma: Implement device_synchronize callback
Date: Thu, 11 Feb 2016 11:00:57 +0200	[thread overview]
Message-ID: <56BC4DC9.6000309@ti.com> (raw)
In-Reply-To: <1455180872-2620-1-git-send-email-peter.ujfalusi@ti.com>

On 02/11/2016 10:54 AM, Peter Ujfalusi wrote:
> We need the callback to support the dmaengine_terminate_sync().

I have made some typos and I only compiled the kernel after sending the patch..
Resending.

> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/dma/edma.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 2dac314a2d7a..ea0d919a3318 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -869,6 +869,13 @@ static int edma_terminate_all(struct dma_chan *chan)
>  	return 0;
>  }
>  
> +static void edma_synchronize(struct dma_chan *c)
> +{
> +	struct edma_chan *echan = to_edma_chan(chan);
> +
> +	vchan_synchronize(&echan->vchan);
> +}
> +
>  static int edma_slave_config(struct dma_chan *chan,
>  	struct dma_slave_config *cfg)
>  {
> @@ -1808,6 +1815,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
>  	s_ddev->device_pause = edma_dma_pause;
>  	s_ddev->device_resume = edma_dma_resume;
>  	s_ddev->device_terminate_all = edma_terminate_all;
> +	s_ddev->device_synchronize = edma_synchronize;
>  
>  	s_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>  	s_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> @@ -1833,6 +1841,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
>  		m_ddev->device_pause = edma_dma_pause;
>  		m_ddev->device_resume = edma_dma_resume;
>  		m_ddev->device_terminate_all = edma_terminate_all;
> +		m_ddev->device_synchronize = edma_synchronize;
>  
>  		m_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
>  		m_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
> 


-- 
Péter

  reply	other threads:[~2016-02-11  9:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11  8:54 [PATCH] dmaengine: edma: Implement device_synchronize callback Peter Ujfalusi
2016-02-11  8:54 ` Peter Ujfalusi
2016-02-11  8:54 ` Peter Ujfalusi
2016-02-11  9:00 ` Peter Ujfalusi [this message]
2016-02-11  9:00   ` Peter Ujfalusi
2016-02-11  9:00   ` Peter Ujfalusi
2016-02-11 10:36 ` kbuild test robot
2016-02-11 10:36   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BC4DC9.6000309@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.