* [PATCH] block: Initialize max_dev_sectors to 0
@ 2016-02-10 23:52 Keith Busch
2016-02-11 13:01 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Keith Busch @ 2016-02-10 23:52 UTC (permalink / raw)
The new queue limit is not used by the majority of block drivers, and
should be initialized to 0 for the driver's requested settings to be used.
Signed-off-by: Keith Busch <keith.busch at intel.com>
Cc: Christoph Hellwig <hch at infradead.org>
Acked-by: Martin K. Petersen <martin.petersen at oracle.com>
---
block/blk-settings.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-settings.c b/block/blk-settings.c
index dd49735..c7bb666 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -91,8 +91,8 @@ void blk_set_default_limits(struct queue_limits *lim)
lim->seg_boundary_mask = BLK_SEG_BOUNDARY_MASK;
lim->virt_boundary_mask = 0;
lim->max_segment_size = BLK_MAX_SEGMENT_SIZE;
- lim->max_sectors = lim->max_dev_sectors = lim->max_hw_sectors =
- BLK_SAFE_MAX_SECTORS;
+ lim->max_sectors = lim->max_hw_sectors = BLK_SAFE_MAX_SECTORS;
+ lim->max_dev_sectors = 0;
lim->chunk_sectors = 0;
lim->max_write_same_sectors = 0;
lim->max_discard_sectors = 0;
--
2.6.2.307.g37023ba
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] block: Initialize max_dev_sectors to 0
2016-02-10 23:52 [PATCH] block: Initialize max_dev_sectors to 0 Keith Busch
@ 2016-02-11 13:01 ` Sagi Grimberg
2016-02-11 15:20 ` Christoph Hellwig
2016-02-11 15:21 ` Jens Axboe
2 siblings, 0 replies; 6+ messages in thread
From: Sagi Grimberg @ 2016-02-11 13:01 UTC (permalink / raw)
Looks good,
Reviewed-by: Sagi Grimberg <sagig at mellanox.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] block: Initialize max_dev_sectors to 0
2016-02-10 23:52 [PATCH] block: Initialize max_dev_sectors to 0 Keith Busch
2016-02-11 13:01 ` Sagi Grimberg
@ 2016-02-11 15:20 ` Christoph Hellwig
2016-02-11 15:21 ` Jens Axboe
2 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2016-02-11 15:20 UTC (permalink / raw)
On Wed, Feb 10, 2016@04:52:47PM -0700, Keith Busch wrote:
> The new queue limit is not used by the majority of block drivers, and
> should be initialized to 0 for the driver's requested settings to be used.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> Cc: Christoph Hellwig <hch at infradead.org>
> Acked-by: Martin K. Petersen <martin.petersen at oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] block: Initialize max_dev_sectors to 0
2016-02-10 23:52 [PATCH] block: Initialize max_dev_sectors to 0 Keith Busch
2016-02-11 13:01 ` Sagi Grimberg
2016-02-11 15:20 ` Christoph Hellwig
@ 2016-02-11 15:21 ` Jens Axboe
2016-03-01 15:19 ` Christoph Hellwig
2 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2016-02-11 15:21 UTC (permalink / raw)
On 02/10/2016 04:52 PM, Keith Busch wrote:
> The new queue limit is not used by the majority of block drivers, and
> should be initialized to 0 for the driver's requested settings to be used.
That's much better, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] block: Initialize max_dev_sectors to 0
2016-02-11 15:21 ` Jens Axboe
@ 2016-03-01 15:19 ` Christoph Hellwig
2016-03-02 22:42 ` Keith Busch
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2016-03-01 15:19 UTC (permalink / raw)
On Thu, Feb 11, 2016@08:21:24AM -0700, Jens Axboe wrote:
> On 02/10/2016 04:52 PM, Keith Busch wrote:
> >The new queue limit is not used by the majority of block drivers, and
> >should be initialized to 0 for the driver's requested settings to be used.
>
> That's much better, thanks.
Btw, I think we also needs this for 4.4-stable, especially as it's
going to be a long term release.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] block: Initialize max_dev_sectors to 0
2016-03-01 15:19 ` Christoph Hellwig
@ 2016-03-02 22:42 ` Keith Busch
0 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2016-03-02 22:42 UTC (permalink / raw)
On Tue, Mar 01, 2016@07:19:51AM -0800, Christoph Hellwig wrote:
> Btw, I think we also needs this for 4.4-stable, especially as it's
> going to be a long term release.
Agreed, I even received bug reports this week for this issue from
folks using 4.4-stable at the NVMe plugfest. I posted this patch to the
stable list.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-02 22:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 23:52 [PATCH] block: Initialize max_dev_sectors to 0 Keith Busch
2016-02-11 13:01 ` Sagi Grimberg
2016-02-11 15:20 ` Christoph Hellwig
2016-02-11 15:21 ` Jens Axboe
2016-03-01 15:19 ` Christoph Hellwig
2016-03-02 22:42 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.