Re: [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config

[Kevin Smith <kevin.smith@elecsyscorp.com>]

On 02/11/2016 10:04 AM, Thomas Petazzoni wrote:
> Kevin,
>
> On Thu, 11 Feb 2016 16:01:03 +0000, Kevin Smith wrote:
>
>>>> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
>>>> index 64e3d2c..794e7c5 100644
>>>> --- a/arch/arm/mach-mvebu/Kconfig
>>>> +++ b/arch/arm/mach-mvebu/Kconfig
>>>> @@ -32,6 +32,7 @@ config MACH_ARMADA_370
>>>>    	select CPU_PJ4B
>>>>    	select MACH_MVEBU_V7
>>>>    	select PINCTRL_ARMADA_370
>>>> +	select MVEBU_CLK_COREDIV if MTD_NAND_PXA3xx
>>> Thanks for the new iteration. I know the corediv clock is only used for
>>> the NAND, but I'm wondering if it's really worth doing this "if
>>> MTD_NAND_PXA3xx.
>>>
>>> Thomas
>> Maybe I misunderstood.  In your previous e-mail you said "building
>> ARMADA_38X_CLK or ARMADA_375_CLK does not require building
>> clk-corediv.c, it only needs common.c.  So maybe instead we should
>> change arch/arm/mach-mvebu/Kconfig to have MACH_ARMADA_xxx select
>> MVEBU_CLK_COREDIV when needed."  I thought you meant only when a
>> peripheral depended on the coreclk.
>>
>> Should I remove the conditional and just have MACH_ARMADA_XXX always
>> enable MVEBU_CLK_COREDIV for platforms that have it?
> Yes, at least, this is what my comment was suggesting to do. Sorry if
> it was unclear, but my point is that the clock is there regardless of
> whether the NAND driver is available/used.
>
> Anyway, it's not a big deal because the defconfig has the pxa3xx_nand
> driver enabled, so most people are very likely going to have this
> driver enabled on Marvell platforms.
>
> Best regards,
>
> Thomas
Ah, thanks for the clarification.  This sounds good to me.  v3 on the=20
way.  :)

Thank you,
Kevin=