All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Kevin Smith <kevin.smith@elecsyscorp.com>
Cc: "linux-clk\@vger.kernel.org" <linux-clk@vger.kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@codeaurora.org>,
	 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config
Date: Fri, 12 Feb 2016 17:28:37 +0100	[thread overview]
Message-ID: <87r3ghx58q.fsf@free-electrons.com> (raw)
In-Reply-To: <1455209620-6125-2-git-send-email-kevin.smith@elecsyscorp.com> (Kevin Smith's message of "Thu, 11 Feb 2016 16:54:00 +0000")

Hi Kevin,
=20
 On jeu., f=C3=A9vr. 11 2016, Kevin Smith <kevin.smith@elecsyscorp.com> wro=
te:

> The core clock does not depend on corediv, so enabling corediv
> based on the clock is not really correct.  Move the corediv
> config option from the clock driver Kconfig to the mvebu Kconfig
> so that it can be enabled by the MACH option instead.
>
> This also enables corediv on Armada 375 and 38X, which was
> previously missing.
>
> Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory

> ---
>  arch/arm/mach-mvebu/Kconfig | 3 +++
>  drivers/clk/mvebu/Kconfig   | 1 -
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 64e3d2c..71e97da 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -32,6 +32,7 @@ config MACH_ARMADA_370
>  	select CPU_PJ4B
>  	select MACH_MVEBU_V7
>  	select PINCTRL_ARMADA_370
> +	select MVEBU_CLK_COREDIV
>  	help
>  	  Say 'Y' here if you want your kernel to support boards based
>  	  on the Marvell Armada 370 SoC with device tree.
> @@ -48,6 +49,7 @@ config MACH_ARMADA_375
>  	select HAVE_SMP
>  	select MACH_MVEBU_V7
>  	select PINCTRL_ARMADA_375
> +	select MVEBU_CLK_COREDIV
>  	help
>  	  Say 'Y' here if you want your kernel to support boards based
>  	  on the Marvell Armada 375 SoC with device tree.
> @@ -64,6 +66,7 @@ config MACH_ARMADA_38X
>  	select HAVE_SMP
>  	select MACH_MVEBU_V7
>  	select PINCTRL_ARMADA_38X
> +	select MVEBU_CLK_COREDIV
>  	help
>  	  Say 'Y' here if you want your kernel to support boards based
>  	  on the Marvell Armada 380/385 SoC with device tree.
> diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig
> index e1bc567..eaee8f0 100644
> --- a/drivers/clk/mvebu/Kconfig
> +++ b/drivers/clk/mvebu/Kconfig
> @@ -11,7 +11,6 @@ config ARMADA_370_CLK
>  	bool
>  	select MVEBU_CLK_COMMON
>  	select MVEBU_CLK_CPU
> -	select MVEBU_CLK_COREDIV
>=20=20
>  config ARMADA_375_CLK
>  	bool
> --=20
> 2.4.6

--=20
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2016-02-12 16:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 20:41 [PATCH] clk: mvebu: Require corediv clock for Armada 38x Kevin Smith
2016-02-10 21:28 ` Thomas Petazzoni
2016-02-10 23:38   ` Kevin Smith
2016-02-10 23:40 ` [PATCH v2 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith
2016-02-10 23:40   ` [PATCH v2 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith
2016-02-11  8:16     ` Thomas Petazzoni
2016-02-11 16:01       ` Kevin Smith
2016-02-11 16:04         ` Thomas Petazzoni
2016-02-11 16:10           ` Kevin Smith
2016-02-11 16:53 ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Kevin Smith
2016-02-11 16:54   ` [PATCH v3 2/2] clk: mvebu: Move corediv config to mvebu config Kevin Smith
2016-02-12 16:28     ` Gregory CLEMENT [this message]
2016-02-18  1:16     ` Michael Turquette
2016-02-25 23:06     ` Stephen Boyd
2016-02-12 16:28   ` [PATCH v3 1/2] clk: mvebu: Remove corediv clock from Armada XP Gregory CLEMENT
2016-02-18  1:16   ` Michael Turquette
2016-02-18  8:11     ` Thomas Petazzoni
2016-02-18 17:54       ` Gregory CLEMENT
2016-02-25 23:06   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3ghx58q.fsf@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=kevin.smith@elecsyscorp.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.