From: Matthias Brugger <matthias.bgg@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jslaby@suse.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m
Date: Fri, 12 Feb 2016 00:14:14 +0100 [thread overview]
Message-ID: <56BD15C6.6040006@gmail.com> (raw)
In-Reply-To: <1455205297-1021302-6-git-send-email-arnd@arndb.de>
On 11/02/16 16:41, Arnd Bergmann wrote:
> The Mediatek 8250 driver has a 'bool' Kconfig symbol, but that
> breaks when SERIAL_8250 is a loadable module:
>
> drivers/tty/built-in.o: In function `mtk8250_set_termios':
> :(.text+0x1bee8): undefined reference to `serial8250_do_set_termios'
> :(.text+0x1bf10): undefined reference to `uart_get_baud_rate'
> :(.text+0x1c09c): undefined reference to `uart_get_divisor'
> drivers/tty/built-in.o: In function `mtk8250_do_pm':
> :(.text+0x1c0d0): undefined reference to `serial8250_do_pm'
> drivers/tty/built-in.o: In function `mtk8250_probe':
> :(.text+0x1c2e4): undefined reference to `serial8250_register_8250_port'
> serial/8250/8250_mtk.c:287:242: error: data definition has no type or storage class [-Werror]
> serial/8250/8250_mtk.c:287:122: error: 'mtk8250_platform_driver_init' defined but not used [-Werror=unused-function]
>
> This changes the symbol to a 'tristate', so the dependency on
> SERIAL_8250 also works when that is set to 'm'.
> To actually build the driver, we also need to include <linux/module.h>.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m
Date: Fri, 12 Feb 2016 00:14:14 +0100 [thread overview]
Message-ID: <56BD15C6.6040006@gmail.com> (raw)
In-Reply-To: <1455205297-1021302-6-git-send-email-arnd@arndb.de>
On 11/02/16 16:41, Arnd Bergmann wrote:
> The Mediatek 8250 driver has a 'bool' Kconfig symbol, but that
> breaks when SERIAL_8250 is a loadable module:
>
> drivers/tty/built-in.o: In function `mtk8250_set_termios':
> :(.text+0x1bee8): undefined reference to `serial8250_do_set_termios'
> :(.text+0x1bf10): undefined reference to `uart_get_baud_rate'
> :(.text+0x1c09c): undefined reference to `uart_get_divisor'
> drivers/tty/built-in.o: In function `mtk8250_do_pm':
> :(.text+0x1c0d0): undefined reference to `serial8250_do_pm'
> drivers/tty/built-in.o: In function `mtk8250_probe':
> :(.text+0x1c2e4): undefined reference to `serial8250_register_8250_port'
> serial/8250/8250_mtk.c:287:242: error: data definition has no type or storage class [-Werror]
> serial/8250/8250_mtk.c:287:122: error: 'mtk8250_platform_driver_init' defined but not used [-Werror=unused-function]
>
> This changes the symbol to a 'tristate', so the dependency on
> SERIAL_8250 also works when that is set to 'm'.
> To actually build the driver, we also need to include <linux/module.h>.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
next prev parent reply other threads:[~2016-02-11 23:14 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 15:41 [PATCH v2 0/6] serial: 8250: fixes for modular build Arnd Bergmann
2016-02-11 15:41 ` Arnd Bergmann
2016-02-11 15:41 ` [PATCH v2 1/6] Revert "drivers/tty/serial: make 8250/8250_mtk.c explicitly non-modular" Arnd Bergmann
2016-02-11 15:41 ` Arnd Bergmann
2016-02-11 16:00 ` Paul Gortmaker
2016-02-11 16:00 ` Paul Gortmaker
2016-02-11 16:00 ` Paul Gortmaker
[not found] ` <20160211160021.GF28452-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2016-02-11 16:06 ` Arnd Bergmann
2016-02-11 16:06 ` Arnd Bergmann
2016-02-11 16:06 ` Arnd Bergmann
2016-02-11 16:28 ` Paul Gortmaker
2016-02-11 16:28 ` Paul Gortmaker
2016-02-11 16:28 ` Paul Gortmaker
2016-02-11 16:32 ` Arnd Bergmann
2016-02-11 16:32 ` Arnd Bergmann
2016-02-11 15:41 ` [PATCH v2 2/6] Revert "drivers/tty/serial: make 8250/8250_ingenic.c " Arnd Bergmann
2016-02-11 15:41 ` Arnd Bergmann
2016-02-11 16:02 ` Paul Gortmaker
2016-02-11 16:02 ` Paul Gortmaker
2016-02-11 16:02 ` Paul Gortmaker
[not found] ` <1455205297-1021302-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2016-02-11 15:41 ` [PATCH v2 3/6] serial: 8250/mediatek: mark PM functions as __maybe_unused Arnd Bergmann
2016-02-11 15:41 ` Arnd Bergmann
2016-02-11 15:41 ` Arnd Bergmann
2016-02-11 15:41 ` [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Arnd Bergmann
2016-02-11 15:41 ` Arnd Bergmann
2016-02-12 9:37 ` Masahiro Yamada
2016-02-12 9:37 ` Masahiro Yamada
2016-02-12 10:07 ` Arnd Bergmann
2016-02-12 10:07 ` Arnd Bergmann
2016-02-12 10:38 ` Masahiro Yamada
2016-02-12 10:38 ` Masahiro Yamada
2016-02-12 16:37 ` Masahiro Yamada
2016-02-12 16:37 ` Masahiro Yamada
2016-02-11 15:41 ` [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m Arnd Bergmann
2016-02-11 15:41 ` Arnd Bergmann
2016-02-11 16:04 ` Paul Gortmaker
2016-02-11 16:04 ` Paul Gortmaker
2016-02-11 16:04 ` Paul Gortmaker
2016-02-11 16:31 ` Arnd Bergmann
2016-02-11 16:31 ` Arnd Bergmann
2016-02-11 23:14 ` Matthias Brugger [this message]
2016-02-11 23:14 ` Matthias Brugger
2016-02-12 9:43 ` Masahiro Yamada
2016-02-12 9:43 ` Masahiro Yamada
2016-02-11 15:41 ` [PATCH v2 6/6] serial: 8250/ingenic: " Arnd Bergmann
2016-02-11 15:41 ` Arnd Bergmann
2016-02-12 9:45 ` Masahiro Yamada
2016-02-12 9:45 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BD15C6.6040006@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=arnd@arndb.de \
--cc=eddie.huang@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=s.hauer@pengutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.