From: "Michel Dänzer" <michel@daenzer.net>
To: Alexandre Demers <alexandre.f.demers@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] radeon: Define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP for consistency and readability
Date: Fri, 12 Feb 2016 16:36:35 +0900 [thread overview]
Message-ID: <56BD8B83.2010100@daenzer.net> (raw)
In-Reply-To: <1455236952-3529-1-git-send-email-alexandre.f.demers@gmail.com>
On 12.02.2016 09:29, Alexandre Demers wrote:
> ---
> drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
> include/uapi/drm/radeon_drm.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
> index 801dd60..c88f9fe 100644
> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
> @@ -1287,7 +1287,7 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
> } else {
> switch (target_fb->bits_per_pixel) {
> case 8:
> - index = 10;
> + index = SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP;
> break;
> case 16:
> index = SI_TILE_MODE_COLOR_2D_SCANOUT_16BPP;
> diff --git a/include/uapi/drm/radeon_drm.h b/include/uapi/drm/radeon_drm.h
> index ccb9bcd..407a092 100644
> --- a/include/uapi/drm/radeon_drm.h
> +++ b/include/uapi/drm/radeon_drm.h
> @@ -1057,6 +1057,7 @@ struct drm_radeon_info {
> #define SI_TILE_MODE_COLOR_2D_16BPP 15
> #define SI_TILE_MODE_COLOR_2D_32BPP 16
> #define SI_TILE_MODE_COLOR_2D_64BPP 17
> +#define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP 10
> #define SI_TILE_MODE_COLOR_2D_SCANOUT_16BPP 11
> #define SI_TILE_MODE_COLOR_2D_SCANOUT_32BPP 12
> #define SI_TILE_MODE_DEPTH_STENCIL_1D 4
>
The shortlog (subject line) is a bit long, but other than that,
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-02-12 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 0:29 [PATCH] radeon: Define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP for consistency and readability Alexandre Demers
2016-02-12 7:36 ` Michel Dänzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BD8B83.2010100@daenzer.net \
--to=michel@daenzer.net \
--cc=alexandre.f.demers@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.